00:32:53  * unixpicklequit (Quit: My Mac has gone to sleep. ZZZzzz…)
00:44:35  * unixpicklejoined
01:20:36  * zvjoined
01:57:47  * plutoniixquit (Quit: Leaving)
02:04:00  * zvquit (Read error: Connection reset by peer)
02:31:00  * unixpicklequit (Quit: My Mac has gone to sleep. ZZZzzz…)
02:42:39  * bradleymeckjoined
03:16:20  * bradleymeckquit (Quit: bradleymeck)
03:31:25  * zvjoined
03:45:34  * zvquit (Read error: Connection reset by peer)
03:46:37  * zvjoined
05:00:54  * plutoniixjoined
05:00:56  * plutoniixquit (Max SendQ exceeded)
05:01:25  * plutoniixjoined
05:02:23  * plutoniixquit (Max SendQ exceeded)
05:02:49  * plutoniixjoined
05:03:50  * plutoniixquit (Max SendQ exceeded)
05:04:17  * plutoniixjoined
06:37:02  * aperezdcquit (Remote host closed the connection)
06:54:05  * plutoniixquit (Quit: Leaving)
07:22:27  * davijoined
07:32:50  * BobGneuquit (Remote host closed the connection)
07:33:08  * BobGneujoined
07:48:03  * plutoniixjoined
08:03:57  * plutoniixquit (Quit: จรลี จรลา)
08:08:02  * daviquit (Ping timeout: 258 seconds)
08:38:32  * BobGneuquit (Remote host closed the connection)
08:38:49  * BobGneujoined
08:46:01  * davijoined
08:51:44  * daviquit (Ping timeout: 258 seconds)
09:31:38  * aperezdcjoined
09:44:40  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20arm%20-%20debug%20builder/builds/7690 "V8 Linux ASAN arm - debug builder" from f0dc0dbf21841d8746f26b8f6bde98468b7e0810: machenbach@chromium.org)
09:54:44  * plutoniixjoined
10:30:03  * BobGneuquit (Read error: Connection reset by peer)
10:39:19  <trungl-bot>Tree opened by bmeurer@google.com: Tree is open
10:42:21  <trungl-bot>Tree opened by machenbach@chromium.org: open - will fix clusterfuzz compilation soon
10:44:56  * Cube8joined
10:45:13  * ewanasjoined
11:09:26  * davijoined
11:30:19  * plutoniixquit (Quit: จรลี จรลา)
11:33:12  * Garbeejoined
11:43:10  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "Mjsunit" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6304 "V8 Linux64 GC Stress - custom snapshot" from 36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea: rmcilroy@chromium.org)
11:53:16  * Cube8quit (Quit: Leaving)
12:05:39  * daviquit (Ping timeout: 276 seconds)
12:12:34  <trungl-bot>Tree opened by machenbach@chromium.org: open
12:30:23  * bradleymeckjoined
12:51:34  * ewanasquit (Ping timeout: 250 seconds)
12:57:07  * ewanasjoined
13:09:47  * unixpicklejoined
13:12:33  * davijoined
13:12:33  * daviquit (Changing host)
13:12:33  * davijoined
13:19:16  * daviquit (Ping timeout: 244 seconds)
13:21:52  * jugglinmikejoined
13:30:06  * bobmcwjoined
14:26:05  <trungl-bot>Tree closed by machenbach@chromium.org: closed - maintenance
14:33:10  <trungl-bot>Tree opened by machenbach@chromium.org: open
14:33:40  * bradleymeckquit (Quit: bradleymeck)
14:54:51  * bradleymeckjoined
15:13:24  <bradleymeck>aklein: ping when change, wondering if your time is freeing up for a gathering of minds
15:33:35  * davijoined
15:47:58  * seventhjoined
15:49:26  * plutoniixjoined
16:04:25  * Garbeequit (Quit: Connection closed for inactivity)
16:08:00  * ewanasquit (Ping timeout: 260 seconds)
16:12:05  * bobmcw_joined
16:13:57  * bobmcwquit (Ping timeout: 276 seconds)
16:25:25  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
16:26:41  * bradleymeckquit (Quit: bradleymeck)
16:27:41  * Garbeejoined
17:11:55  * bobmcw_changed nick to bobmcw
17:11:55  * bobmcwquit (Changing host)
17:11:55  * bobmcwjoined
17:36:04  * ewanasjoined
18:05:11  <aklein>jwolfe: one neat trick you can use when relanding your patch is to add a layout test bot to your CL description
18:05:26  <aklein>just add "CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel"
18:05:42  <jwolfe>oh, that sounds awesome.
18:06:20  <jwolfe>i add that line to the description under the BUG= and LOG= lines?
18:06:44  <jwolfe>aklein, speaking of which, what do i do about the Commited: stuff? delete it? leave it?
18:07:18  <aklein>jwolfe: yeah, it goes with those other SHOUT ones
18:07:57  <aklein>jwolfe: generally opening a new rietveld issue is preferred
18:08:01  <aklein>then you don't have to worry about this stuff
18:08:06  <jwolfe>"SHOUT"? you mean how they're in all caps? or is SHOUT an acronym or something?
18:08:14  <aklein>yeah, all capps
18:08:15  <aklein>caps
18:09:09  <jwolfe>aklein, so i've heard, but opening a new rietveld issue seems like a lot of hassle. it sounds like you're saying you don't know what to do about the Commit: lines.
18:12:19  <aklein>jwolfe: why is it a hassle?
18:13:31  <aklein>in the branch, you can say 'git cl issue 0' to clear out the association with the existing issue
18:13:39  <aklein>and then git cl upload again to create a new one
18:13:48  <aklein>the biggest hassle is maybe copying and pasting the CL description?
18:14:15  <aklein>bug keeping a separate issue with each commit makes it easier to follow breadcrumbs in the future if someone wants to see, e.g., the code review for a particular commit
18:14:34  <jwolfe>last time i did it, i made a faux pas by not starting with a patch that was the original and then making a second patch that showed the changes.
18:15:12  <jwolfe>aklein, does it really make breadcrumbs easier though? i would have thought keeping all the relevant changes and comments together would be easier to follow.
18:16:22  <aklein>in my experience, yes. there's also something to be said for consistency in this respect.
18:19:10  <jwolfe>would it make sense to have a button/link in rietveld for CL's that get reverted to create a reland CL? it seems like a lot of the information is mechanically determinable. and having it automated would be even better for consistency.
18:23:05  * rhalffjoined
18:23:22  <aklein>jwolfe: there's an ongoing project to replace rietveld with a better-maintained code review tool...not sure all the features it will have, but part of the unfortunate consequence is that adding features to rietveld isn't happening super-fast
18:27:19  <jwolfe>ah. so any anger i have for rietveld can find comradery in its doomed future. :) well, as long as I'm a member of a non-singleton haters club, i'll be happy to jump through hoops in the time being. :)
18:34:28  <aklein>sounds good :)
18:39:43  <aklein>jwolfe: also I'll join you in being sad about how slow the chromium commit queue is
18:43:52  * ofrobotschanged nick to ofrobots_out-of-
18:44:01  * ofrobots_out-of-changed nick to ofrobots_away
19:28:40  * seventhquit (Ping timeout: 264 seconds)
19:28:40  * dagobert________quit (Ping timeout: 264 seconds)
19:30:28  * daviquit (Ping timeout: 264 seconds)
19:30:28  * jugglinmikequit (Ping timeout: 264 seconds)
19:31:04  * decoderquit (Ping timeout: 264 seconds)
19:31:18  * jugglinmikejoined
19:31:46  * decoderjoined
19:42:05  * dagobert________joined
20:34:26  * Garbeequit (Quit: Connection closed for inactivity)
20:43:29  * Garbeejoined
20:59:47  * ewanasquit (Ping timeout: 260 seconds)
21:29:29  <aklein>caitp: you happen to see https://bugs.chromium.org/p/chromium/issues/detail?id=621496?
21:29:47  <caitp>looking
21:29:54  <caitp>I did see it
21:30:39  <caitp>I'm not sure why that wouldn't affect non-rest destructuring, so it's probably just a fluke that that blames to me
21:30:50  <caitp>but it doesn't really matter I guess
21:31:45  <caitp>aklein: I'm done for the day, I could look at it tomorrow if nobody gets to it first (also, am out of country / away from my usual office, so I may be a bit slower than usual)
21:33:26  * unixpicklequit (Quit: My Mac has gone to sleep. ZZZzzz…)
21:50:47  * unixpicklejoined
21:53:30  * bobmcwquit (Remote host closed the connection)
22:05:15  * ewanasjoined
22:26:03  * rhalffquit (Ping timeout: 244 seconds)
22:30:59  * RT|Chatzillajoined
22:36:16  * unixpicklequit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:44:08  * unixpicklejoined
23:33:48  * bradleymeckjoined
23:44:23  <aklein>caitp: well, without the spread it correctly complains. I suspect there's some interaction with the spread rewriting code (which is why I CCed nikolaos)
23:45:23  <caitp>interesting
23:48:12  * ewanasquit (Ping timeout: 244 seconds)
23:50:40  * thefourtheyequit (Quit: Connection closed for inactivity)