00:47:33  * JoWiequit (Quit: Connection closed for inactivity)
00:53:45  * plutoniixjoined
01:02:02  * bnoordhuisjoined
01:06:15  * esasquit (Ping timeout: 255 seconds)
01:06:26  * bnoordhuisquit (Ping timeout: 240 seconds)
02:11:56  * evanluca_joined
02:14:06  * evanlucasquit (Ping timeout: 240 seconds)
02:19:37  * jgiquit (Quit: jgi)
02:24:11  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
02:31:18  * ofrobotsjoined
02:45:33  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
04:00:47  * bradleymeckquit (Quit: bradleymeck)
05:12:39  * jgijoined
05:16:06  * ofrobotsjoined
05:38:58  * jgiquit (Quit: jgi)
05:45:41  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
07:16:39  * C-Manjoined
07:44:36  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse4/builds/6842 "V8 Linux - nosse4" from eeee7ab050013782704b5f89e49d06a30b3455c4: yangguo@chromium.org)
08:00:46  <trungl-bot>Tree opened by machenbach@chromium.org: open
08:08:34  * mostynbjoined
08:16:52  * AndreasMadsenjoined
08:39:55  * C-Manquit (Quit: Connection reset by beer)
09:04:59  * JoWiejoined
09:49:24  * Net147quit (Ping timeout: 265 seconds)
09:59:25  * petka___joined
10:04:52  * bnoordhuisjoined
10:14:58  * plutoniixquit (Quit: จรลี จรลา)
10:21:43  * rendarjoined
10:40:52  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/1209 "V8 Linux64 - cfi" from 13b39259998de3038f7767468aa981cc349c5471: jarin@chromium.org,oth@chromium.org,titzer@chromium.org)
10:52:12  * AndreasMadsenquit
11:05:03  <trungl-bot>Tree opened by machenbach@chromium.org: open
11:18:55  * AndreasMadsenjoined
11:52:47  * AndreasMadsenquit
12:25:43  * bnoordhuisquit (Ping timeout: 272 seconds)
12:27:58  * bnoordhuisjoined
12:31:44  * juanjosanchezjoined
12:40:54  * juanjosanchezquit (Ping timeout: 250 seconds)
13:01:21  * bobmcwjoined
13:01:21  * bobmcwquit (Changing host)
13:01:21  * bobmcwjoined
13:37:25  * bradleymeckjoined
14:01:35  * bnoordhuisquit (Ping timeout: 240 seconds)
14:15:22  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8.fyi/builders/Android%20Builder/builds/1677 "Android Builder" from 1e82da4b3077b03a2e75a371d28c5dfbc7f823ff: bmeurer@chromium.org,ishell@chromium.org,machenbach@chromium.org,titzer@chromium.org,ulan@chromium.org)
14:22:25  <trungl-bot>Tree opened by bmeurer@google.com: Tree is open
14:33:05  * bobmcw_joined
14:35:51  * bobmcwquit (Ping timeout: 250 seconds)
14:35:55  * bobmcw_changed nick to bobmc
14:35:56  * bobmcchanged nick to bobmcw
14:35:57  * bobmcwquit (Changing host)
14:35:57  * bobmcwjoined
14:50:40  <trungl-bot>Tree closed by machenbach@chromium.org: closed (maintenance)
15:02:23  * plutoniixjoined
15:08:35  * bnoordhuisjoined
15:08:49  <trungl-bot>Tree closed by machenbach@chromium.org: closed (waiting for moar coverage to kick in)
15:13:00  * bnoordhuisquit (Ping timeout: 250 seconds)
15:20:54  <trungl-bot>Tree opened by machenbach@chromium.org: open
15:22:22  * mostynbquit (Quit: Leaving)
15:37:12  * ncthom91joined
16:04:24  * bradleymeckquit (Quit: bradleymeck)
16:05:53  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
16:07:01  * bradleymeckjoined
16:12:21  * bradleymeckquit (Quit: bradleymeck)
16:12:58  * esasjoined
16:13:56  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014])
16:19:07  * bnoordhuisjoined
16:25:53  * ofrobotsjoined
16:40:33  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:40:57  * ofrobotsjoined
16:44:35  * ncthom91joined
16:50:48  * AndreasMadsenjoined
16:53:33  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:59:24  * jgijoined
17:04:57  * AndreasM_joined
17:07:33  * AndreasMadsenquit (Ping timeout: 272 seconds)
17:37:58  <trungl-bot>Tree closed by buildbot@chromium.org: Tree is closed (Automatic: "Mjsunit" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2824 "V8 Linux64 GC Stress - custom snapshot" from 38ec44f3bde8c16448e093b6595d0452e189023f: bmeurer@chromium.org,hpayer@chromium.org)
17:41:30  * davijoined
17:44:17  * C-Manjoined
17:46:20  * ofrobotsjoined
17:50:30  * jgiquit (Quit: jgi)
18:02:28  * jgijoined
18:11:31  * daviquit (Ping timeout: 272 seconds)
18:26:46  * petka___quit (Ping timeout: 240 seconds)
18:29:07  * petka___joined
18:29:42  * AndreasM_quit (Remote host closed the connection)
18:33:18  * petka___quit (Client Quit)
18:49:20  * davijoined
19:18:17  <aklein>caitp: you said you don't understand why the DCHECK is gone; did you change something or did it go away on its own?
19:21:46  <trungl-bot>Tree opened by machenbach@chromium.org: open
19:29:26  * AndreasMadsenjoined
19:29:48  <trungl-bot>Tree closed by machenbach@chromium.org: closed (let builders catch up)
19:29:51  <caitp>aklein: i know what caused the fix, just not sure why it caused it
19:30:36  <caitp>i had changed the initializer rewriting thing to use the wrong scope
19:30:54  <caitp>even though it was consistently the same scope
19:31:26  <caitp>changing that bit back fixed it, so that's cool
19:32:51  <caitp>i think it means there are tests missing the observable side affects of using the wrong scope for initializer, tho
19:33:41  * AndreasM_joined
19:34:30  * AndreasMadsenquit (Ping timeout: 260 seconds)
19:36:00  <aklein>caitp: sorry, what do you mean? how could we write a test that forces the wrong scope to be passed?
19:36:42  <caitp>aklein: I made some changes to the rewriter so that it doesn't depend on the declaration descriptor ting
19:36:44  <caitp>thing*
19:37:00  <caitp>part of that is saving the parser/scope as members of the pattern rewriter
19:37:34  <caitp>in some cleanup, I changed the arrow initializer rewriter thing to use the cached scope rather than the descriptor scope (iirc, they're the same thing, but I guess not always)
19:37:43  <caitp>and yeah, that broke rewriting
19:37:53  <caitp>or maybe the cached scope is just always Parser::scope_
19:38:05  <caitp>which would explain it not working there
19:38:49  <caitp>I would assume that there would be obserable side effects to not rewriting teh initializer scope
19:39:08  <caitp>but apparently didn't cause any test failures, so I think that just means there's some coverage missing
19:39:30  <aklein>that may be, but this patch has gotten way too big for me to reason about a single bit like that
19:39:37  <aklein>if you comment out the rewriting tests definitely break
19:39:44  <caitp>yeah
19:40:07  <aklein>see harmony/regress/regress-4395.js
19:40:32  <aklein>there are sort of two cases we get wrong, though...
19:40:41  <caitp>so, changing that snippet back to before the little "cleanup" fixes it
19:41:14  <caitp>or maybe still leaves something broken, but, at least nothing that test coverage notices
19:41:43  <caitp>all the remaining test262 failures under the skipped destructuring assignment tests are about not implementing the SetFunctionName() steps in the spec
19:41:44  <aklein>right, though now the code is even weirder looking, since there's some places that use the descriptor scope and some that use PartternRewriter::scope
19:42:18  <caitp>yeah, that's unfortunate... would some DCHECK(IsBindingContext()) make that clearer?
19:42:24  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
19:45:01  <aklein>maybe? have to go look at the the uses of the two kinds. still seems very fragile
19:45:45  <aklein>ok, I think I know what sort of missing coverage we have
19:45:59  <aklein>all of regress-4395 is addressing the breakage when eagerly compiling
19:46:04  <aklein>but there's also breakage when lazily compiling
19:46:17  <aklein>and that matches yang's guess that we get different scope chains
19:51:43  <caitp>okay so in DeclareAndInitializeVariables yeah, it caches the wrong scope
19:52:06  <caitp>it would look cleaner if it cached the descriptor scope instead of the parser scope
19:52:12  <caitp>maybe that would look less fragile
20:05:18  * AndreasM_quit (Ping timeout: 260 seconds)
20:08:09  <trungl-bot>Tree opened by machenbach@chromium.org: open
20:11:57  * rendarquit (Ping timeout: 255 seconds)
20:13:26  * rendarjoined
20:19:47  * bnoordhuisquit (Ping timeout: 276 seconds)
20:27:17  * bnoordhuisjoined
20:33:41  <behelit>is it possible to serialize a v8 context and load it in, say, another os process?
20:37:05  <aklein>caitp: so what's the next step here? are you waiting for review of the current patchset, or doing more cleanup of the scope stuff?
20:37:44  <caitp>it awaits review
20:38:37  <caitp>I may push some more cleanup in the meantime, but it shouldn't block review of the big mess
20:39:00  <caitp>s/mess/rietveld issue/
20:40:22  <aklein>caitp: how do you feel about the test coverage? it looks like you have lots of parsing tests but not very many behavior tests
20:41:13  <caitp>aklein: I've also been testing against test262 although it's not part of the CI tests (because of needing changes to add the flag and stuff)
20:41:36  <caitp>someone had told me "don't duplicate a bunch of test262 stuff, contribute back to test262 instead" so
20:41:52  <caitp>can't remember if that was domenic or dan or someone else
20:42:13  <aklein>I don't feel that way for something as big as this, fwiw
20:43:07  <caitp>alright
20:45:35  <caitp>i've done a bit of work on the jsc destructuring impl, I could port in the tests from that, in addition to test262 stuff
20:54:42  <aklein>more tests are always good. though I do hate webkit layout tests for JS stuff, due to the fiddliness of the text output
21:13:41  * daviquit (Ping timeout: 246 seconds)
21:26:32  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
21:39:31  * ofrobotsjoined
21:45:31  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
21:48:21  * jgiquit (Quit: jgi)
21:55:33  * C-Manquit (Quit: Connection reset by beer)
21:59:10  * ofrobotsjoined
21:59:36  <aklein>caitp: it's probably no surprise, but I won't be around until Monday, starting in about 3 hours
21:59:59  <caitp>have a good thanksgiving
22:00:16  <aklein>likewise
22:26:35  * evanluca_changed nick to evanlucas
22:31:45  * RT|Chatzillajoined
22:36:34  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:37:41  * jgijoined
22:51:32  * ofrobotsjoined
23:21:16  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
23:26:20  * ncthom91joined
23:26:32  * ofrobotsjoined
23:27:33  * ncthom91quit (Client Quit)
23:29:40  * bobmcwquit (Remote host closed the connection)
23:53:26  * xiinotulpjoined
23:57:10  * plutoniixquit (Ping timeout: 265 seconds)