00:11:07  * qardquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
00:11:29  * dave0x6djoined
00:15:28  * nodejs-ghjoined
00:15:28  * nodejs-ghpart
00:18:44  <TimothyGu>devsnek: would it be a simpler solution to just have fs.mjs etc. again? :/
00:18:46  * qardjoined
00:18:55  <devsnek>i have no idea anymore
00:19:04  <devsnek>we still need to solve deprecation anyway
00:19:39  <devsnek>which is bigger picture
00:51:13  * marthinaljoined
00:53:03  * nodejs-ghjoined
00:53:03  * nodejs-ghpart
00:53:19  * nodejs-ghjoined
00:53:19  * nodejs-ghpart
00:55:38  * marthinalquit (Ping timeout: 256 seconds)
01:03:50  * not-an-aardvarkjoined
01:14:14  * qardquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
01:16:37  * srl295joined
01:16:41  * nodejs-ghjoined
01:16:41  * nodejs-ghpart
01:17:36  * nodejs-ghjoined
01:17:36  * nodejs-ghpart
01:18:18  <srl295>joyee: thanks for git-node … just a question, does "land" actually push to github? or just setup everything lese?
01:19:02  <joyee>srl295: no, it doesn't push, only prints the command that you would use for pushing it
01:19:24  <joyee>I ususally run `make test` after it lands just in case
01:19:49  <srl295>joyee: okay. I've been unplugging the network after hitting return but i thought i might as well just ask
01:20:36  <joyee>BTW I am fixing https://github.com/nodejs/node-core-utils/issues/144
01:21:19  <joyee>Should've deleted my .ncu directory and test it...or...just write the test lol
01:21:52  <srl295>joyee: no problem: also i had https://github.com/nodejs/core-validate-commit/issues/12 and my local version broke (so, i think i'll just uninstall my git hook for now)
01:23:33  * AtumTquit (Remote host closed the connection)
01:24:11  <srl295>also - anyone, freebsd tests - parallel/test-cluster-send-handle-large-payload - is this known to be flaky?
01:27:33  <srl295>i'll ccheck this later. trying to finally land https://github.com/nodejs/node/pull/17687
01:38:05  * nodejs-ghjoined
01:38:05  * nodejs-ghpart
01:43:39  * nodejs-ghjoined
01:43:39  * nodejs-ghpart
01:47:49  <joyee>srl295: the git hook looks awesome. I am trying to see if I can just move core-validate-commit into node-core-utils, then we can probably make a git hook in the collection for people to link
01:49:04  <joyee>We can try to make core-validate-commit a library instead of an executable in the collection so you don't have to fixup the commit message in the hook (I think the hook can be node scripts as well?)
01:50:11  * BridgeARquit (Ping timeout: 265 seconds)
01:50:41  * nodejs-ghjoined
01:50:41  * nodejs-ghpart
01:53:18  <srl295>Yes should be able to thanks. I’ve used this for a year
01:55:15  * dagobert__quit (*.net *.split)
01:55:15  * TimothyGuquit (*.net *.split)
01:55:18  * williamkapkequit (*.net *.split)
01:55:18  * mcollinaquit (*.net *.split)
01:55:44  * TimothyGujoined
01:55:59  * williamkapkejoined
01:56:01  * mcollinajoined
01:56:16  * dagobert__joined
02:01:35  * nodejs-ghjoined
02:01:35  * nodejs-ghpart
02:58:23  * nodejs-ghjoined
02:58:23  * nodejs-ghpart
03:11:40  <srl295>https://github.com/nodejs/node/pull/17687 can i get some help in evaluating the failures :(
03:20:58  * dave0x6dquit (Quit: Connection closed for inactivity)
03:30:05  * bretquit (*.net *.split)
03:30:06  * iangcarrollquit (*.net *.split)
03:30:06  * orangemochaquit (*.net *.split)
03:30:06  * tanepiperquit (*.net *.split)
03:30:06  * rjungemannquit (*.net *.split)
03:30:06  * Domenicquit (*.net *.split)
03:30:07  * addaleaxquit (*.net *.split)
03:30:07  * cspotcodequit (*.net *.split)
03:30:07  * parkerkanequit (*.net *.split)
03:30:07  * voxpelliquit (*.net *.split)
03:30:07  * MLM_quit (*.net *.split)
03:30:07  * othiym23quit (*.net *.split)
03:30:07  * joaocgreisquit (*.net *.split)
03:30:07  * tooshelquit (*.net *.split)
03:31:02  * tanepiperjoined
03:31:05  * orangemochajoined
03:31:09  * Domenicjoined
03:31:13  * othiym23joined
03:31:17  * parkerkanejoined
03:31:21  * bretjoined
03:31:22  * iangcarrolljoined
03:31:22  * joaocgreisjoined
03:31:25  * addaleaxjoined
03:31:28  * toosheljoined
03:31:30  * MLM_joined
03:31:31  * voxpellijoined
03:31:33  * rjungemannjoined
03:31:34  * cspotcodejoined
03:40:10  <joyee>srl295 are you getting a new CI run? the one https://github.com/nodejs/node/pull/17687#issuecomment-354119484 already expired
03:41:25  <joyee>I think it's https://ci.nodejs.org/job/node-test-pull-request/12598/ based on the state updated by the bot?
03:43:27  <joyee>BTW the biggest flake on the CI at the moment is https://github.com/nodejs/node/issues/18190
03:48:42  <joyee>srl295: Most of the failures in https://ci.nodejs.org/job/node-test-pull-request/12598/ are either known flakes or infra issues, the only new one is https://ci.nodejs.org/job/node-test-commit-freebsd/14762/nodes=freebsd11-x64/console
03:55:49  <joyee>addaleax: I think the pattern of test-async-wrap-getasyncid is similar to test-async-wrap-uncaughtexception https://github.com/nodejs/node/issues/16210, both `beforeExit` being emitted twice
03:57:19  * apapirovskijoined
03:58:54  * apapirovskiquit (Remote host closed the connection)
04:00:12  * apapirovskijoined
04:06:03  <srl295>Thanks. Not intl related
04:09:14  * nodejs-ghjoined
04:09:14  * nodejs-ghpart
04:09:59  * nodejs-ghjoined
04:09:59  * nodejs-ghpart
04:10:24  * nodejs-ghjoined
04:10:24  * nodejs-ghpart
04:10:44  * nodejs-ghjoined
04:10:44  * nodejs-ghpart
04:10:44  <srl295>ok pushed, sorry for the spurious branch
04:11:36  * apapirovskiquit (Remote host closed the connection)
04:22:03  * mmarchiniquit (Quit: Connection closed for inactivity)
04:26:51  * apapirovskijoined
04:27:05  * apapirovskiquit (Client Quit)
04:42:54  <devsnek>TimothyGu someone here said that the whole "meta module" getters and setters and whatnot was rejected
04:43:11  <devsnek>a while ago while talking about my first pr with the all cjs modules get named exports
04:44:53  <devsnek>although that would be cool
04:51:38  * marthinaljoined
04:55:57  * marthinalquit (Ping timeout: 240 seconds)
05:23:42  * nodejs-ghjoined
05:23:42  * nodejs-ghpart
05:48:15  * marthinaljoined
05:59:00  * marthina_joined
06:00:01  * marthina_quit (Remote host closed the connection)
06:03:09  * marthina_joined
06:06:08  * stephenbelangerjoined
06:06:42  * marthina_quit (Remote host closed the connection)
06:08:01  * stephenbelangerquit (Client Quit)
06:08:17  * qardjoined
06:10:49  * lpinjoined
06:46:24  * marthina_joined
06:47:20  * qardquit (Quit: qard)
06:50:57  * marthina_quit (Ping timeout: 240 seconds)
06:53:29  * qardjoined
07:25:15  * marthina_joined
07:28:34  * marthina_quit (Remote host closed the connection)
07:37:03  * marthina_joined
07:38:11  * qardquit (Quit: qard)
07:39:18  * marthina_quit (Remote host closed the connection)
07:39:51  * marthina_joined
07:44:05  * marthina_quit (Ping timeout: 240 seconds)