00:03:21  * jaywonjoined
00:48:42  * jaywonquit (Remote host closed the connection)
00:49:15  * jaywonjoined
00:54:02  * jaywonquit (Ping timeout: 256 seconds)
01:02:30  * BridgeARquit (Ping timeout: 260 seconds)
01:29:55  * node-ghjoined
01:29:55  * node-ghpart
01:39:25  * node-ghjoined
01:39:25  * node-ghpart
02:37:10  * node-ghjoined
02:37:10  * node-ghpart
02:44:02  * maclover7_part
02:58:10  * node-ghjoined
02:58:10  * node-ghpart
03:02:51  * node-ghjoined
03:02:51  * node-ghpart
03:05:42  <maclover7>if anyone's around, would appreciate 👀 on https://github.com/nodejs/github-bot/pull/174 to get it out quick
03:06:00  <maclover7>github-bot currently crashes on any PRs opened in nodejs/node due to function name typo
03:08:46  <maclover7>... which is a bit less than ideal, one could say.
03:10:19  <Trott>I can give it a rubber-stamp LGTM but I don't know anything about the bot.
03:10:47  <Trott>Rubber stamped.
03:11:07  <maclover7>Trott: Thanks
03:11:37  <maclover7>The issue is that the function at https://github.com/maclover7/github-bot/blob/3b92ee1e1a1b24459eb32847e354e1adbf28dfd5/scripts/trigger-jenkins-build.js#L166 and https://github.com/maclover7/github-bot/blob/3b92ee1e1a1b24459eb32847e354e1adbf28dfd5/scripts/trigger-jenkins-build.js#L179 used to not match
03:11:50  <maclover7>Calling a func that didn't exist
03:31:23  * juggernaut451joined
03:32:21  * node-ghjoined
03:32:21  * node-ghpart
03:33:36  * node-ghjoined
03:33:36  * node-ghpart
03:34:07  * node-ghjoined
03:34:07  * node-ghpart
03:34:26  * node-ghjoined
03:34:26  * node-ghpart
03:35:23  * juggernaut451quit (Remote host closed the connection)
04:54:18  * jaywon_joined
04:58:44  * jaywon_quit (Ping timeout: 265 seconds)
05:14:51  * apapirovskijoined
05:34:37  * apapirov_joined
05:38:30  * apapirovskiquit (Ping timeout: 256 seconds)
05:52:45  * srl295quit (Quit: Connection closed for inactivity)
05:59:59  * apapirov_quit (Read error: Connection reset by peer)
06:00:36  * apapirovskijoined
06:12:43  * apapirovskiquit (Remote host closed the connection)
06:15:57  * apapirovskijoined
06:16:50  * apapirovskiquit (Remote host closed the connection)
06:24:16  * apapirovskijoined
06:27:51  * apapirovskiquit (Remote host closed the connection)
06:50:24  * jaywonjoined
06:54:21  * jaywonquit (Ping timeout: 240 seconds)
07:13:11  * apapirovskijoined
07:26:22  * apapirovskiquit (Quit: Leaving...)
08:12:18  * node-ghjoined
08:12:18  * node-ghpart
08:23:18  * seishunjoined
08:23:20  * BridgeARjoined
09:15:38  * jaywon_joined
09:19:54  * jaywon_quit (Ping timeout: 260 seconds)
09:26:01  * BridgeARquit (Ping timeout: 265 seconds)
09:57:03  * jaywonjoined
10:02:14  * jaywonquit (Ping timeout: 276 seconds)
10:25:08  * mylesborinsquit (Quit: farewell for now)
10:25:38  * mylesborinsjoined
11:33:40  * BridgeARjoined
12:43:08  * jaywonjoined
12:48:05  * jaywonquit (Ping timeout: 276 seconds)
12:49:35  * BridgeARquit (Ping timeout: 240 seconds)
14:20:49  * node-ghjoined
14:20:49  * node-ghpart
14:43:38  * node-ghjoined
14:43:38  * node-ghpart
14:44:38  * node-ghjoined
14:44:38  * node-ghpart
16:09:17  * BridgeARjoined
16:27:12  <lucalanziani>Looking at the nodejs/build repo, any particular reason to not have the '.yml' in the group_vars files in 'ansible/group_vars'?
16:32:07  <Trott>On test-rackspace-ubuntu1604-x64-2, there is `/home/iojs/build/workspace/node_modules` that contains `npm` source. That seems really wonky. I'm deleting it. Anyone know what happened or how it got there? (There's a failing test that expects `require('.')` or something to find nothing, but it finds that `node_modules` directory instead. There's also an empty `etc` subdirectory there too. It looks like maybe maclover7 was
16:32:07  <Trott>doing something because there's a `nodegyp-test-maclover7` created four minutes after the `node_modules` directory? No big whoop. Just letting you know what I'm doing.
16:33:56  <Trott>lucalanziani: AFAIK, the ansible stuff is largely the work of rvagg and maclover7 so maybe one of them can respond when they get online.
16:36:55  * node-ghjoined
16:37:00  * node-ghpart
16:46:30  * node-ghjoined
16:46:30  * node-ghpart
16:53:06  * BridgeARquit (Ping timeout: 265 seconds)
17:18:10  <maclover7>Trott: Yeah, I was trying to port the node-gyp test job over to pipelines and was having some issues. Feel free to remove if you haven't already
17:18:46  <maclover7>lucalanziani: Not completely sure I get your question, can you explain a little more?
17:19:09  <maclover7>If I think I understand it right, it's because `infra`, `release`, and `test` all have different requirements for their group variables
17:21:13  <lucalanziani>maclover7: I'm just asking why those files are not named "infra.yml" "release.yml" "test.yml"
17:21:41  * node-ghjoined
17:21:41  * node-ghpart
17:22:09  <lucalanziani>talking about the files here https://github.com/nodejs/build/tree/master/ansible/group_vars
17:22:22  <maclover7>lucalanziani: Ah ok, now I understand what you're asking
17:22:27  <maclover7>I think it's a legacy thing?
17:22:32  <maclover7>No reason why they shouldn't be, probably
17:22:43  <maclover7>(since they are YAML files, just without the extension)
17:23:16  <maclover7>That could make a nice first PR to the repo!
17:23:34  <lucalanziani>I was just going to propose that ;)
17:24:12  <lucalanziani>any preference/convention on branch names?
17:24:45  <maclover7>Not really
17:24:56  <maclover7>We try and advise people to keep branches on their personal forks, though
17:25:24  <lucalanziani>yeah just saw that in other PRs
17:26:34  * node-ghjoined
17:26:34  * node-ghpart
17:27:32  * node-ghjoined
17:27:32  * node-ghpart
17:27:37  * maclover7quit (Quit: Updating details, brb)
17:27:44  * maclover7joined
18:42:45  * jaywon_joined
19:19:04  * node-ghjoined
19:19:04  * node-ghpart
19:38:03  * juggernaut451joined
20:32:06  * jaywon_quit (Remote host closed the connection)
20:41:44  * juggernaut451quit (Remote host closed the connection)
20:44:55  * seishunquit (Ping timeout: 260 seconds)
20:45:20  * jaywon_joined
21:28:36  * jaywon___joined
21:31:27  * jaywon_quit (Ping timeout: 240 seconds)
22:45:41  * jaywon_joined
22:47:00  * jaywo____joined
22:49:19  * jaywon___quit (Ping timeout: 265 seconds)
22:50:31  * jaywon_quit (Ping timeout: 256 seconds)
23:36:55  * jaywo____quit (Remote host closed the connection)
23:38:50  * node-ghjoined
23:38:50  * node-ghpart