02:25:45  * node-ghjoined
02:25:45  * node-ghpart
02:27:22  <jbergstroem>..so that happened
02:43:18  <jbergstroem>mhdawson: sorry; i've been a poor host the last meeting or three. i'm happy to chat tomorrow but if its too short notice i'm available the coming two weeks as well (same time/place)
07:16:48  * node-ghjoined
07:16:48  * node-ghpart
09:29:09  * sgimenoquit (Quit: Leaving)
11:25:07  * mylesborinsquit (Quit: farewell for now)
11:25:38  * mylesborinsjoined
11:34:24  * not-an-aardvarkquit (Quit: Connection closed for inactivity)
13:32:13  * node-ghjoined
13:32:13  * node-ghpart
13:38:29  * lance|afkchanged nick to lanceball
14:25:54  * chorrelljoined
14:30:18  <mhdawson>I've available for a build meeting
14:30:41  <mhdawson>If you want I can set up the youtube/issue
14:30:56  <mhdawson>we can do it today or next week I think either works for me
14:49:00  <jbergstroem>lets see how many people we'll get. perhaps create the issue?
14:59:23  * targosquit (Quit: Leaving)
16:13:27  <mylesborins>o/
16:13:28  <mylesborins>https://github.com/nodejs/node/pull/11081
16:13:59  <mylesborins>no auto labelling happened
16:14:00  <mylesborins>is bot down?
18:02:17  <Trott>This seems Not Good on the Windows front: https://ci.nodejs.org/job/node-compile-windows/ (12 of the last 16 compilation jobs for Windows have faile.)
18:02:23  <Trott>joaocgreis jbergstroem ^^^
18:14:09  <joaocgreis>Trott: already known issue! I'm waiting for CI on this one to land: https://github.com/nodejs/node/pull/11085
18:14:38  * not-an-aardvarkjoined
18:14:53  <mhdawson>just creating issue now
18:15:34  <joaocgreis>actully, it's already green for some unixes, windows and linter, any objections to land it now?
18:16:42  * node-ghjoined
18:16:43  * node-ghpart
18:17:22  <Trott>joaocgreis: Surprised OS X et al. haven't started for it yet.
18:17:44  <Trott>joaocgreis: But I don't object to landing it as soon as you are comfortable with it (which sounds like you are).
18:17:54  <joaocgreis>Trott: theres a CITGM job running, it takes a lot of time
18:18:15  * node-ghjoined
18:18:16  * node-ghpart
18:20:50  <Trott>Ah!
18:20:55  * node-ghjoined
18:20:55  * node-ghpart
18:24:32  <Trott>Yeah, totally +1 to landing it now, joaocgreis.
18:48:52  * chorrellquit (Quit: Textual IRC Client: www.textualapp.com)
19:17:33  * node-ghjoined
19:17:33  * node-ghpart
19:23:53  * node-ghjoined
19:23:53  * node-ghpart
19:54:18  * node-ghjoined
19:54:18  * node-ghpart
20:03:57  * node-ghjoined
20:03:57  * node-ghpart
20:08:39  * node-ghjoined
20:08:39  * node-ghpart
20:10:54  * node-ghjoined
20:10:55  * node-ghpart
20:25:30  * node-ghjoined
20:25:30  * node-ghpart
20:38:59  * node-ghjoined
20:38:59  * node-ghpart
20:54:31  <mylesborins>jbergstroem weird failure for smartos
20:54:31  <mylesborins>ssh: Could not resolve hostname node-www: node name or service name not known
20:54:35  <mylesborins>https://ci-release.nodejs.org/job/iojs+release/1486/nodes=smartos15-release/console
20:54:39  <mylesborins>on both releases
20:54:53  <jbergstroem>yes, node is not quite ready
20:55:03  <mylesborins>good to promote release without it?
20:55:27  <jbergstroem>let me revert the config
20:56:35  <jbergstroem>actually
20:56:39  <jbergstroem>if you run it now, it should be running on smartos14 instead
20:57:02  <mylesborins>to confirm
20:57:04  <jbergstroem>(which is correct)
20:57:05  <mylesborins>I should rerun both builds?
20:57:34  <mylesborins>evanlucas ^^
20:57:36  <jbergstroem>newer releases should be run on smartos15, but 4.x, 6.x and 7.x (sans v8 55, right?) should be running on smartos14. finally, 0.x runs on smartos13.
20:59:41  <evanlucas>ok, so does that mean I need to rerun 7.5.0?
21:00:08  <mylesborins>ok so we need to rerun all build
21:00:15  <mylesborins>evanlucas I want to get out of office in next 2 hours
21:00:19  <mylesborins>mind if I sync up my builds first :P
21:00:28  <evanlucas>nope, have at it
21:00:43  <evanlucas>I'm at home so as long as I can do mine sometime today
21:01:00  <mylesborins>done
21:01:07  <mylesborins>I did not cancel your build as a heads up
21:54:55  <jbergstroem>i gotta head for a bit
21:54:58  <jbergstroem>hopefully it should just work
21:55:10  <jbergstroem>(with smartos14)
21:55:24  <jbergstroem>looks good: https://ci-release.nodejs.org/job/iojs+release/nodes=smartos14-release/
22:13:38  <mylesborins>jbergstroem can I get a new ssh key added for me?
22:13:48  <mylesborins>just realized I can't promote the build with ssh key on new box :S
22:17:32  * node-ghjoined
22:17:33  * node-ghpart
22:24:24  * not-an-aardvarkquit (Quit: Connection closed for inactivity)
22:29:06  <mylesborins>mhdawson rvagg are you able to add new key?
22:30:53  <rvagg>mylesborins: sure, I'll be back at the computer shortly. What do you need?
22:31:02  <mylesborins>I have a new ssh key on work machine
22:31:10  <mylesborins>need public key added to release machine so I can promote build
22:31:17  <mylesborins>thanks :D
22:32:00  <rvagg>Ok, no problem, want to drop it in here or tell me.where to find it?
22:46:09  * lanceballchanged nick to lance|afk
23:17:26  <mylesborins>rvagg any luck?
23:19:36  <rvagg>mylesborins: yeah, I'm at the computer now, what's your new key?
23:19:48  <mylesborins>sent via pm
23:19:51  <mylesborins>jsut now
23:20:39  <rvagg>mylesborins: 👍 should be good to go now
23:21:04  <mylesborins>thanks!
23:21:17  <mylesborins>woot! thanks working like a charm
23:21:32  <mylesborins>btw I'm almost done hacking core-get-reviewers to use the new reviewers api
23:21:37  <mylesborins>so we can stop using the browser plugin
23:21:52  <mylesborins>it will combine both comments and reviewers into a single list
23:35:13  <evanlucas>yay!
23:35:35  <evanlucas>maybe add a `--apply 2` flag to go ahead and apply the metadata to the previous two commits :p
23:39:22  * not-an-aardvarkjoined
23:41:12  <evanlucas>wow that raspbian build is taking a looooong time
23:55:32  <mylesborins>evanlucas https://github.com/MylesBorins/core-get-reviewers/commit/cce0d77887f4df82108d4fb887907d45fd6086c4
23:55:38  <mylesborins>SUPER rough
23:55:42  <mylesborins>but new reviewer api works
23:55:43  <mylesborins>with de duping
23:55:44  <mylesborins>brb
23:55:51  <mylesborins>
23:57:22  <evanlucas>lol
23:57:24  <evanlucas>noice
23:57:31  <evanlucas>that indent though :p