00:00:00  * ircretaryquit (Remote host closed the connection)
00:00:09  * ircretaryjoined
00:12:36  * AlexisMochaquit (Ping timeout: 276 seconds)
00:42:23  * qardquit (Quit: (ノಠ益ಠ)ノ彡┻━┻)
00:51:02  * dsantiagoquit (Quit: Computer has gone to sleep.)
00:58:56  * alexforsterquit
01:03:22  * kazuponjoined
01:07:02  * jgiquit (Quit: jgi)
01:10:46  * jgijoined
01:21:21  * kevinswiberquit (Ping timeout: 265 seconds)
01:24:23  * kevinswiberjoined
01:25:38  * piscisaureusquit (Ping timeout: 272 seconds)
01:29:09  * jgiquit (Quit: jgi)
01:43:30  * dsantiagojoined
01:44:44  * abraxas_joined
01:49:22  * program247365quit (Quit: Leaving.)
01:49:36  * abraxas_quit (Ping timeout: 252 seconds)
01:53:00  * kevinswiberquit (Read error: Connection reset by peer)
01:57:07  * kevinswiberjoined
02:03:09  * Ralithquit (Ping timeout: 245 seconds)
02:19:10  * kevinswiberquit (Read error: Connection reset by peer)
02:22:59  * kevinswiberjoined
02:24:41  * abraxas_joined
02:29:49  * Ralithjoined
02:35:38  * abraxas_quit (Remote host closed the connection)
02:40:37  * kevinswiberquit (Ping timeout: 265 seconds)
02:46:21  * kevinswiberjoined
02:53:08  * kazuponquit (Remote host closed the connection)
03:02:33  * Fishrock123quit (Remote host closed the connection)
03:02:48  * piscisaureusjoined
03:08:25  * piscisaureus_joined
03:10:19  * piscisaureusquit (Read error: Connection reset by peer)
03:10:40  * piscisaureusjoined
03:10:42  * kevinswiberquit (Ping timeout: 256 seconds)
03:14:46  * piscisaureus_quit (Ping timeout: 276 seconds)
03:22:45  * kevinswiberjoined
03:40:57  * kevinswiberquit (Ping timeout: 240 seconds)
03:44:51  * inolenquit (Ping timeout: 256 seconds)
03:46:20  * kevinswiberjoined
03:46:21  * rmgquit (Remote host closed the connection)
04:01:33  * pgicxplzsjoined
04:03:29  * kazuponjoined
04:04:00  * warehouse13quit (Ping timeout: 276 seconds)
04:14:50  * kevinswiberquit (Read error: Connection reset by peer)
04:21:28  * kevinswiberjoined
04:30:02  * inolenjoined
04:33:15  * Fishrock123joined
04:35:57  * Fishrock123quit (Read error: Connection reset by peer)
04:36:24  * Fishrock123joined
04:42:29  * Fishrock123quit (Quit: Leaving...)
04:45:25  * kevinswiberquit (Ping timeout: 255 seconds)
04:45:48  * kevinswiberjoined
04:52:08  * kevinswiberquit (Ping timeout: 256 seconds)
04:53:31  * kevinswiberjoined
04:59:07  * petka__quit (Quit: Connection closed for inactivity)
04:59:20  * piscisaureusquit (Quit: ~ Trillian Astra - www.trillian.im ~)
05:10:36  * kevinswiberquit (Read error: No route to host)
05:11:10  * kevinswiberjoined
05:20:14  * AlexisMochajoined
05:21:05  * kevinswiberquit (Ping timeout: 265 seconds)
05:22:34  * kevinswiberjoined
05:26:09  * seishunjoined
05:30:25  * inolenquit (Ping timeout: 255 seconds)
05:34:24  * kevinswiberquit (Read error: Connection reset by peer)
05:34:58  * kevinswiberjoined
05:43:59  * kevinswiberquit (Read error: Connection reset by peer)
05:44:42  * kevinswiberjoined
05:57:20  * kevinswiberquit (Ping timeout: 265 seconds)
05:58:21  * kevinswiberjoined
06:12:29  * kevinswiberquit (Read error: Connection reset by peer)
06:13:03  * kevinswiberjoined
06:27:25  * kevinswiberquit (Read error: Connection reset by peer)
06:28:37  * kevinswiberjoined
06:37:38  * inolenjoined
06:40:21  * kevinswiberquit (Ping timeout: 265 seconds)
06:40:54  * kevinswiberjoined
06:52:37  * kevinswiberquit (Ping timeout: 264 seconds)
06:53:20  * kevinswiberjoined
06:53:34  * seishunquit (Ping timeout: 252 seconds)
06:59:37  * kazuponquit (Remote host closed the connection)
07:04:07  * kevinswiberquit (Ping timeout: 264 seconds)
07:04:41  * kevinswiberjoined
07:08:31  * kazuponjoined
07:15:55  * kevinswi_joined
07:16:12  * kevinswiberquit (Read error: Connection reset by peer)
07:30:44  * LeftWingquit (Remote host closed the connection)
07:30:51  * LeftWingjoined
07:32:32  * kevinswi_quit (Read error: No route to host)
07:32:46  * kevinswiberjoined
07:34:46  * rendarjoined
07:49:28  * kevinswiberquit (Ping timeout: 265 seconds)
07:49:50  * kazuponquit (Read error: Connection reset by peer)
07:50:06  * kazuponjoined
07:51:15  * kevinswiberjoined
08:07:10  * kevinswiberquit (Ping timeout: 272 seconds)
08:08:26  * kevinswiberjoined
08:09:47  * mmaleckiquit (Quit: leaving)
08:09:58  * mmaleckijoined
08:14:15  * kevinswiberquit (Ping timeout: 252 seconds)
08:15:04  * kevinswiberjoined
08:20:28  * WalrusPonyquit (Read error: Connection reset by peer)
08:22:41  * WalrusPonyjoined
08:25:24  * kevinswiberquit (Read error: Connection reset by peer)
08:26:31  * kevinswiberjoined
08:28:08  * SergeiRNDjoined
08:35:23  * kevinswiberquit (Ping timeout: 265 seconds)
08:36:05  * kevinswiberjoined
08:45:36  * kevinswiberquit (Read error: Connection reset by peer)
08:47:05  * kevinswiberjoined
08:54:47  * kevinswiberquit (Ping timeout: 265 seconds)
08:54:52  * kazuponquit (Remote host closed the connection)
08:55:45  * kevinswiberjoined
09:12:16  * AlexisMochaquit (Ping timeout: 255 seconds)
09:15:10  * kazuponjoined
09:25:50  * kevinswiberquit (Ping timeout: 256 seconds)
09:27:24  * kevinswiberjoined
09:43:03  * kevinswiberquit (Ping timeout: 265 seconds)
09:43:38  * kevinswiberjoined
09:51:24  * kevinswiberquit (Read error: Connection reset by peer)
09:52:49  * kevinswiberjoined
10:10:28  * kevinswiberquit (Read error: Connection reset by peer)
10:11:12  * kevinswiberjoined
10:20:12  * kevinswiberquit (Ping timeout: 244 seconds)
10:21:03  * kevinswiberjoined
10:36:11  * kevinswiberquit (Read error: Connection reset by peer)
10:37:57  * kevinswiberjoined
10:38:57  * chris_99joined
10:50:27  * SergeiRNDquit (Quit: Leaving.)
10:52:13  * kevinswiberquit (Read error: Connection reset by peer)
10:54:08  * kevinswiberjoined
10:56:04  * kazuponquit (Remote host closed the connection)
10:58:38  * AlexisMochajoined
11:00:38  * kevinswiberquit (Read error: Connection reset by peer)
11:01:25  * kevinswiberjoined
11:09:32  * kazuponjoined
11:09:37  * kevinswiberquit (Read error: Connection reset by peer)
11:09:57  * kevinswiberjoined
11:17:57  * kevinswiberquit (Read error: Connection reset by peer)
11:19:35  * kevinswiberjoined
11:30:51  * kevinswiberquit (Read error: Connection reset by peer)
11:32:14  * kevinswiberjoined
11:34:38  * SergeiRNDjoined
11:39:54  * abraxas_joined
11:40:59  * kevinswiberquit (Ping timeout: 265 seconds)
11:41:58  * kevinswiberjoined
11:44:40  * abraxas_quit (Ping timeout: 256 seconds)
11:54:46  * kevinswiberquit (Ping timeout: 276 seconds)
11:55:09  * kevinswiberjoined
11:56:04  * kazuponquit (Remote host closed the connection)
11:56:31  * kazuponjoined
12:00:37  * kazuponquit (Ping timeout: 240 seconds)
12:02:40  * rmgjoined
12:07:27  * rmgquit (Ping timeout: 252 seconds)
12:09:43  * kevinswiberquit (Read error: Connection reset by peer)
12:11:31  * kevinswiberjoined
12:22:18  * program247365joined
12:32:06  * mmickojoined
12:32:47  <mmicko>hello all
12:33:05  <mmicko>I have implemented web server in C, based on libuv and http_parser
12:33:36  <mmicko>thing is I have added websocket support and, initial connection works fine, and uv_write on connect works as well
12:34:16  <mmicko>problem is that I need to send websocket ping from another thread (each 5 sec for example) and then uv_write always fail
12:34:55  <mmicko>what is proper way of doing it
12:35:40  <txdv>why from another thread?
12:36:00  <txdv>why not set up a timer in the same event loop
12:36:38  <mmicko>can try that as well
12:37:05  <mmicko>I am executing uv_run(uv_default_loop(), UV_RUN_NOWAIT); in my main loop
12:37:26  * kevinswiberquit (Read error: Connection reset by peer)
12:38:20  * kevinswiberjoined
12:39:30  <saghul>mmicko: that's not a good idea, since you'll always do a zero-timeout poll
12:39:49  <saghul>you cannot use uv_write from a thread other than the loop thread
12:39:58  <txdv>other solution is to uv_async every 5 seconds and on that even tdo the ping
12:41:50  <mmicko>sagul: aware of it, but let me explain situation
12:42:01  <mmicko>this is webserver I am planning using on MAME
12:42:28  <mmicko>we are using Mongoose right now, but that one is not free for commercial use and have it's limitations
12:42:39  <txdv>if you want to do it from another thread, do an uv_asyn on the thread you want the writes to happen
12:42:49  <txdv>then handle the pings in the callback fo that uv_async
12:43:11  <mmicko>also I am planning of using it for making communication between two instances of MAME (emulated computers) possible
12:47:35  <mmicko>https://github.com/mmicko/mame/blob/master/src/emu/webengine.c
12:48:05  <mmicko>calls that fail are in void web_engine::push_message (at very bottom) and void web_engine::websocket_keepalive()
12:49:12  <saghul>is that oush message called from a thread other than the loop thread?
12:49:28  <saghul>*push
12:50:02  <mmicko>no it is in same thread
12:50:27  <saghul>wait, are you reusing a single write request all the time?
12:50:32  <saghul>that's not going to fly
12:50:50  <mmicko>new to libuv, so best to ask :)
12:51:03  <saghul>sure!
12:51:26  <saghul>I'd say you use a timer to run the keepalive
12:51:43  <saghul>also, run the loop with UV_RUN_DEFAULT, and use a async handle to call uv_stop
12:51:53  <saghul>(this way you can stop the loop from another thread)
12:52:17  <mmicko>ok, thanks for tip, will experiment
12:52:23  <saghul>and every time you want to push data, use a new uv_write_t, you can free it in the write callback
12:52:51  <mmicko>I like whole idea of libuv project and think MAME can use it for all communication with outside world
12:53:17  <mmicko>since we emulate network adapters and serial ports, so need to expose those to be visible
12:53:26  <saghul>I see
12:53:42  <saghul>feeel free to ask queestions here or in the mailing list as you go along!
12:54:23  <mmicko>thanks, there will probably be some questions
12:55:36  * kevinswiberquit (Read error: Connection reset by peer)
12:55:40  * kevinswi_joined
13:10:35  * kevinswi_quit (Read error: Connection reset by peer)
13:12:21  * kevinswiberjoined
13:26:13  * kevinswiberquit (Ping timeout: 264 seconds)
13:27:45  * kevinswiberjoined
13:32:52  * AlexisMochaquit (Ping timeout: 252 seconds)
13:36:11  <txdv>why are you trying to put libuv into that arcade emulator mmicko ?
13:36:57  <mmicko>well since last release MAME is also including MESS project (that is for computer emulation)
13:37:28  <mmicko>and we have lot of computers that had only RS232 where you could connect terminal for example
13:37:45  <mmicko>and idea is that in one instance you emulate terminal and in other main machine
13:37:50  <mmicko>and connect it over TCP
13:38:10  <mmicko>by exposing rs232 ports on both
13:38:22  <mmicko>or connect using telnet or putty directly to them
13:38:32  <mmicko>so mostly for IPC
13:39:21  <mmicko>there is idea for exposing debugger data as well so we could move debugger as external application
13:42:18  * davijoined
13:45:12  * kevinswiberquit (Ping timeout: 265 seconds)
13:45:51  * kevinswiberjoined
13:57:37  * AlexisMochajoined
13:59:07  * kevinswiberquit (Ping timeout: 256 seconds)
13:59:40  * kevinswiberjoined
14:00:42  <mmicko>made separate server, created timer and send message each 2 sec
14:00:52  <mmicko>on uv_write I always still get UV__EFAULT (-4074)
14:01:12  <mmicko>this time used new uv_write_t
14:01:35  * sgimenojoined
14:07:26  * kevinswiberquit (Ping timeout: 265 seconds)
14:07:59  * kevinswiberjoined
14:15:00  * kevinswi_joined
14:15:00  * kevinswiberquit (Ping timeout: 276 seconds)
14:15:25  * alexforsterjoined
14:20:05  * kevinswi_quit (Read error: Connection reset by peer)
14:23:01  * kevinswiberjoined
14:29:40  * kevinswiberquit (Ping timeout: 265 seconds)
14:31:14  * kevinswiberjoined
14:37:30  * kevinswiberquit (Ping timeout: 256 seconds)
14:43:40  * kevinswiberjoined
14:45:55  <txdv>Oo
14:47:44  * AlexisMochaquit (Ping timeout: 245 seconds)
14:48:38  <saghul>mmicko: the memory in the buffer must be valid until the write callback is called
14:48:54  <saghul>mmicko: "EFAULT buf is outside your accessible address space."
14:48:57  <mmicko>yeah, just see that best is to do something like :
14:49:09  <mmicko>size_t len = strlen(msg.c_str());
14:49:09  <mmicko> uv_write_t *req = (uv_write_t*)malloc(sizeof(*req) + len +2);
14:49:09  <mmicko> char *addr = (char*)req + 1;
14:49:09  <mmicko> addr[0] = 0x81;
14:49:09  <mmicko> addr[1] = len & 0xff;
14:49:10  <mmicko> memcpy(addr+2, msg.c_str(), len);
14:49:12  <mmicko> uv_buf_t buf = uv_buf_init((char*)addr, len+2);
14:50:04  * kazuponjoined
14:50:09  <txdv>got rythm
14:52:24  * rmgjoined
14:56:58  * rmgquit (Ping timeout: 255 seconds)
14:57:29  * SergeiRNDquit (Quit: Leaving.)
15:06:54  * kevinswiberquit (Ping timeout: 245 seconds)
15:07:18  * kevinswiberjoined
15:07:46  * jgijoined
15:12:23  * seishunjoined
15:18:01  * abraxas_joined
15:21:21  * jgiquit (Quit: jgi)
15:22:14  * abraxas_quit (Ping timeout: 246 seconds)
15:24:50  * kevinswiberquit (Ping timeout: 265 seconds)
15:28:23  * kevinswiberjoined
15:29:36  * kevinswiberquit (Remote host closed the connection)
15:31:37  * mmickoquit (Ping timeout: 255 seconds)
15:35:32  * program247365quit (Ping timeout: 246 seconds)
15:36:39  * lanceballchanged nick to lance|afk
15:38:08  * program247365joined
15:41:37  * kevinswiberjoined
15:54:27  * dawsonmquit (Read error: Connection reset by peer)
15:55:08  * kevinswiberquit (Ping timeout: 256 seconds)
15:55:48  * kevinswiberjoined
15:56:13  * rmgjoined
15:59:40  * Fishrock123joined
15:59:52  * kevinswiberquit (Read error: Connection reset by peer)
16:00:13  * kevinswiberjoined
16:14:34  * kevinswiberquit (Ping timeout: 252 seconds)
16:15:47  * kevinswiberjoined
16:16:02  * j0hnsm1thjoined
16:21:34  * jgijoined
16:22:55  * kevinswiberquit (Read error: Connection reset by peer)
16:26:32  * kevinswiberjoined
16:35:24  * Ralithquit (Ping timeout: 265 seconds)
16:39:28  * kevinswiberquit (Ping timeout: 276 seconds)
16:39:38  * lance|afkchanged nick to lanceball
16:43:26  * pquernaquit (Disconnected by services)
16:43:26  * sgimeno_joined
16:43:29  * pquerna_joined
16:43:31  * rphillip-joined
16:43:34  * kazupon_joined
16:45:09  * kazuponquit (*.net *.split)
16:45:09  * sgimenoquit (*.net *.split)
16:45:10  * rphillipsquit (*.net *.split)
16:45:21  * sgimeno_changed nick to sgimeno
16:46:40  * kevinswiberjoined
16:55:50  * kazupon_quit (Remote host closed the connection)
17:07:21  * program2473651joined
17:10:02  * program247365quit (Ping timeout: 246 seconds)
17:10:32  * kevinswiberquit (Read error: Connection reset by peer)
17:10:41  * Ralithjoined
17:16:04  * kevinswiberjoined
17:20:15  * brrtjoined
17:20:19  * piscisaureusjoined
17:21:22  * brrtquit (Client Quit)
17:30:00  * kevinswiberquit (Ping timeout: 276 seconds)
17:31:44  * kevinswiberjoined
17:35:08  * rphillip-changed nick to rphillips
17:41:42  * kevinswiberquit (Ping timeout: 276 seconds)
17:43:34  * kevinswiberjoined
17:48:18  * AlexisMochajoined
17:54:39  * kevinswiberquit (Read error: Connection reset by peer)
17:55:38  * kevinswiberjoined
17:58:43  * kevinswiberquit (Read error: Connection reset by peer)
18:03:18  * kevinswiberjoined
18:03:35  * dawsonmjoined
18:03:56  <dawsonm>misterjules
18:04:51  <dawsonm>@misterjules you on ?
18:15:31  * kevinswiberquit (Read error: Connection reset by peer)
18:16:55  * kevinswiberjoined
18:29:03  * kevinswi_joined
18:29:19  * kevinswiberquit (Read error: Connection reset by peer)
18:31:39  * roxlujoined
18:37:37  * daviquit (Ping timeout: 265 seconds)
18:37:46  <MI6>joyent/node: Julien Gilli v0.10 * d38e865 : timers: fix timeout when added in timer's callback - http://git.io/vL855
18:38:01  <jgi>dawsonm: yep
18:38:20  <jgi>dawsonm: please use “jgi” so that I get notified when you’re looking for me :)
18:38:58  * kevinswi_quit (Read error: Connection reset by peer)
18:39:36  * kevinswiberjoined
18:42:07  * program247365joined
18:43:58  * program2473651quit (Ping timeout: 265 seconds)
18:55:40  * abraxas_joined
18:57:01  <dawsonm>just wondering if you were going to pull in https://github.com/joyent/node/pull/25533 as part of porting the openssl upgrade
18:57:10  <dawsonm>or if it would make sense for me to land in advance
18:57:22  * kevinswiberquit (Read error: Connection reset by peer)
18:58:06  <dawsonm>jgi:
18:58:52  * kevinswiberjoined
19:00:14  * abraxas_quit (Ping timeout: 245 seconds)
19:01:23  * SergeiRNDjoined
19:07:06  * jgiquit (Quit: jgi)
19:21:04  * kevinswiberquit (Ping timeout: 245 seconds)
19:23:43  * kevinswiberjoined
19:33:01  * program2473651joined
19:33:44  * program2473651quit (Client Quit)
19:34:41  * SergeiRNDquit (Quit: Leaving.)
19:35:26  * jgijoined
19:36:11  * program2473651joined
19:37:04  * program247365quit (Ping timeout: 265 seconds)
19:43:19  <jgi>dawsonm: my idea so far was to land the OpenSSL upgrade in v0.10, land the rest that needs to land in v0.10, do a v0.10.39 release, then merge v0.10 in v0.12, and land the change in https://github.com/joyent/node/pull/25533 as part of that merge (because the merge will have upgraded openssl in v0.12)
19:47:28  * kevinswiberquit (Ping timeout: 256 seconds)
19:53:23  * kevinswiberjoined
19:55:29  <jgi>dawsonm: does https://github.com/joyent/node/pull/25523 look good to you?
19:55:38  <jgi>dawsonm: I’m thinking about landing it asap
20:02:45  * inolenquit (Ping timeout: 265 seconds)
20:02:53  * inolenjoined
20:03:54  * kevinswiberquit (Ping timeout: 256 seconds)
20:05:38  * inolen1joined
20:07:31  * inolenquit (Ping timeout: 265 seconds)
20:07:53  * kevinswiberjoined
20:08:48  * program2473651quit (Quit: Leaving.)
20:10:37  * inolen1quit (Ping timeout: 264 seconds)
20:11:00  * program247365joined
20:13:53  * program247365part
20:14:04  * kevinswiberquit (Read error: Connection reset by peer)
20:15:02  * kevinswiberjoined
20:19:48  * importantshockjoined
20:20:20  * kevinswiberquit (Ping timeout: 256 seconds)
20:21:56  <dawsonm>jgi: what kind of validation have you done in the past for this kind of PR
20:22:06  <dawsonm>I've not looked closelyl at it yet
20:22:15  <dawsonm>but can if that makes sense
20:22:50  <jgi>dawsonm: let’s catch up about that after the node.js tsc meeting
20:22:56  <dawsonm>sure
20:24:34  * kevinswiberjoined
20:34:49  * kevinswiberquit (Ping timeout: 245 seconds)
20:35:37  * kevinswiberjoined
20:40:55  * SergeiRNDjoined
20:44:39  * abraxas_joined
20:48:21  * SergeiRNDquit (Quit: Leaving.)
20:49:09  * abraxas_quit (Ping timeout: 265 seconds)
20:49:14  * roxluquit (Quit: My Mac has gone to sleep. ZZZzzz…)
20:49:24  * inolenjoined
20:56:13  * kevinswiberquit (Ping timeout: 276 seconds)
21:01:57  * kevinswiberjoined
21:05:53  * kevinswiberquit (Read error: Connection reset by peer)
21:09:20  * dawsonmquit (Remote host closed the connection)
21:11:48  * kevinswiberjoined
21:15:05  * bradleymeckjoined
21:15:41  <bradleymeck>is there a reason uv_spawn_options_t does not have an init method? seems like stdio_count could get a bit odd if not zeroed etc.
21:16:06  * kevinswiberquit (Remote host closed the connection)
21:16:39  * kevinswiberjoined
21:17:30  <bradleymeck>related to me looking at https://github.com/joyent/node/issues/8704
21:21:30  * kazuponjoined
21:24:35  * kazuponquit (Remote host closed the connection)
21:25:48  * lanceballchanged nick to lance|afk
21:32:20  <saghul>bradleymeck: only handles have init methods
21:32:35  <bradleymeck>mmm ok
21:32:46  <saghul>uv_spawn is the odd one, since it creates a uv_process_t with an implicit init
21:33:13  <saghul>zeroing options out is part of the user's job in this case
21:33:33  <bradleymeck>yea, wanted to add rlimit stuff to it, but existing code that does not do this would not break
21:33:54  <bradleymeck>so the manual zeroing would not occur for old code /sigh
21:34:55  <saghul>you'll be breaking the ABI, so don't worry too much about that ;-)
21:43:30  * user1_joined
21:43:55  <user1_>jgi: sorry I was offline if you want to continue our conversation, back now
21:44:10  <jgi>user1_: ok cool :)
21:44:27  <jgi>user1_: so the validation I do for this type of PR is:
21:45:06  <jgi>1) Check here: https://github.com/joyent/node/wiki/OpenSSL-upgrade-process#floating-patches that all floating patches are still included in the code base if the PR was landed
21:45:36  <jgi>2) Run the node-review Jenkins jobs or the node-accept-pull-request Jenkins job (with the “apply-changes” checkbox unchecked) and make sure there’s no regression
21:46:00  <jgi>3) Look at the diff and make sure nothing seems to be obviously missing
21:46:17  <jgi>for 3), depending on the size of the diff, I don’t necessarily do a review as thorough as usual
21:46:32  <jgi>but if we upgrade OpenSSL for a security issue, I just make sure that the fixes are included
21:46:41  <jgi>and that’s it
21:47:21  <jgi>user1_: given that shigeki submitted the PR, and that I trust him a lot, that adds some weight to the PR too
21:47:27  <user1_>agreed
21:47:58  <user1_>so its pretty much the end of my day here, but I would be able to start ticking those off tomorrow morning
21:48:43  <user1_>My main machine is out of commission until Friday so if you have the main link to the CI that would be helpful as I don't have my usual shortcuts
21:50:29  <jgi>user1_: sure, I already did all these steps, but if you want to go through them yourself too I’m fine with it
21:50:38  <user1_>well if you already did them
21:50:48  <jgi>user1_: did you see https://github.com/joyent/node/pull/25523?
21:51:24  <user1_>I think its fine
21:51:32  <user1_>just wanted to help if needed
21:51:37  <jgi>user1_: ah ok, thank you!
21:51:45  <jgi>user1_: so OK for me to land the changes?
21:51:47  <user1_>I'd not see the final comment
21:51:51  <user1_>yes
21:51:56  <jgi>user1_: great
21:52:04  <user1_>For 0.12.X we need to pull in the test change as well
21:52:09  <jgi>user1_: yes
21:52:44  * AlexisMochaquit (Ping timeout: 264 seconds)
21:52:45  <jgi>user1_: I would suggest doing that after the merge of v0.10 into v0.12 is done
21:53:00  <jgi>user1_: so that we can test that the change actually fixes the regression resulting from the merge
21:53:17  <user1_>ok, so merge, see the test fail and then include ?
21:53:20  <jgi>user1_: but if you have a suggestion to do that in a better way, I’m open :)
21:53:30  <jgi>user1_: yes, that’s what I was thinking
21:53:48  <user1_>we could just pull it in, in advance
21:54:00  <jgi>user1_: that means relasing v0.10.39 first, then possibly a day later releasing v0.12.5
21:54:01  <user1_>as I was thinking the job only pulls in one PR at at time
21:54:24  <user1_>and needs the tests to pass in order to accept the PR
21:54:44  * bradleymeckquit (Quit: bradleymeck)
21:54:58  <user1_>so unless they are done together or the test PR first, won't there be an issue
21:55:01  <jgi>user1_: so when we merge v0.10 into v0.12, we don’t submit a PR
21:55:06  <user1_>ah ok
21:55:13  <user1_>that makes sense them
21:55:18  * seishunquit (Remote host closed the connection)
21:55:31  * kevinswiberquit (Read error: Connection reset by peer)
21:55:31  <jgi>user1_: but still, it might be better to not wait and land the test first, I just want to make sure we know that we’re fixing the right thing :)
21:55:51  <jgi>user1_: and honestly I haven’t looked too much into that PR (the one that changes the size of keys in the test)
21:55:54  * kevinswiberjoined
21:56:19  <user1_>The test goes through a sequence starting with smaller keys
21:56:34  <user1_>the change simply starts at a larger key size and removes the tests for the smaller one
21:56:55  <jgi>user1_: ok, then I would be fine landing it before the merge
21:57:03  <jgi>user1_: that could buy us some time
21:57:14  <user1_>I can do ahead and do that in parallel if you want
21:57:28  <MI6>joyent/node: Shigeki Ohtsu v0.10 * 9463cfa : openssl: fix keypress requirement in apps on win32 (+4 more commits) - http://git.io/vLBUn
21:57:47  <jgi>user1_: yep, sounds good if someone has LGTM the PR (I haven’t)
21:57:53  <user1_>I have
21:58:18  <user1_>do you have the CI link handy ?
21:58:39  <user1_>The other thing I might have to do is modify the jenkins job to accept my email. Last time I pulled in a PR
21:59:09  <user1_>it did not seem to like my email so I added a new github one, but I had to revert that because it messed up my ability to work in the V8 repos
21:59:41  <jgi>user1_: the CI link to land PRs in v0.12?
21:59:54  <user1_>yes the main jenkins link
22:00:13  <jgi>user1_: https://nodejs.org/contribute/code_contributions/workflow.html#workflow_md_using_jenkins_to_build_test_and_merge_every_pr
22:00:19  * kevinswiberquit (Read error: Connection reset by peer)
22:00:49  <user1_>thanks
22:00:49  <jgi>user1_: let me check at the regexp that checks emails for this job
22:00:50  * warehouse13joined
22:00:54  * kevinswiberjoined
22:01:08  * seishunjoined
22:01:11  <jgi>user1_: I gave you the link to the documentation so that you tell me if the documentation is not clear enough ;-)
22:02:15  <user1_>Its clear to me :)
22:03:07  * pgicxplzsquit (Ping timeout: 255 seconds)
22:06:00  <jgi>user1_: ok good :)
22:06:30  <jgi>user1_: it looks like I broke the email regexp, trying to fix it
22:06:48  <user1_>k
22:07:22  <jgi>user1_: fixed
22:12:52  <jgi>user1_: let me know if you have any problem kicking off the job
22:13:07  <user1_>ok trying now
22:13:41  <jgi>user1_: just ignore the email warning if you know that your email is correct
22:13:57  * rendarquit (Quit: Leaving)
22:15:54  <user1_>still seems to fail unless I did something wrong
22:15:56  <user1_>http://jenkins.nodejs.org/job/node-accept-pull-request/131/console
22:16:05  * kevinswiberquit (Ping timeout: 265 seconds)
22:16:50  <user1_>jgi:
22:16:59  <jgi>user1_: ok, can you use an other email in the meantime? I’m trying to determine what the regexp engine of jenkins is
22:20:08  <MI6>joyent/node: Shigeki Ohtsu refs/tags/jenkins-accept-pull-request-temp * f7783da : test: remove 512 bits test in test-tls-dhe.js - http://git.io/vLBmK
22:21:12  <MI6>joyent/node: Shigeki Ohtsu refs/tags/jenkins-accept-commit-temp * 139dbe8 : test: remove 512 bits test in test-tls-dhe.js - http://git.io/vLBmA
22:22:04  * alexforsterquit
22:25:25  * bradleymeckjoined
22:32:01  * chris_99quit (Quit: Ex-Chat)
22:36:14  * jgiquit (Quit: jgi)
22:37:03  * bradleymeckquit (Quit: bradleymeck)
22:47:34  * jgijoined
22:55:56  * importantshockquit (Remote host closed the connection)
22:56:20  * bradleymeckjoined
22:56:30  * importantshockjoined
22:56:54  * Fishrock123quit (Remote host closed the connection)
22:57:26  * bradleymeckquit (Client Quit)
23:00:50  * importantshockquit (Ping timeout: 252 seconds)
23:06:14  * dsantiagoquit (Quit: Computer has gone to sleep.)
23:06:54  * user1_quit (Ping timeout: 265 seconds)
23:07:52  * user1_joined
23:09:44  * pquerna_changed nick to pquerna
23:11:10  <MI6>joyent/node: Shigeki Ohtsu v0.12 * 139dbe8 : test: remove 512 bits test in test-tls-dhe.js - http://git.io/vLBmA
23:20:21  * user1_quit (Remote host closed the connection)
23:34:07  * j0hnsm1thquit (Quit: shutdown -h now)
23:44:40  * Fishrock123joined
23:57:38  * dsantiagojoined