00:00:01  * ircretaryquit (Remote host closed the connection)
00:00:09  * ircretaryjoined
00:00:23  <jgi>trevnorris: I started to do that, but ended up solving the same conflicts as you had probably already solved originally. I figured I wouldn’t have the time to finish it before I would come back from my vacation. I can start to do it again, but it’s going to take me a significant amount of time, probably around one or 2 days.
00:00:40  <jgi>cjihrig: I just created https://github.com/joyent/node/issues/8986, do you have some time to take a look at it?
00:02:08  <cjihrig>jgi: been looking at it today. removing this is the problem https://github.com/joyent/node/blob/8cfbeed27ab98dffff68c13188d4f3dc1a506c3c/lib/net.js#L901-L904
00:02:36  <cjihrig>jgi: not entirely sure why it only seems to be on windows though
00:03:07  <cjihrig>probably some other underlying problem
00:05:23  * iarnajoined
00:05:27  <jgi>cjihrig: do you have a windows rig to investigate?
00:05:47  <cjihrig>jgi: a vm, yes
00:05:54  <jgi>cjihrig: alright great
00:06:45  <cjihrig>the simple fix is to add that block back with a range check on the port
00:07:40  * austojoined
00:08:06  * austoquit (Read error: Connection reset by peer)
00:08:26  * austojoined
00:23:05  * austoquit (Remote host closed the connection)
00:24:42  * octetcloudjoined
00:51:12  * iarnaquit (Remote host closed the connection)
00:52:08  * iarnajoined
00:55:39  * TetrisMcKennaquit (Ping timeout: 256 seconds)
01:04:23  <jgi>cjihrig: if you could add some comments with the results of your investigation in the GH issue that would be great!
01:05:24  <jgi>trevnorris: regarding the merge, if you don’t have any bandwidth to do it in the next couple days , I’ll see if I can start it tomorrow morning and I’ll let you know
01:06:01  <cjihrig>jgi: will do
01:06:20  <jgi>cjihrig: thanks!
01:26:27  * AvianFlujoined
01:29:11  * AvianFluquit (Remote host closed the connection)
01:41:35  * dshaw_quit (Quit: Leaving.)
01:41:48  * reqsharkjoined
01:48:53  * jgiquit (Quit: jgi)
02:04:21  * stagasquit (Ping timeout: 265 seconds)
02:24:15  * dap_1quit (Quit: Leaving.)
02:41:36  * zju4joined
02:42:33  * zjuquit (Ping timeout: 244 seconds)
02:47:37  * a3fjoined
03:06:34  * iarnaquit (Remote host closed the connection)
03:20:19  * brsonquit (Quit: leaving)
03:24:03  * austojoined
03:24:33  * rmgquit (Remote host closed the connection)
03:24:40  * austoquit (Read error: Connection reset by peer)
03:46:13  * dshaw_joined
03:48:20  * iarnajoined
03:53:51  * inolenquit (Ping timeout: 244 seconds)
04:04:43  * dshaw_1joined
04:07:36  * dshaw_quit (Ping timeout: 265 seconds)
04:14:03  * Left_Turnquit (Remote host closed the connection)
04:14:30  * iarnaquit (Remote host closed the connection)
04:23:34  * dshaw_1quit (Quit: Leaving.)
04:30:22  * qardquit (Quit: leaving)
04:55:46  * Orbordequit (Quit: WeeChat 0.4.2)
05:00:24  * jgijoined
05:06:25  * rmgjoined
05:11:53  * rmgquit (Ping timeout: 265 seconds)
05:31:30  * brsonjoined
05:32:57  * jgiquit (Quit: jgi)
05:48:37  * dshaw_joined
05:52:53  * jgijoined
06:15:01  * LeftWingquit (Remote host closed the connection)
06:15:04  * LeftWing__joined
06:17:49  * seishunjoined
06:20:25  * seishunquit (Read error: Connection reset by peer)
06:21:16  * seishunjoined
06:24:43  * octetcloudquit (Ping timeout: 244 seconds)
06:27:55  * thlorenzjoined
06:28:32  * seishunquit (Read error: Connection reset by peer)
06:29:01  * seishunjoined
06:31:11  * bajtosjoined
06:31:14  * zju4quit (Ping timeout: 244 seconds)
06:35:08  * jgiquit (Quit: jgi)
06:36:41  * jgijoined
06:54:42  * jgiquit (Quit: jgi)
07:15:01  * iarnajoined
07:19:29  * iarnaquit (Ping timeout: 265 seconds)
07:22:04  * seishunquit (Ping timeout: 244 seconds)
07:26:10  * thlorenzquit (Remote host closed the connection)
07:29:33  * [spoiler]joined
07:48:51  * thlorenzjoined
07:52:43  * brsonquit (Ping timeout: 256 seconds)
08:03:08  * LeftWing__changed nick to LeftWing
08:06:31  * saghuljoined
08:09:12  * dshaw_quit (Quit: Leaving.)
08:11:25  * thlorenz_joined
08:13:52  * thlorenzquit (Ping timeout: 240 seconds)
08:32:15  * thlorenzjoined
08:32:39  * a3fquit (Ping timeout: 244 seconds)
08:34:49  * thlorenz_quit (Ping timeout: 245 seconds)
08:38:32  * reqsharkquit (Quit: Be back later ...)
08:38:53  * thlorenz_joined
08:39:04  * reqsharkjoined
08:39:30  * bradleymeckquit (Quit: bradleymeck)
08:41:38  * thlorenzquit (Ping timeout: 244 seconds)
08:43:35  * reqsharkquit (Ping timeout: 265 seconds)
08:45:44  * jan____quit (Changing host)
08:45:44  * jan____joined
08:48:33  * thlorenzjoined
08:50:52  * thlorenz_quit (Ping timeout: 240 seconds)
08:55:15  * SplinterOfChaosquit (Ping timeout: 264 seconds)
09:01:16  * thlorenz_joined
09:04:26  * thlorenzquit (Ping timeout: 264 seconds)
09:04:58  * saghulquit (Read error: No route to host)
09:05:04  * saghul_joined
09:28:05  * thlorenz_quit (Remote host closed the connection)
09:32:11  * thlorenzjoined
10:12:35  * thlorenzquit (Remote host closed the connection)
10:20:24  * bajtosquit (Quit: bajtos)
10:22:27  * thlorenzjoined
10:30:11  * thlorenzquit (Remote host closed the connection)
10:39:38  * davijoined
10:40:25  * rendarjoined
10:46:30  * bajtosjoined
11:04:34  * Left_Turnjoined
11:07:09  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
11:07:34  * saghuljoined
11:16:11  * a3fjoined
11:22:43  * chris_99joined
11:25:18  * thlorenzjoined
11:29:34  * jas-quit (Remote host closed the connection)
11:31:04  * bajtosquit (Quit: bajtos)
11:34:06  * rmgjoined
11:38:52  * rmgquit (Ping timeout: 240 seconds)
11:48:27  * Left_Turnquit (Ping timeout: 256 seconds)
11:58:00  * FROGGS[mobile]joined
11:59:55  * stagasjoined
12:04:40  * tarrudajoined
12:06:50  * thlorenz_joined
12:09:20  * tarrudaquit (Ping timeout: 244 seconds)
12:09:20  * thlorenzquit (Ping timeout: 244 seconds)
12:30:13  * Left_Turnjoined
12:36:47  * thlorenz_quit
12:44:59  * bajtosjoined
12:51:43  * zjujoined
13:01:40  * bajtosquit (Quit: bajtos)
13:52:29  * reqsharkjoined
14:07:59  * bajtosjoined
14:13:50  * tarrudajoined
14:27:35  * [spoiler]quit (Quit: Leaving)
14:31:32  * austojoined
14:31:51  * austoquit (Remote host closed the connection)
14:32:27  * austojoined
14:39:19  * a3fquit (Ping timeout: 265 seconds)
14:40:17  * iarnajoined
14:57:26  * reqsharkquit (Quit: Be back later ...)
15:00:22  * AvianFlujoined
15:17:31  * Fishrock123joined
15:25:25  * TetrisMcKennajoined
15:34:25  * tarrudaquit (Ping timeout: 252 seconds)
15:47:59  * reqsharkjoined
15:49:25  * bajtosquit (Quit: bajtos)
15:54:43  * rmgjoined
15:59:31  * rmgquit (Ping timeout: 255 seconds)
16:04:02  * saghulquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
16:08:20  * seishunjoined
16:25:07  * saghuljoined
16:30:00  * saghulquit (Ping timeout: 265 seconds)
16:39:07  * dshaw_joined
16:40:28  * bradleymeckjoined
16:53:17  * jgijoined
16:54:07  * octetcloudjoined
16:54:59  * dshaw_quit (Quit: Leaving.)
16:55:56  * saghuljoined
16:57:41  * saghulquit (Read error: Connection reset by peer)
16:57:47  * saghul_joined
16:58:00  * rmgjoined
17:02:23  * saghul_quit (Ping timeout: 256 seconds)
17:08:48  * saghuljoined
17:09:12  * jgiquit (Quit: jgi)
17:12:29  * lanceballchanged nick to lance|afk
17:13:25  * saghulquit (Ping timeout: 252 seconds)
17:21:19  * piscisaureusjoined
17:21:27  * dap_joined
17:22:16  * bajtosjoined
17:25:21  * daviquit (Quit: Leaving)
17:39:13  * jgijoined
17:41:14  * AlexisMochajoined
17:49:37  * lance|afkchanged nick to lanceball
17:49:41  * lanceballchanged nick to lancbeall
17:49:42  * lancbeallchanged nick to lanceball
18:01:01  * Ralithquit (Ping timeout: 255 seconds)
18:06:45  * zju1joined
18:08:49  * saghuljoined
18:13:33  * saghulquit (Ping timeout: 252 seconds)
18:20:48  * qardjoined
18:25:38  * Ralithjoined
18:31:32  * tarrudajoined
18:38:22  * austoquit (Ping timeout: 240 seconds)
18:45:54  * AlexisMocha_joined
18:47:17  * AlexisMochaquit (Ping timeout: 252 seconds)
18:56:15  * AlexisMochajoined
18:58:15  * AlexisMocha_quit (Ping timeout: 264 seconds)
18:58:52  * AlexisMocha_joined
19:00:29  * AlexisMochaquit (Ping timeout: 252 seconds)
19:03:25  * tarrudaquit (Ping timeout: 252 seconds)
19:04:54  <srl295>jgi: sorry, behind the curve here. need to finish wiki work and respond to your other comments
19:04:58  <srl295>jgi: oh and ping
19:05:18  <jgi>srl295: no worries, I’m also quite busy :)
19:05:34  <jgi>srl295: I’m currently testing the binary packages with small ICU built-in
19:05:51  <srl295>great!
19:05:58  <jgi>srl295: so that we can close #7676 and move forward with the rest in more granular steps
19:06:30  <jgi>srl295: it’s working well so far, the only issues really are with the build platform itself (builds getting stuck, etc.)
19:06:42  <srl295>jgi: re 7676 - it really is one item - "ship with Intl on" but subitems came, and went, through discussion w/ others. That discussion is why i'm more reluctant to just open and close tickets based on each suggestions
19:07:48  <srl295>jgi: I would open actual PRs for specific implementation changes such as 8719 and 7719 . The comments were mostly so I could keep track of things, sorry if those caused confusion.
19:08:38  * saghuljoined
19:10:13  <jgi>srl295: yes, I understand why we ended up having these subitems. My concern is more that it makes things difficult to track (for instance, what do add to which milestone, or what to mention in commit log messages). Ideally we would have freeform discussions outside of GitHub, and use granular GH issues to track individual items.
19:11:39  * AvianFluquit (Quit: Leaving)
19:11:43  <srl295>jgi: the other thing I'm not sure about how to do in Github is how to manage multiple related PRs - if there are a bunch of changes to 'configure' for example, I could propse them as unrelated PRs that would have merge conflicts that would have to be done anyways, or I could have fewer PRs and manage proposals in my repo ( so that I am proposing to node a coherent patch)
19:11:56  <srl295>jgi: that makes sense, (outside of GH), wil do that moving forward as we discussed
19:13:22  * saghulquit (Ping timeout: 265 seconds)
19:14:33  * TetrisMcKennaquit (Remote host closed the connection)
19:16:32  * inolenjoined
19:17:23  <jgi>srl295: We could group PRs on GitHub with milestones or tags.
19:17:30  <jgi>srl295: However. I would rather have smaller PRs with potential conflicts than one big PR. It’s generally difficult to review bigger PRs in a timely manner, and that means that in the meantime, things will change and work will need to be redone, going through the whole (long) cycle again. If we communicate better on our goals and intentions, I think we could manage to have a better idea of how to split up features in smaller chunks.
19:19:02  <srl295>jgi: sure, and using the i18n tag works, thanks for doing that .That'll be my spot to check.
19:20:14  <srl295>jgi: I guess, I could just submit multiple PRs that are related, and just say - "#XXXX has to go in before #YYYY" right? that could work
19:26:48  <jgi>srl295: yes, although my feeling is that we shouldn’t have these types of dependencies very often if we communicate well. I think ideally we would have more orthogonal tasks being worked on at any given time. The problem with having tasks such as #YYYY depending in #XXXX is that if #XXXX needs to be redone completely, then #YYYY will have to be redone too.
19:27:17  <jgi>srl295: but I understand this is a bit unrealistic, we will have non-orthogonal PRs/issues coming up.
19:27:39  <jgi>srl295: it’s just that I think we should do our best to avoid them as much as possible.
19:27:56  <srl295>jgi: hopefully it will be rare
19:35:39  <jgi>srl295: If we use https://github.com/joyent/node/issues/7676 as a example, Ideally we would discuss what needs to be done to de-risk the feature, or come up with an initial good-enough implementation. We would try to come up with a granularity that allows up to implement the feature in question, but nothing more, nothing less. We would describe that in the issue, and implement just that in a single PR. Any discussion related to the implementa
19:35:40  <jgi>of this feature would go in the PR’s comments, and any change needed to make the implementation conform to the specification in the issue would be done in the PR itself.
19:36:29  <jgi>srl295: anything that would be outside of the scope of the “core” of the feature (like documentation in the wiki, or general improvements, etc.) would be described in a separate issue, and implemented in a separate PR.
19:39:20  <srl295>jgi: ok..
19:40:40  * bajtosquit (Quit: bajtos)
19:41:26  <jgi>srl295: but I don’t mean to say that https://github.com/joyent/node/issues/7676 is bad in any way, it’s a great contribution. I’m using it as an example of our issues with managing our work on GitHub, but I could have used a lot of other PRs/issues.
19:42:19  <jgi>srl295: I hope it didn’t come off as a critic on your amazing contributions, and if it did I apologize.
19:42:38  <srl295>jgi: no, no. and it's my first non-trivial GH contribution actually, definitely largest
19:42:57  <jgi>srl295: ok :)
19:43:35  <jgi>srl295: I know some people have investigated using other platforms to better organize issues/PRs on GitHub (like Waffle.io)
19:43:58  <jgi>srl295: I haven’ tried these yet, but I’m confident we can do better with better communication and planning
20:06:32  * austojoined
20:08:40  * saghuljoined
20:08:53  <jgi>srl295: lunch time. see you later!
20:08:56  <srl295>jgi: catch you later
20:13:12  * saghulquit (Ping timeout: 245 seconds)
20:18:42  * SplinterOfChaosjoined
20:20:17  * jgiquit (Quit: jgi)
20:21:51  * FROGGS[mobile]quit (Ping timeout: 256 seconds)
20:33:07  * Fishrock123quit (Remote host closed the connection)
20:40:44  * Fishrock123joined
20:56:45  * brsonjoined
21:08:40  * saghuljoined
21:13:09  * saghulquit (Ping timeout: 245 seconds)
21:25:15  * jgijoined
21:27:33  * saghuljoined
21:37:13  * a3fjoined
21:50:07  * Fishrock123quit (Quit: Leaving...)
21:55:43  * saghulquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
21:59:41  * saghuljoined
22:00:54  * tarrudajoined
22:01:06  * dap_1joined
22:01:49  * dshaw_joined
22:02:47  * dap_quit (Ping timeout: 244 seconds)
22:10:31  * AlexisMochajoined
22:11:09  * AlexisMocha_quit (Ping timeout: 252 seconds)
22:14:14  * saghulquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
22:15:03  * AlexisMochaquit (Ping timeout: 264 seconds)
22:15:10  * AlexisMochajoined
22:16:48  * austoquit (Remote host closed the connection)
22:17:57  * AlexisMocha_joined
22:19:46  * AlexisMochaquit (Ping timeout: 255 seconds)
22:24:39  * AlexisMocha_quit (Ping timeout: 264 seconds)
22:27:00  * AlexisMochajoined
22:29:55  * octetcloudquit (Ping timeout: 256 seconds)
22:32:39  * AlexisMocha_joined
22:33:09  * AlexisMochaquit (Ping timeout: 252 seconds)
22:33:49  * yunong_joined
22:35:12  * austojoined
22:36:23  * yunongquit (Ping timeout: 272 seconds)
22:37:51  * AlexisMochajoined
22:38:39  * AlexisMocha_quit (Ping timeout: 252 seconds)
22:43:16  <MI6>joyent/node: Chris Dickinson v0.12 * c8ef97e : src,zlib: revert concatenated-stream changes - http://git.io/Srr_5w
23:14:57  * mscdexjoined
23:19:14  <mscdex>is there a cross-platform way to get the last global error that works in v0.10 and v1.x? i was using uv_last_error() in v0.10 to get an error generated by a third party library
23:19:22  * seishunquit (Ping timeout: 240 seconds)
23:20:21  <mscdex>or do i have to do my own ifdef to check either errno or GetLastError() ?
23:20:50  <mscdex>and then somehow translate that to an error string that libuv knows about?
23:21:14  <mscdex>i saw that libuv uses a uv_translate_sys_error(), but i don't think that's public?
23:29:07  * bradleymeckquit (Quit: bradleymeck)
23:31:46  * jgiquit (Quit: jgi)
23:32:20  * rendarquit (Quit: Leaving)
23:32:22  * jgijoined
23:35:21  * octetcloudjoined
23:47:42  * zju4joined
23:47:42  * zju3joined
23:48:11  * zju1quit (Ping timeout: 244 seconds)
23:48:41  * zjuquit (Ping timeout: 256 seconds)
23:49:36  * dshaw_quit (Quit: Leaving.)