00:00:01  * ircretaryquit (Remote host closed the connection)
00:00:02  <tjfontaine>no, you'll need to log in and trigger it
00:00:09  * ircretaryjoined
00:00:13  <tjfontaine>I can if you'd like
00:00:36  <trevnorris>thanks. not sure it's needed quite yet. don't even have everything passing on my own box. :P
00:00:54  <tjfontaine>ok, when you do it's here http://jenkins.nodejs.org/job/node-review/
00:01:02  <tjfontaine>just tell it what branch you want
00:01:09  * c4miloquit (Remote host closed the connection)
00:05:16  * dshaw_quit (Quit: Leaving.)
00:06:25  <trevnorris>it's merge-review2
00:06:36  <trevnorris>wasn't feeling particularly inventive that moment.
00:07:08  * dshaw_joined
00:13:15  * brsonquit (Ping timeout: 258 seconds)
00:13:15  * avalanche123quit (Remote host closed the connection)
00:13:19  * jgiquit (Quit: jgi)
00:16:22  * avalanche123joined
00:18:39  * jgijoined
00:39:42  * toothrotjoined
00:44:29  * quijotejoined
00:47:10  * tjkrusinskijoined
00:49:01  * quijotequit (Ping timeout: 264 seconds)
00:49:51  <jgi>srl295: I managed to build node with —with-intl=small-icu, there’s more info here: https://github.com/srl295/node/issues/17#issuecomment-67260501
00:50:04  <jgi>srl295: that’s on SmartOS sorry
00:50:37  * dap_quit (Quit: Leaving.)
00:51:31  <jgi>tjfontaine, srl295: another issue with our SmartOS Jenkins agents is that they have Python 2.6 installed, but tools/configure.d/nodedownload.py requires Python 2.7
00:51:48  <jgi>tjfontaine, srl295: is it an option to upgrade these agents to Python 2.7?
01:10:59  * abraxas_joined
01:14:20  <tjfontaine>lets make it not require python 2.7
01:14:27  <tjfontaine>gyp requires 2.6
01:15:08  <MI6>joyent/node: Shigeki Ohtsu v0.10 * bddea12 : doc: Update LICENSE for zlib 1.2.8 (+2 more commits) - http://git.io/mFF6JA
01:16:16  * abraxas_quit (Ping timeout: 265 seconds)
01:17:24  <jgi>tjfontaine: gyp requires python 2.6 only on SmartOS or on other platforms?
01:17:35  <jgi>s/or/or also/
01:30:52  <srl295>Jgi: (from mobile) ok. Please file another issue about py27. I fixed my configure and icutrim deps on 26 before.
01:31:13  <jgi>srl295: alright, I’m doing that currently
01:31:33  <srl295>jgi: what is the error exactly?
01:31:42  <srl295>Or, I can wait for the issue
01:32:19  <jgi>srl295: I started fixing some issues, and ran into others. But I wanted to check if we really wanted to support Python 2.6 before digging further.
01:32:28  <jgi>srl295: I’ll create an issue later with all the details.
01:32:56  <srl295>I'm willing to fix it
01:35:15  <jgi>srl295: done :)
01:35:25  <jgi>srl295: sending a PR soon
01:35:57  <jgi>srl295: did you have time to try what you wanted to try regarding the shared intermediate directory on windows?
01:36:37  <srl295>jgi: I just tagged icu55m1. A couple of day off and could have included smartos support. What should happen with that patch? I'll see if it can be worked around from .gyp only.
01:37:36  <srl295>Jgi: yes I had to rebuild but I think substituting a variable may actually work. Pardon my typography, in the middle of an unexpected office-move-or-else
01:37:37  * octetcloudquit (Ping timeout: 240 seconds)
01:37:45  <jgi>srl295: which patch? This one: https://gist.github.com/misterdjules/531266720678b2127881?
01:38:00  <jgi>srl295: alright no problem :)
01:39:26  <srl295>jgi: node build doesn't use configure but it would help upstream. For node -D__sun=1 may work? (If os==smartos???)
01:39:49  <srl295>It's ironic, I had downloaded smartos to play with it anyways
01:40:44  <jgi>srl295: yes, I know that node doesn’t use configure. To build node on SmartOS, we would also need the rest of the changes here: https://gist.github.com/misterdjules/37263cf1dcbb879b2f50
01:40:53  <jgi>srl295: smartOS already defines __sun
01:44:50  * dshaw_quit (Quit: Leaving.)
01:45:20  * quijotejoined
01:47:59  <srl295>jgi sorry my misunderstanding re __sun, you're right. Added some comments to the last gist to try to avoid patching icu
01:48:24  * nickleeflyjoined
01:48:49  <jgi>srl295: thanks, looking at it now. Regarding nodedownload.py and Python 2.6, here’s a PR: https://github.com/srl295/node/pull/18
01:49:26  * quijotequit (Ping timeout: 250 seconds)
01:49:39  <srl295>Jgi: non hardcode paths work on windows. Want me to push to auto icu?
01:50:14  * c4milojoined
01:50:19  <jgi>srl295: do the tests run correctly on Windows with for instance “python tools/test.py simple”?
01:50:54  <jgi>srl295: I mean do they start correctly, no need to check if they pas or fail
01:50:56  <srl295>Jgi: running... (No "out" directory in sight)
01:51:09  <jgi>srl295: great!
01:51:30  <srl295>Ok lll push
01:51:52  <jgi>srl295: yes please
01:55:04  * c4miloquit (Ping timeout: 250 seconds)
01:56:07  * qardquit (Quit: leaving)
01:56:26  * chris_99quit (Quit: Ex-Chat)
01:56:44  <srl295>Jgi: 8d04281
01:57:44  <jgi>srl295: re: building Node on Smartos, I’ll try to exclude udbgutil.{h,cpp} from the sources and see how it goes
01:57:52  * abraxas_joined
01:58:24  <jgi>srl295: as for defining _XOPEN_SOURCE_EXTENDED=0, I don’t think it will fix the issue, since it will be forced to _XOPEN_SOURCE_EXTENDED=1 in uposixdefs.h, but I can also try just to double check
01:58:32  <jgi>srl295: thanks!
01:59:28  * Ralithquit (Ping timeout: 244 seconds)
02:05:58  <srl295>Jgi I'll pull your #18 py26 ok? Looks good
02:06:17  <jgi>srl295: yep!
02:06:19  <jgi>srl295: thanks
02:07:03  <srl295>Done
02:10:40  <jgi>srl295: I restarted a build + tests on the Windows build machines, we should have some results before 30 minutes
02:10:46  <srl295>Ok
02:11:08  <jgi>srl295: in the meantime, I’m testing some of the changes you suggested in https://gist.github.com/misterdjules/37263cf1dcbb879b2f50#comment-1357701 on SmartOS
02:13:10  * Fishrock123quit (Quit: Leaving...)
02:14:00  * avalanche123quit (Ping timeout: 258 seconds)
02:14:32  <srl295>Jgi: uposixdefs has if !defined(_XOPEN_SOURCE_EXTENDED)
02:14:47  <srl295>So I think u can pre define it
02:14:47  <jgi>srl295: yes
02:15:14  <jgi>srl295: ah right sorry, I always get confused between if !defined and if !
02:16:18  <cjihrig>trevnorris are you around?
02:29:23  * Ralithjoined
02:39:46  <jgi>srl295: I have to go, build + tests on Windows with —with-intl=small-icu passed: http://jenkins.nodejs.org/job/nodejs-julien-windows/
02:40:12  <jgi>srl295: Hopefully I’ll send a PR with another change for SmartOS that fixes the build issue
02:40:26  <jgi>srl295: thank you for all your help, we’re getting there :)
02:40:31  <jgi>srl295: see you later!
02:40:46  * seldoquit (Remote host closed the connection)
02:40:58  * seldojoined
02:41:00  * seldoquit (Remote host closed the connection)
02:41:14  * jgiquit (Quit: jgi)
02:46:00  * quijotejoined
02:47:24  <cjihrig>trevnorris: i made a PR into your merge-review2 branch with a fix for the child process failure
02:47:49  <cjihrig>https://github.com/joyent/node/pull/8887
02:49:13  * rmgquit (Remote host closed the connection)
02:50:32  * quijotequit (Ping timeout: 250 seconds)
03:03:12  * inolenquit (Ping timeout: 245 seconds)
03:09:02  * jgijoined
03:20:12  * rmgjoined
03:26:19  * tkelmanjoined
03:27:31  * seldojoined
03:35:24  * seldoquit
03:35:50  * Left_Turnquit (Remote host closed the connection)
03:39:20  * c4milojoined
03:43:18  * userjoined
03:43:34  * userquit (Client Quit)
03:43:50  * c4miloquit (Ping timeout: 250 seconds)
03:44:32  * mausvtjoined
03:46:36  * quijotejoined
03:48:25  <mausvt>Hello, Can anybody tell me is there way to detect second atempt to call uv_async_init on same object
03:51:29  * quijotequit (Ping timeout: 264 seconds)
03:51:52  <mausvt>how to prevent this and do some alert when i do uv_async_init with same data again
03:52:34  <mausvt>Yes I know you should be carefull but
03:53:29  <mausvt>it cost me 5 day to find this
04:06:40  * jgiquit (Quit: jgi)
04:14:22  * mausvtquit (Ping timeout: 258 seconds)
04:14:36  * AlexisMochaquit (Ping timeout: 250 seconds)
04:30:06  * a_lequit (Remote host closed the connection)
04:35:53  * toothrotquit (Ping timeout: 264 seconds)
04:47:17  * quijotejoined
04:49:33  * iarnaquit (Remote host closed the connection)
04:49:45  * iarnajoined
04:51:37  * quijotequit (Ping timeout: 240 seconds)
04:54:37  * ralphtheninjaquit (Ping timeout: 258 seconds)
04:54:37  * mmaleckiquit (Ping timeout: 258 seconds)
04:54:44  * ralphtheninjajoined
04:56:16  * mmaleckijoined
04:56:32  * Ralithquit (Ping timeout: 258 seconds)
04:57:16  * Ralithjoined
05:03:47  * jgijoined
05:28:25  * c4milojoined
05:33:20  * c4miloquit (Ping timeout: 258 seconds)
05:34:44  * petka_quit (Quit: Connection closed for inactivity)
05:41:47  * seldojoined
05:43:18  * WalrusPonyquit (Read error: Connection reset by peer)
05:43:27  * WalrusPonyjoined
05:46:27  * seldoquit (Ping timeout: 272 seconds)
05:48:03  * quijotejoined
05:52:41  * quijotequit (Ping timeout: 264 seconds)
06:10:56  * inolenjoined
06:23:13  * avalanche123joined
06:47:10  * jgiquit (Quit: jgi)
06:48:53  * avalanche123quit (Remote host closed the connection)
06:48:59  * quijotejoined
06:53:50  * quijotequit (Ping timeout: 258 seconds)
06:57:18  * bajtosjoined
07:08:28  * jgijoined
07:17:31  * c4milojoined
07:22:38  * c4miloquit (Ping timeout: 265 seconds)
07:24:21  * rmgquit (Remote host closed the connection)
07:33:20  * jgiquit (Quit: jgi)
07:35:12  * SergeiRNDjoined
07:38:58  * iarnaquit (Read error: Connection reset by peer)
07:39:27  * iarnajoined
07:43:12  * inolenquit (Ping timeout: 245 seconds)
07:45:46  * avalanche123joined
07:49:23  * bajtosquit (Quit: bajtos)
07:49:54  * quijotejoined
07:50:17  * avalanche123quit (Ping timeout: 244 seconds)
07:50:32  * bajtosjoined
07:54:25  * quijotequit (Ping timeout: 244 seconds)
08:03:40  * petka_joined
08:05:20  * quijotejoined
08:07:26  * SergeiRNDquit (Quit: Leaving.)
08:08:04  * rendarjoined
08:25:04  * rmgjoined
08:26:07  * SergeiRNDjoined
08:29:25  * Ryan_____joined
08:29:27  * rmgquit (Ping timeout: 245 seconds)
09:02:21  * bajtosquit (Quit: bajtos)
09:06:37  * c4milojoined
09:11:23  * c4miloquit (Ping timeout: 265 seconds)
09:25:22  * jreyno40_joined
09:32:02  * quijotequit (Ping timeout: 256 seconds)
09:33:54  * SergeiRNDquit (Quit: Leaving.)
09:35:30  * SergeiRNDjoined
09:35:30  * SergeiRNDquit (Client Quit)
09:35:40  * Ryan_____part
09:40:57  * a_lejoined
09:41:53  * AvianFluquit (Ping timeout: 264 seconds)
09:45:11  * chris_99joined
09:45:14  * chris_99quit (Changing host)
09:45:14  * chris_99joined
09:46:54  * quijotejoined
10:01:37  * SergeiRNDjoined
10:13:34  * jreyno40_part
10:16:54  * AlexisMochajoined
10:55:35  * tarrudajoined
10:55:41  * c4milojoined
10:55:57  * tarrudachanged nick to Guest92165
10:57:57  * Left_Turnjoined
10:58:03  * iarnaquit (Remote host closed the connection)
10:58:54  * abraxas_quit (Remote host closed the connection)
10:59:02  * iarnajoined
10:59:31  * abraxas_joined
11:00:33  * c4miloquit (Ping timeout: 250 seconds)
11:04:02  * abraxas_quit (Ping timeout: 245 seconds)
11:12:44  * Guest92165quit (Quit: WeeChat 1.0.1)
11:19:10  * bajtosjoined
11:19:28  * tkelmanquit (Quit: Page closed)
11:20:34  * nickleeflyquit (Quit: Connection closed for inactivity)
11:21:04  * AlexisMochaquit (Ping timeout: 245 seconds)
11:23:22  * tarruda_joined
11:24:45  * petka_quit (Quit: Connection closed for inactivity)
11:42:38  * iarnaquit (Remote host closed the connection)
11:47:10  * SergeiRNDquit (Read error: Connection reset by peer)
11:48:06  * SergeiRNDjoined
12:02:48  * quijotequit (Ping timeout: 258 seconds)
12:44:45  * c4milojoined
12:48:07  * abraxas_joined
12:49:37  * c4miloquit (Ping timeout: 255 seconds)
12:53:19  * abraxas_quit (Ping timeout: 272 seconds)
12:57:26  * bajtosquit (Quit: bajtos)
12:58:39  * bajtosjoined
12:59:02  * quijotejoined
12:59:53  * mausvtjoined
13:03:52  * quijotequit (Ping timeout: 265 seconds)
13:09:37  * bajtosquit (Quit: bajtos)
13:14:12  * quijotejoined
13:16:50  * lance|afkchanged nick to lanceball
13:18:31  * rmgjoined
13:23:09  * rmgquit (Ping timeout: 245 seconds)
13:33:29  * quijotequit (Ping timeout: 264 seconds)
13:34:32  * swajrjoined
13:35:49  * [spoiler]joined
13:35:50  * swajquit (Ping timeout: 240 seconds)
13:51:18  * Fishrock123joined
13:53:56  * AlexisMochajoined
14:02:50  * Fishrock123quit (Quit: Leaving...)
14:04:40  * Fishrock123joined
14:06:55  * SergeiRNDquit (Quit: Leaving.)
14:18:54  * quijotejoined
14:23:17  * quijotequit (Ping timeout: 240 seconds)
14:33:53  * c4milojoined
14:36:13  * quijotejoined
14:37:17  * abraxas_joined
14:38:36  * c4miloquit (Ping timeout: 256 seconds)
14:41:02  * trevnorrisquit (Ping timeout: 244 seconds)
14:41:33  * abraxas_quit (Ping timeout: 250 seconds)
14:43:30  * iarnajoined
14:43:50  * trevnorrisjoined
14:47:11  * dshaw_joined
14:47:37  * iarnaquit (Ping timeout: 240 seconds)
14:53:13  * KennethWilkejoined
15:07:34  * rmgjoined
15:12:29  * rmgquit (Ping timeout: 264 seconds)
15:15:35  * tarruda_quit (Quit: WeeChat 1.0.1)
15:23:14  * tjkrusinskiquit (Ping timeout: 250 seconds)
15:29:17  * KennethWilkequit (Remote host closed the connection)
15:33:00  * KennethWilkejoined
15:37:32  * quijotequit (Ping timeout: 250 seconds)
15:41:50  * petka_joined
15:44:56  * AvianFlujoined
15:57:18  * quijotejoined
15:59:03  * Fishrock123quit (Ping timeout: 244 seconds)
16:00:20  * piscisaureusjoined
16:02:04  * tarrudajoined
16:02:28  * tarrudachanged nick to Guest97521
16:03:00  * bajtosjoined
16:05:21  * Fishrock123joined
16:06:37  * Guest97521quit (Client Quit)
16:07:01  * tarruda_joined
16:12:06  * tarruda_quit (Quit: WeeChat 1.0.1)
16:13:39  * tarruda_joined
16:15:29  * c4milojoined
16:20:38  * dshaw_quit (Quit: Leaving.)
16:22:20  * SergeiRNDjoined
16:23:24  <srl295>jgi: just got an ICU bug report against GCC on *solaris*.
16:23:56  * cofzjoined
16:26:28  * cofzquit (Client Quit)
16:29:23  * seishunjoined
16:56:40  * rmgjoined
17:06:15  * jgijoined
17:07:01  * qardjoined
17:09:10  * mausvtquit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
17:09:40  * jgiquit (Client Quit)
17:12:19  * jgijoined
17:16:54  * jgiquit (Client Quit)
17:21:07  * quijotequit (Ping timeout: 245 seconds)
17:22:25  * dap_joined
17:26:49  * tarruda_quit (Quit: WeeChat 1.0.1)
17:38:13  * tarrudajoined
17:38:37  * tarrudachanged nick to Guest95878
17:39:08  * Guest95878quit (Client Quit)
17:45:36  * quijotejoined
17:45:37  * KennethWilkequit (Quit: Leaving)
17:46:33  * jgijoined
17:48:46  * sblomjoined
17:49:03  * sblomquit (Read error: Connection reset by peer)
17:49:22  * sblomjoined
17:49:32  * sblomquit (Read error: Connection reset by peer)
17:50:08  * KennethWilkejoined
17:50:40  <jgi>srl295: ah nice, can I see the bug report? Is it in ICU’s Trac database?
17:50:53  <srl295>jgi: it's on the mailing list
17:51:53  <jgi>srl295: good timing :)
17:51:58  <srl295>jgi: but, same error. I merged your fix
17:51:59  <srl295>right!
17:52:06  <jgi>srl295: cool thanks
17:52:26  <srl295>jgi: getting icu 55m1 out today
17:52:33  <jgi>awesome
17:53:28  <jgi>do you want me to double check that the latest trunk on SmartOS builds before doing the release?
17:54:17  <srl295>jgi: um- which release?
17:54:33  <jgi>icu 55m1
17:57:15  * tarruda_joined
17:57:42  <jgi>srl295: also, it seems that https://github.com/joyent/node/pull/8719 would be ready for landing in v0.12 right?
17:57:53  <srl295>jgi: That's my opinion, but i'm biased
17:58:23  <jgi>srl295: I’ll review it thoroughly today, but I’m optimistic
17:58:25  <srl295>I think it is ready, if it's ok that it doens't have your `configure --icu-data-dir ` changes
17:58:40  <jgi>srl295: yes, I think we want to land it separately
17:58:50  <srl295>sounds good to me
17:58:51  * dap_1joined
17:59:02  <jgi>srl295: cool, I’ll let you know when I’m done with the review
17:59:32  <srl295>thanks! I won't change it anymore.. once it lands I'll do the wiki fixes as promised
17:59:42  <jgi>srl295: excellent
17:59:57  <jgi>srl295: I have a meeting until 11AM, but my plan is to do the review right after that
18:00:06  <jgi>srl295: thank you again for all your work :)
18:01:07  * dap_quit (Ping timeout: 265 seconds)
18:01:41  * iarnajoined
18:02:12  * reqsharkjoined
18:02:20  <srl295>jgi: welcome! I think I'll (1) add a smartos buildbot to ICU which will break and then (2) fix the ticket then (3) profit! I just fixed a bug. Thread here http://sourceforge.net/p/icu/mailman/message/33159444/
18:04:37  * quijotequit (Ping timeout: 264 seconds)
18:15:37  * avalanche123joined
18:24:28  * tjkrusinskijoined
18:28:01  * quijotejoined
18:29:23  * sblomjoined
18:30:29  * sblomquit (Read error: Connection reset by peer)
18:38:24  * AlexisMochaquit (Ping timeout: 258 seconds)
18:41:21  * seldojoined
18:42:08  * seldoquit (Client Quit)
18:44:45  * davijoined
18:44:45  * daviquit (Changing host)
18:44:45  * davijoined
18:53:36  * quijotequit (Ping timeout: 256 seconds)
18:54:47  * bradleymeckjoined
19:03:30  * tarruda_quit (Ping timeout: 244 seconds)
19:06:49  <srl295>jgi: and the shock of the day: I got assigned the ICU4C Joyent/Solaris bug
19:08:22  <jgi>srl295: ah, and the comments here: http://bugs.icu-project.org/trac/ticket/11435#comment:2 are from me
19:08:55  * bajtosquit (Quit: bajtos)
19:09:02  <srl295>jgi: we could *maybe* put an "if icu major < 55" in the gyp. Or, just revisit later
19:10:16  <srl295>jgi: how's this. when I actually commit it to ICU, I'll add an issue against myself to PR a "# Note: make this conditional once ICU 55+ fixes this.."
19:12:07  <jgi>srl295: yep, sounds good
19:16:03  * piscisaureusquit (Quit: ~ Trillian Astra - www.trillian.im ~)
19:16:57  * Ralithquit (Ping timeout: 245 seconds)
19:18:31  * quijotejoined
19:19:29  <jgi>srl295: alright, back from the meeting, sorry for being on and off during the last hour
19:19:38  <tjfontaine>ok sooooo
19:19:40  <tjfontaine>here I am
19:20:41  <tjfontaine>jgi, srl295: why is the tool to download written in python not node? as far as bootstrapping is concerned people could just curl/wget/etc if well documented
19:20:50  * AlexisMochajoined
19:20:52  * quijote_joined
19:20:56  <srl295>tjfontaine: jgi: s'ok, im still on a meeting here
19:21:39  <srl295>jgi: srl295: by 'tool' you mean the ICU download? ICU is needed for building node with intl
19:22:35  <srl295>tjfontaine: jgi: just a moment
19:22:36  <jgi>srl295, tjfontaine: I think he’s referring to tools/configure.d/nodedownload.py
19:22:44  * quijotequit (Ping timeout: 245 seconds)
19:25:14  * quijote_quit (Ping timeout: 245 seconds)
19:26:24  <tjfontaine>at the very least we can easily make this use python 2.6 semantics as opposed to 2.7, but ideally we could write this tool in node, for bootstrapping they could first build without intl support such that they could have a node binary for use
19:27:48  * daviquit (Ping timeout: 245 seconds)
19:28:05  <jgi>tjfontaine: what are Python 2.7 semantics?
19:28:32  <srl295>tjfontaine: jgi: finishing last ICU meeting of the year..
19:28:42  <tjfontaine>jgi: well, where does the tool fail today on python 2.6? I'm presuming it's a module or method that doesn't exist in py2.6
19:28:46  <tjfontaine>srl295: sounds good
19:28:57  <jgi>tjfontaine: it’s been fixed
19:29:02  <tjfontaine>jgi: ok
19:29:03  <srl295>tjfontaine: jgi: back. I think I already merged fixes to support py26
19:29:15  <tjfontaine>ok, long term, I'd rather the tool be written in node :)
19:29:16  <srl295>it's more of a library than a tool
19:29:27  <tjfontaine>sure
19:29:29  <srl295>it's called from configure
19:29:51  <jgi>tjfontaine: the fixes to make nodedownload.py work with Python 2.6 semantics are in this PR: https://github.com/srl295/node/pull/18
19:29:52  <tjfontaine>yes, but easier for the community to approach/maintain if it's what they're used to seeing
19:30:02  <jgi>tjfontaine: which srl295 has already merged in his branch
19:30:33  * SergeiRNDquit (Quit: Leaving.)
19:31:34  <srl295>if node's available, would it be better to just use an npm module to manage the download?
19:32:01  <srl295>tjfontaine: I get the point of using node.. but I'm not sure what the scenario is. You have old-nod eand you are building new-node from source?
19:32:14  <tjfontaine>nothing we need to tackle today, just a medium term goal for the project I think should be that more of our individual tooling should be in node
19:32:50  <tjfontaine>srl295: yes, more often than not people have a node in their env already, and from scratch you just have to do the normal bootstrap rebuild
19:33:25  <tjfontaine>trevnorris, cjihrig: ping on the status of the v0.10 merge you were working through?
19:33:35  <srl295>build a "minimal" node.. install it somewhere.. call it from "configure"
19:33:59  <tjfontaine>yes
19:34:09  <tjfontaine>doesn't even have to be installed for that matter
19:34:12  <srl295>Java JDK has a similar bootstrap requirement
19:34:21  <tjfontaine>mono as well
19:34:42  <tjfontaine>it's a common practice in compiler/runtime/framework toolchains
19:34:55  <cjihrig>tjfontaine: i opened PR 8887 into the merge-review2 branch to fix the child_process problem
19:35:06  <tjfontaine>again, it's not a blocker, just a principle I'd like to see us move towards
19:35:41  <srl295>tjfontaine: an interim step might be to refactor configure into more functions/modules like nodedownload.py
19:36:11  <tjfontaine>srl295: ya, I have a desire to actually refactor a lot of Makefile steps into configure, because then Windows would actually always stay in sync
19:36:35  <srl295>tjfontaine: that makes sense as an overall principle, not a one-off direction for this piece. thanks for explaining
19:36:37  <tjfontaine>vcbuild.bat could just ask configure (or some other tool but written [unfortunately] in python) to runa rule
19:36:42  <tjfontaine>srl295: nod
19:37:33  <tjfontaine>cjihrig: I thought I previously had done the normalizeSpawnArguments change for spawn() is that perhaps something that got clobbered in a merge?
19:38:21  * tarruda_joined
19:38:36  <cjihrig>tjfontaine: seems like just a slip up in the merge. a lot of stuff was added in 0.10 that would have gone in normalizeSpawnArguments in 0.12
19:38:48  <tjfontaine>cjihrig: yup, agreed
19:38:59  <tjfontaine>looking at exisitng v0.12 my changes are indeed there
19:39:49  <tjfontaine>ok sounds good
19:40:05  <tjfontaine>that will resolve itself when trevnorris includes it
19:40:09  * Ralithjoined
19:40:21  <cjihrig>cool
19:40:36  <tjfontaine>cjihrig: the changes to the tests, around execFile and empty, those are semantics that have changed in v0.12 from v0.10?
19:41:39  <cjihrig>tjfontaine: i'm not 100% what was going on there. i was getting EACESS on that empty fixture, made it executable and it just worked
19:42:19  <tjfontaine>yes, that makes sense, I meant more the removal of the doesNotThrow portion for execFile
19:42:58  <tjfontaine>https://github.com/joyent/node/pull/8887/files#diff-1d7dd9269d3961468b3d47dfaf5863b9L129 and following
19:43:19  <cjihrig>oh. those are actually duplicated earlier in the file
19:43:36  <tjfontaine>ok thanks, so probably another artifact of mismerge, great thanks for the info :)
19:45:09  <cjihrig>tjfontaine: i think that was just duplicated in the original PR
19:45:10  <cjihrig>https://github.com/joyent/node/blob/v0.10/test/simple/test-child-process-spawn-typeerror.js#L43-L102
19:45:48  <tjfontaine>cjihrig: in that case, would you mind cleaning up that test for v0.10?
19:46:03  <tjfontaine>cjihrig: consider this a pre-emptive LGTM for landing
19:46:25  <cjihrig>tjfontaine: sure thing
19:48:26  <tjfontaine>jgi: talk to me about #8800
19:48:49  <tjfontaine>jgi: there aren't any (known) adverse affects for existing users of the debug interface, right?
19:49:52  <jgi>tjfontaine: not that I know of, but I haven’t tested all use cases of this interface
19:50:04  <tjfontaine>jgi: the "Fixes" in the comment of the PR isn't the right tracking issue, can you find the original for me?
19:50:28  <jgi>tjfontaine: yes, that’s weird
19:50:36  <tjfontaine>oh 8665
19:50:39  <tjfontaine>it's in the title
19:50:54  <tjfontaine>nope, I was wrong :)
19:51:04  <jgi>tjfontaine: https://github.com/joyent/node/issues/8685
19:51:11  <tjfontaine>right I figured it was dyslexia :)
19:51:17  <tjfontaine>thanks!
19:51:31  <MI6>joyent/node: Julien Gilli v0.10 * 45f1330 : deps: backport b593aa8 from v8 upstream (+1 more commits) - http://git.io/dQM0Fw
19:53:21  <jgi>tjfontaine: let’s just say it’s GitHub’s completion fault
19:53:23  <jgi>:)
19:53:27  <tjfontaine>agreed.
19:53:41  * Wraithanchanged nick to node_modules
19:53:53  <tjfontaine>node_modules: orly
19:54:07  <node_modules>:)
19:54:18  * node_moduleschanged nick to Wraithan
19:55:09  <MI6>joyent/node: Julien Gilli v0.10 * 542234a : doc: improve dns module's documentation - http://git.io/4jb9hA
19:57:03  * inolenjoined
19:58:17  * Wraithanchanged nick to node_modules
19:58:28  * node_moduleschanged nick to Wraithan
20:03:07  * abraxas_joined
20:08:22  * abraxas_quit (Ping timeout: 255 seconds)
20:08:39  <MI6>joyent/node: cjihrig v0.10 * f75a8ad : test: remove redundant code in test - http://git.io/2yzsOQ
20:15:00  * avalanche123quit (Remote host closed the connection)
20:21:41  * quijotejoined
20:22:58  * dap_1quit (Quit: Leaving.)
20:23:28  * avalanche123joined
20:26:17  * quijotequit (Ping timeout: 264 seconds)
20:27:39  * reqsharkquit (Ping timeout: 258 seconds)
20:27:49  * avalanche123quit (Ping timeout: 245 seconds)
20:30:07  * piscisaureusjoined
20:40:10  <MI6>joyent/node: Ben Noordhuis v0.10 * 1eb1e0a : src: reduce cpu profiler overhead - http://git.io/jYqLAg
20:42:07  <trevnorris>tjfontaine: when I include what?
20:44:51  <srl295>jgi: thanks for the review notes. priority/timing of refactoring configure_intl ?
20:45:34  <txdv>ls
20:45:35  <ZenWraithBot>txdv: http://is.gd/afolif
20:45:49  <MI6>joyent/node: Trevor Norris v0.10 * afb488d : Revert "src: reduce cpu profiler overhead" - http://git.io/sT8xgg
20:45:51  <txdv>ls -lha
20:45:54  <txdv>ls
20:45:55  <ZenWraithBot>txdv: http://is.gd/afolif
20:46:21  <srl295>txdv: ls: bad comand or file name
20:46:31  <jgi>srl295: I think I’m fine with refactoring it later
20:46:47  <chrisdickinson>anyone opposed to landing https://github.com/joyent/node/pull/6460 ?
20:46:56  <chrisdickinson>cc jgi tjfontaine ^
20:47:04  <srl295>jgi: the rest i can do today
20:48:15  <jgi>chrisdickinson: I’m finishing the review of https://github.com/joyent/node/pull/8719, and I’ll review https://github.com/joyent/node/pull/6460 right after if you still need a review
20:49:16  <chrisdickinson>ah, cool -- just looking for any opposition -- was planning on merging it this afternoon if no one has strong objections
20:50:12  <tjfontaine>trevnorris: thanks for reverting that, we can't use that symbol
20:51:53  <tjfontaine>chrisdickinson: I am fine with landing that commit
20:52:01  <[spoiler]>I have a somewhat libuv-unrelated question... I'm reading RFC6455 and I'm not sure why the opening handshake needs to be HTTP/1.1 compliant. Do they expect web servers to implement WS and allow for a normal HTTP/1.1 connection to upgrade from HTTP to WS?
20:52:01  <chrisdickinson>cool, will land!
20:52:35  <[spoiler]>as in a normal webserver listening on 80
20:53:15  <[spoiler]>ok apparently, yes
20:53:56  <[spoiler]>The WebSocket Protocol attempts to address the
20:53:56  <[spoiler]> goals of existing bidirectional HTTP technologies in the context of
20:53:56  <[spoiler]> the existing HTTP infrastructure; as such, it is designed to work
20:53:56  <[spoiler]> over HTTP ports 80 and 443 as well as to support HTTP proxies and
20:53:56  <[spoiler]> intermediaries, even if this implies some complexity specific to the
20:53:57  <[spoiler]> current environment.
20:53:59  <[spoiler]>oops
20:54:16  <[spoiler]>forgot the client sends messages on newlines, sorry about that
20:54:47  <[spoiler]>mental note 1: read introduction and background chapters in the future
20:55:13  <[spoiler]>mental note 2: don't paste text with linebreaks into irc
20:55:27  * dap_joined
20:59:34  * chris_99quit (Quit: Ex-Chat)
20:59:38  <[spoiler]>gah time to go home finally; long & shit day :/
20:59:40  * [spoiler]quit (Quit: Leaving)
21:00:09  * chris_99joined
21:01:06  <MI6>joyent/node: Miroslav Bajtoš v0.12 * e93ff4f : debugger: fix unhandled error in setBreakpoint - http://git.io/h3H_PQ
21:01:43  <tjfontaine>seems like that could have perhaps gone into v0.10?
21:03:10  <tjfontaine>chrisdickinson: did you fix the windows breakage on v0.12?
21:03:41  <chrisdickinson>ah, no
21:03:48  * cofzjoined
21:08:16  <jgi>srl295: I added a bunch of comments, but it’s mostly me asking questions or thinking out loud
21:09:34  <jgi>srl295: I’ll have lunch and then when you have some time to reply, please do and I’ll be able to give you some feedback then
21:09:45  <srl295>jgi: i added some comments
21:10:38  <jgi>srl295: thank you very much again
21:10:41  <jgi>srl295: I’ll see you in a bit
21:10:44  <chrisdickinson>tjfontaine: no, I can revert that commit if desired.
21:11:03  <tjfontaine>chrisdickinson: I think the fix is fairly straight forward, if you want to just submit a follow up for now
21:11:24  <tjfontaine>chrisdickinson: the mechanism is either revert and re-apply with 100% working, or commit a follow up
21:11:37  <tjfontaine>feel free to use the jenkins node-review job to verify
21:13:59  <tjfontaine>starting the v0.10.34 release now
21:14:15  <tjfontaine>AlexisMocha, trevnorris, jgi, chrisdickinson, cjihrig, indutny
21:14:52  <cjihrig>what's up
21:14:54  * jreyno40joined
21:15:03  <tjfontaine>if you need anything for v0.10 speak up :)
21:15:14  * c4miloquit (Remote host closed the connection)
21:18:21  * c4milojoined
21:19:30  * avalanche123joined
21:21:33  <MI6>joyent/node: tjfontaine created branch v0.10.34-release - http://git.io/8GIhDg
21:21:49  * tarruda_quit (Quit: WeeChat 1.0.1)
21:22:27  * quijotejoined
21:23:26  * jgiquit (Quit: jgi)
21:27:26  * quijotequit (Ping timeout: 264 seconds)
21:27:31  * dshaw_joined
21:32:47  * AlexisMochaquit (Ping timeout: 245 seconds)
21:39:19  * avalanche123quit (Remote host closed the connection)
21:41:59  <MI6>joyent/node: chrisdickinson created branch fix-zlib-windows - http://git.io/4UkEIw
21:42:04  * avalanche123joined
21:44:37  * jgijoined
21:52:21  * abraxas_joined
21:56:37  * seishunquit (Remote host closed the connection)
21:57:21  * abraxas_quit (Ping timeout: 258 seconds)
21:59:16  * seishunjoined
21:59:30  * brsonjoined
21:59:59  <tjfontaine>can you guys try the artifacts in http://nodejs.org/dist/v0.10.34/
22:00:20  <tjfontaine>in particular if you have a windows box I'd love to make sure that works, verifying that it's signed with the new certificate
22:00:43  <tjfontaine>jgi, chrisdickinson, cjihrig, trevnorris, indutny ^
22:00:53  <jgi>tjfontaine: trying that right now
22:00:59  <tjfontaine>thanks
22:01:54  * seishunquit (Client Quit)
22:01:56  <chrisdickinson>running the installer on win7 now
22:02:43  <tjfontaine>on the msi properties you should see digital signatures, and go to advanced and the issuer should be thawte
22:03:06  <trevnorris>tjfontaine: I should have known better than to commit that in the first place. sorry about that.
22:03:12  <tjfontaine>trevnorris: sok
22:03:27  <trevnorris>yeah. I have a win 8.1 vm that i'll try those out on.
22:03:46  * seishunjoined
22:04:44  <jgi>tjfontaine: tested the x64 build and it installs and works fine
22:04:45  <chrisdickinson>tjfontaine: the signature/issuer looks good on win7
22:04:50  <jgi>tjfontaine: issuer is Thawte in the msi
22:04:50  <tjfontaine>thanks guys!
22:05:08  <jgi>no problem :)
22:05:45  <chrisdickinson>looks good on osx as well
22:05:55  <tjfontaine>eggsellent
22:06:11  <chrisdickinson>hm
22:06:21  * tjfontainepauses
22:06:22  <chrisdickinson>after installing on windows i'm still getting v0.10.33 when I `node -v`
22:06:33  <chrisdickinson>also after restarting.
22:06:48  <tjfontaine>jgi: same thing?
22:07:06  <jgi>tjfontaine: no, I get 0.10.34
22:07:11  <tjfontaine>ok
22:07:17  <tjfontaine>chrisdickinson: 32 vs 64 issue?
22:07:29  <chrisdickinson>probably just something weird in my vm. uninstalling and rerunning installer
22:07:31  <jgi>tjfontaine: I tested both versions
22:07:36  <chrisdickinson>64
22:07:40  <jgi>tjfontaine: x86 and x64
22:07:43  <tjfontaine>we don't allow both installed at the same time, right?
22:07:50  <tjfontaine>if 32bit is installed an in path before x64 ...
22:07:59  <trevnorris>waiting to download 300MB of system updated (I don't use this VM very often. :P
22:08:05  <tjfontaine>heh
22:09:17  <trevnorris>tjfontaine: still haven't figured out the child process issue w/ the v0.10 merge.
22:09:33  <tjfontaine>trevnorris: that's what cjihrig fixed
22:09:33  <chrisdickinson>yeah, I think there's just something else hanging out in my path because of builds
22:09:43  <tjfontaine>chrisdickinson: seems plausible
22:09:53  <trevnorris>erm? in a recent commit?
22:10:05  <tjfontaine>trevnorris: in a PR beside yours
22:10:15  <trevnorris>ah, okay.
22:10:17  <tjfontaine>trevnorris: looks like some artifacts of a mismerge
22:10:37  <trevnorris>....
22:10:40  <chrisdickinson>tjfontaine: tangentially: https://github.com/joyent/node/pull/8893 + http://jenkins.nodejs.org/job/node-review-windows/
22:10:53  <chrisdickinson>(fixes the zlib windows issue)
22:11:08  <tjfontaine>trevnorris: your merge is clobbering the normalizeSpawnArgs call, ttps://github.com/joyent/node/pull/8887
22:11:28  <trevnorris>ah, crap.
22:12:12  <jgi>tjfontaine: just installed 0.10.34 on OS X and it works fine too
22:12:26  <tjfontaine>chrisdickinson: lgtm, aside from changing the pr url and adding me as a reviewer
22:12:36  <chrisdickinson>will do
22:12:43  <chrisdickinson>do we want to preserve the original PR URL at all?
22:13:02  <tjfontaine>I don't think that's necessary, I don't want to confuse the commit histories
22:13:13  <chrisdickinson>cool, will merge
22:14:08  <tjfontaine>everyone cool with the rest of v0.10.34 release going forward?
22:14:41  <MI6>joyent/node: Ben Noordhuis v0.12 * 93533e9 : src: fix windows build error - http://git.io/o51NCw
22:14:47  <trevnorris>sure
22:15:16  <MI6>joyent/node: tjfontaine created tag v0.10.34 - http://git.io/v0YX4w
22:15:21  <trevnorris>cjihrig: you rock dude. mind if I squash #8887 into the v0.10 merge?
22:15:48  <cjihrig>trevnorris: not at all
22:17:28  <tjfontaine>oh bugger
22:17:58  <tjfontaine>*sigh* I'm going to have to recut this release
22:18:42  * jreyno40quit (Quit: jreyno40)
22:19:41  <tjfontaine>actually maybe not
22:19:48  <tjfontaine>it will just be ugly
22:20:51  <tjfontaine>nah I think I'll just recut it
22:22:26  <seishun>what's the problem?
22:22:39  <trevnorris>tjfontaine: any thoughts on https://github.com/joyent/node/pull/8789 ? (no need to comment until after the release. ;)
22:23:16  * quijotejoined
22:24:25  <trevnorris>cjihrig: okay. the only test that's failing for me now is test-tls-honorcipherorder-secureOptions.js. indutny says he has a fix for that though, and i'm not sure what the problem is.
22:24:41  * dshaw_quit (Quit: Leaving.)
22:24:50  <MI6>joyent/node: Trevor Norris merge-review2 * 71656a9 : Merge branch 'v0.10' into merge-review2 - http://git.io/xP_sMg
22:25:00  <cjihrig>trevnorris: cool. that's where i was after my fix too
22:26:05  <jgi>srl295: responded to your comments on https://github.com/joyent/node/pull/8719
22:26:51  <trevnorris>jgi: thanks for picking up so much on the icu stuff. you've been a huge help. :)
22:27:06  <jgi>trevnorris: no problem, that’s a team effort :)
22:27:48  * quijotequit (Ping timeout: 256 seconds)
22:28:01  <trevnorris>someone mind kicking jenkins to build/test the merge-review2 branch?
22:29:25  * c4miloquit (Remote host closed the connection)
22:30:06  * c4milojoined
22:30:09  <jgi>trevnorris: I can do that
22:30:15  <trevnorris>thanks much
22:31:34  <jgi>trevnorris: http://jenkins.nodejs.org/job/node-review/
22:33:23  * jreyno40joined
22:35:52  <tjfontaine>ok, walking away from my desk, I now remember that I don't need to re-cut this release
22:35:59  * c4miloquit (Ping timeout: 272 seconds)
22:39:55  <MI6>joyent/node: Timothy J Fontaine v0.10 * 1b81ea8 : Now working on 0.10.35 (+2 more commits) - http://git.io/GXrYwg
22:40:04  <tjfontaine>much better
22:42:51  * inolen1joined
22:42:51  * inolenquit (Read error: Connection reset by peer)
22:46:33  * inolen1quit (Read error: No route to host)
22:47:05  * lanceballchanged nick to lance|afk
22:53:48  <chrisdickinson>tjfontaine: how would you feel about closing https://github.com/joyent/node/issues/8830 ?
22:53:58  <chrisdickinson>(or I can)
22:55:44  <jgi>tjfontaine: thanks for the release
23:04:13  * quijotejoined
23:11:23  * dap_1joined
23:12:44  * dap_quit (Ping timeout: 245 seconds)
23:12:52  * seishunquit (Ping timeout: 255 seconds)
23:13:18  <tjfontaine>chrisdickinson: I'm not sure would necessarily close it, perhaps maybe edit the title and description to be positive and future facing
23:13:57  <tjfontaine>chrisdickinson: "node should allow pinning of module loading" or something
23:14:16  <tjfontaine>chrisdickinson: or open a new issue with the feature request, and close this one and link them
23:17:42  * quijotequit (Ping timeout: 244 seconds)
23:18:28  <tjfontaine>trevnorris: what happened on x64 linux for your merge branch? http://jenkins.nodejs.org/job/node-review-unix/DESTCPU=x64,label=linux/329/tapTestReport/
23:18:44  <tjfontaine>http://jenkins.nodejs.org/job/node-review-unix/DESTCPU=x64,label=linux/329/tapTestReport/simple.tap-419/ seems kinda bogus
23:19:38  * AvianFluquit (Ping timeout: 265 seconds)
23:20:21  * AvianFlujoined
23:21:36  * inolenjoined
23:25:39  <trevnorris>tjfontaine: No idea what that could be from. I'll double check. Also, what do you mean by "bogus"?
23:26:08  * piscisaureusquit (Quit: ~ Trillian Astra - www.trillian.im ~)
23:26:30  <trevnorris>cjihrig: seems there are more child process issues than I thought: http://jenkins.nodejs.org/job/node-review-unix/DESTCPU=x64,label=linux/329/tapTestReport/simple.tap-49/
23:26:39  <trevnorris>though I'm not sure why those aren't showing up on my system.
23:28:34  * rendarquit (Quit: Leaving)
23:30:55  <tjfontaine>trevnorris: bogus as in you don't need to investigate that I don't thiknk
23:30:57  * AvianFluquit (Ping timeout: 240 seconds)
23:34:14  <trevnorris>ah, okay
23:36:35  * AvianFlujoined
23:40:11  * KennethWilkequit (Quit: Leaving)
23:41:23  * abraxas_joined
23:45:22  * quijotejoined
23:46:07  * abraxas_quit (Ping timeout: 245 seconds)
23:48:15  <trevnorris>tjfontaine: this is a strange one: http://jenkins.nodejs.org/job/node-review-windows/lastCompletedBuild/DESTCPU=ia32,label=windows/tapTestReport/simple.tap-47/
23:49:48  <tjfontaine>trevnorris: what's the test on line 65?
23:50:05  * quijotequit (Ping timeout: 265 seconds)
23:53:21  * avalanche123quit (Remote host closed the connection)
23:56:32  * avalanche123joined