00:00:01  * ircretaryquit (Remote host closed the connection)
00:00:10  * ircretaryjoined
00:00:51  <tjfontaine>chrisdickinson: in exchange for antoher quick review, that yours could be rebased on :)
00:01:00  <chrisdickinson>sure :)
00:01:21  <tjfontaine>jgi: where's that path pr?
00:01:32  <jgi>tjfontaine: well played, well played ;-)
00:01:48  <jgi>let me find that
00:02:33  <jgi>tjfontaine: https://github.com/joyent/node/pull/5661#issuecomment-61896288
00:03:37  * chrisdickinsonlooks
00:03:38  <tjfontaine>ok, lemme comment on this so we can have all the tracking
00:04:43  <tjfontaine>https://github.com/misterdjules/node/compare/joyent:v0.12...path-platform?w=1
00:04:45  * a_lequit (Remote host closed the connection)
00:04:47  <tjfontaine>is the easiest way to review that
00:05:49  * inolenquit (Ping timeout: 265 seconds)
00:08:29  * inolenjoined
00:13:49  <chrisdickinson>tjfontaine: this looks good to me!
00:14:41  <tjfontaine>excellent
00:14:55  <tjfontaine>want to land it, or shall I?
00:14:56  <chrisdickinson>I'll pull that into my PR.
00:14:59  <tjfontaine>thanks
00:15:15  <tjfontaine>and thanks jgi for rebasing it
00:15:34  <jgi>you’re welcome :)
00:16:18  <tjfontaine>fwiw the context around root is kinda bogus, but I really don't think there's a good way to solve this
00:16:27  <tjfontaine>I expect we'll have follow up commits for it :)
00:16:39  <tjfontaine>all in all, I'm ok with it :)
00:18:25  * a_lejoined
00:24:21  <jgi>tjfontaine: Do you have any idea why build jobs for Windows start on SmartOS: http://jenkins.nodejs.org/job/nodejs-julien-windows/17/console ?
00:24:48  <jgi>tjfontaine: in the job’s configuration, the label is set to Windows
00:24:58  <tjfontaine>executors can start anywhere
00:25:00  <tjfontaine>unfortunately
00:25:06  <tjfontaine>it'st he way matrix jobs work
00:25:19  <tjfontaine>the job that supervises a matrix job doesn't take up an executor slot
00:25:21  <jgi>tjfontaine: but there’s a “(null)” string at the end of every label/individual nodes now
00:25:23  <tjfontaine>and can run anywhere
00:25:39  <tjfontaine>looking
00:27:05  <tjfontaine>jgi: your apps jobs are filling disc quotas
00:27:12  <tjfontaine>144G nodejs-apps-0-11-14-release
00:27:28  <jgi>tjfontaine: we can remove that job
00:27:44  <jgi>tjfontaine: of course I’ll investigate why it takes up so much space
00:27:50  <tjfontaine>I just want to see who or what is doing it
00:27:51  <jgi>tjfontaine: but for now we can remove it
00:27:56  <tjfontaine>143G npm-master
00:28:02  * a_le_joined
00:28:09  <tjfontaine>143G npm-test-44100
00:28:50  <tjfontaine>/home/jenkins/workspace/nodejs-apps-0-11-14-release/60c2747e/test-node-apps/tests-workspace/npm-master/npm-test-44100/npm_cache/npm/2.1.9]# ls -alh package.tgz
00:28:53  <tjfontaine>-rw-r--r-- 1 root root 143G Nov 19 11:47 package.tgz
00:29:00  <tjfontaine>othiym23: hey, what's that test do?
00:29:07  <tjfontaine>or even jgi
00:29:29  <tjfontaine>jgi: basically this happens and nukes all the slaves, so I have to go clean it up everywhere :)
00:29:39  <jgi>tjfontaine: I’m very sorry for that :(
00:29:46  <tjfontaine>it's ok :)
00:29:49  * a_lequit (Ping timeout: 255 seconds)
00:30:23  <jgi>tjfontaine: I’m going to suspend all the *-apps jobs for now
00:30:28  <tjfontaine>ok
00:31:22  <chrisdickinson>tjfontaine: running tests now, should have a PR up shortly
00:31:28  <chrisdickinson>or rather, the same pr, but updated :)
00:31:32  <tjfontaine>ok thansk :)
00:31:58  <jgi>tjfontaine: are you cleaning up the jobs workspaces? I can do that too (except maybe on the Mac agent, to which I think I don’t have access)
00:32:14  <tjfontaine>yes I can clean it up
00:32:24  <tjfontaine>jgi: it takes some special care
00:32:32  <jgi>tjfontaine: ok
00:32:32  <tjfontaine>but you tell me which ones you want to tackle and I'll do the others
00:32:55  <jgi>tjfontaine: I’ll clean them all except the Mac agent
00:32:58  <tjfontaine>ok
00:33:07  <jgi>tjfontaine: If I have some trouble with the Windows agents I’ll let you know
00:33:22  <othiym23>tjfontaine: that looks like a bug to me -- looks like the test is making an npm tarball from the checked-out repo with some sort of big-ass file (tm) in there
00:33:27  <othiym23>a log file, maybe?
00:34:15  <othiym23>it may make sense to add a git cleanup -af between runs, but I don't know what else that would do to the repo / jenkins
00:34:24  <tjfontaine>othiym23: I didn't really unpack it, but quota for that container is 150GB, so unless it was grabbing /dev/urandom
00:34:56  <tjfontaine>but there's only ~5GB otherwise used on this zone
00:35:02  <othiym23>tjfontaine: I believe that test just tars up what's in the npm directory and puts it in a tmpdir to unpack it and make sure it's still installable
00:35:13  <othiym23>is tmpdir set inside the npm directory?
00:35:34  <othiym23>that could get exciting
00:35:50  * avalanche123quit (Remote host closed the connection)
00:35:59  <tjfontaine>othiym23: we'll have jgi reproduce on an alternate slave -- for now I just want to unblock builds :)
00:36:13  <tjfontaine>jgi: mac slave doesn't need fixed
00:36:13  <othiym23>I did recently change the tests so that they all use a local cache rather than the user's cache (for obvious reasons)
00:36:21  <tjfontaine>nod
00:36:25  <jgi>tjfontaine: thanks
00:36:29  <othiym23>cool, if it turns out to be an npm bug lmk
00:36:37  <othiym23>jgi: sorry if my stuff broke yr builds :/
00:36:42  * avalanche123joined
00:37:06  <jgi>othiym23: It’s probably my code that is broken :)
00:37:13  <tjfontaine>confluence of events :)
00:37:15  <jgi>othiym23: but thank you very much for looking into it
00:39:33  <othiym23>the ironic thing is that the relevant changes were made to make the tests closer to idempotent
00:40:54  <tjfontaine>dear god, I hate jenkins every day
00:41:04  * avalanche123quit (Ping timeout: 255 seconds)
00:46:02  <Wraithan>tjfontaine: our jenkins setup at NR is a nightmare
00:46:17  <Wraithan>same jenkins instance for 90% of teams
00:46:34  <tjfontaine>dear god, sympathies to the person responsible for maintaining it
00:46:39  <Wraithan>so glad I don't maintain that
00:47:15  <Wraithan>yeah, he's out on parental leave, even worse for the person he trained to take over for a month... but she knew what the mack truck she stepped in front of looked like ahead of time at least
00:47:41  <Wraithan>And some of the QA folks help maintain it
00:47:42  <tjfontaine>she probably got a pretty good view
00:48:00  <tjfontaine>the jenkins people are so against a db
00:48:05  <tjfontaine>but ship just about everything else with it
00:48:17  <othiym23>well, databases are confusing
00:48:17  <Wraithan>Every couple days 'jenkins is freaking out, rebooting the master at x:xx'
00:48:21  <othiym23>XML files are plain text!
00:48:28  * avalanche123joined
00:48:46  <chrisdickinson>tjfontaine: okay, phew, this should do it: https://github.com/joyent/node/pull/8750 + https://github.com/chrisdickinson/node/commit/0cdee30f06e2e66011051f3d5ba938d67ce131bd
00:49:07  <chrisdickinson>(sorry it took so long!)
00:49:20  <chrisdickinson>also, `make lint` doesn't pick up explicit globals :|
00:49:27  <tjfontaine>chrisdickinson: don't worry, it's not a race ;)
00:49:30  <Wraithan>tjfontaine: some QA folks are looking into the jenkins mesos plugin and possibly using that to organize jobs better so we stop DOSing our CI serers
00:50:20  <tjfontaine>Wraithan: first thing I realized about manta compute model was that it was 100% the way I want to manage my CI -- it's just not built to do multi-platform currently
00:50:21  <Wraithan>but that has to wait for dude to get back from paternity leave
00:50:31  * ijrothquit (Quit: Leaving.)
00:51:17  <Wraithan>tjfontaine: yeah the multiplatform is hard. Between .NET needing windows, and PHP/Java running on every distro *nix that has ever existed, there is so many problems
00:52:01  <tjfontaine>chrisdickinson: I'm still +1 on this, but I do have a small existential question
00:52:20  <tjfontaine>chrisdickinson: and I know you didn't do this part, but it's the thing I'm thinking about at the moment
00:52:58  <tjfontaine>chrisdickinson: splitPath is now "public"
00:54:07  <chrisdickinson>tjfontaine: ah, yes.
00:54:28  <jgi>tjfontaine: I cleaned up ubuntu, smartos and windows agents
00:54:29  <chrisdickinson>i'm going to make that private again.
00:54:56  <tjfontaine>chrisdickinson: thanks, other than that I'm +1, if jgi is cool lets ship this mother
00:55:05  <tjfontaine>I'll be back online in a bit though
00:55:43  <jgi>tjfontaine, chrisdickinson: cool regarding the path PR?
00:56:57  * ijrothjoined
00:58:47  <chrisdickinson>jgi: splitPath is now win32SplitPath and posixSplitPath; neither is exported: https://github.com/chrisdickinson/node/commit/8468714a1678b011bebc8dfad09a0049538d5a92
00:58:54  * ijrothquit (Client Quit)
00:59:19  <chrisdickinson>if that looks good I can land 'em
00:59:50  * avalanche123quit (Remote host closed the connection)
00:59:59  * ijrothjoined
01:03:10  * avalanche123joined
01:03:19  * avalanche123quit (Remote host closed the connection)
01:03:56  <jgi>chrisdickinson, tjfontaine: to be honest I haven’t looked at https://github.com/chrisdickinson/node/commit/0cdee30f06e2e66011051f3d5ba938d67ce131bd
01:04:47  <jgi>chrisdickinson, tjfontaine: and I haven’t looked at https://github.com/joyent/node/pull/8750 either
01:05:14  <chrisdickinson>ah, cool -- the first commit is the path-platform stuff
01:05:30  * ijrothquit (Quit: Leaving.)
01:05:33  <chrisdickinson>the second commit adds format and parse, and makes splitPath private
01:08:17  * ijrothjoined
01:10:16  <chrisdickinson>(& thanks to the content-addressable nature of git, https://github.com/chrisdickinson/node/commit/8468714a1678b011bebc8dfad09a0049538d5a92 is now the second commit)
01:13:15  * ijrothquit (Quit: Leaving.)
01:14:48  <jgi>chrisdickinson: why don’t we test for edge cases like null in test/simple/test-path-parse-format.js?
01:16:37  <chrisdickinson>jgi: that's a good point.
01:19:57  * ijrothjoined
01:20:39  * kazuponjoined
01:20:47  <jgi>chrisdickinson: I made other comments on GitHub
01:20:52  <chrisdickinson>rad, thanks!
01:31:30  * abraxas__joined
01:36:02  * abraxas__quit (Ping timeout: 250 seconds)
01:38:54  * abraxas__joined
01:42:32  * Ralithquit (Ping timeout: 250 seconds)
01:50:20  <chrisdickinson>jgi: cool, updated: https://github.com/joyent/node/pull/8750/files
01:54:14  <jgi>chrisdickinson: I like it! :)
01:57:05  * dap_quit (Quit: Leaving.)
01:59:42  * avalanche123joined
02:03:47  * dshaw_joined
02:06:20  * Ralithjoined
02:09:05  * kriskowalquit (Quit: kriskowal)
02:09:51  * ijrothquit (Quit: Leaving.)
02:11:52  * kriskowaljoined
02:26:19  <jgi>chrisdickinson: taking off, please let me know if you need anything from me, but I’m +1 on your changes too
02:26:47  * Ldxngx_quit (Quit: http://www.kiwiirc.com/ - A hand crafted IRC client)
02:27:57  * jgiquit (Quit: jgi)
02:31:03  * avalanche123quit (Remote host closed the connection)
02:31:03  * octetcloudquit (Ping timeout: 272 seconds)
02:32:18  * kriskowalquit (Quit: kriskowal)
02:34:16  * a_le_quit (Ping timeout: 256 seconds)
02:36:28  * kriskowaljoined
02:36:40  * thlorenzquit (Remote host closed the connection)
02:37:15  * thlorenzjoined
02:37:39  * kriskowalquit (Client Quit)
02:38:18  * a_lejoined
02:41:56  * thlorenzquit (Ping timeout: 265 seconds)
02:59:26  * thlorenzjoined
03:04:52  * dshaw_quit (Ping timeout: 256 seconds)
03:12:24  * wolfeidau_changed nick to wolfeidau
03:13:45  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
03:16:50  * janjongboomjoined
03:21:46  * tjkrusinskijoined
03:31:36  * avalanche123joined
03:34:37  * inolenquit (Ping timeout: 240 seconds)
03:37:53  * avalanche123quit (Ping timeout: 240 seconds)
03:51:26  * Fishrock123quit (Quit: Leaving...)
03:52:37  * thlorenzquit (Remote host closed the connection)
03:52:52  * thlorenzjoined
03:54:01  * kazuponquit (Remote host closed the connection)
04:00:46  * rmgquit (Remote host closed the connection)
04:06:07  * Left_Turnquit (Remote host closed the connection)
04:19:07  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
04:21:00  * brsonquit (Quit: leaving)
04:24:24  * piscisaureusquit (Ping timeout: 265 seconds)
04:26:23  * kazuponjoined
04:28:13  * bradleymeckjoined
04:33:27  * janjongboomjoined
04:38:45  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
04:40:22  * janjongboomjoined
04:43:33  * janjongboomquit (Client Quit)
04:49:37  * AlexisMochajoined
05:18:04  * ijrothjoined
05:22:09  * seishunjoined
05:32:35  * ijrothquit (Quit: Leaving.)
05:32:40  * bradleymeckquit (Quit: bradleymeck)
05:33:45  * ijrothjoined
05:34:03  * ijrothquit (Client Quit)
06:01:48  * AlexisMochaquit (Ping timeout: 244 seconds)
06:03:37  * kazuponquit (Remote host closed the connection)
06:04:23  * kazuponjoined
06:14:20  * ijrothjoined
06:18:29  * dshaw_joined
06:25:53  * avalanche123joined
06:26:01  * avalanche123quit (Remote host closed the connection)
06:26:11  * avalanche123joined
06:27:35  * avalanche123quit (Remote host closed the connection)
06:32:36  * seishunquit (Ping timeout: 255 seconds)
06:34:55  * stagasjoined
06:36:51  * AlexisMochajoined
06:39:44  * ijroth1joined
06:42:46  * ijrothquit (Ping timeout: 258 seconds)
06:50:00  * avalanche123joined
06:51:24  * avalanche123quit (Remote host closed the connection)
06:51:25  * thlorenzquit (Remote host closed the connection)
06:52:01  * thlorenzjoined
06:56:22  * thlorenzquit (Ping timeout: 255 seconds)
07:11:09  * kriskowaljoined
07:15:48  * dshaw_quit (Quit: Leaving.)
07:17:14  * toothrotquit (Read error: Connection reset by peer)
07:22:03  * ijroth1quit (Quit: Leaving.)
07:22:09  * SergeiRNDjoined
07:22:13  * thlorenzjoined
07:29:16  * ijrothjoined
07:38:12  * ijrothquit (Quit: Leaving.)
07:41:36  * stagasquit (Quit: Bye)
07:42:05  * a_lequit (Remote host closed the connection)
07:44:17  * Ldxngx_joined
07:44:17  * Ldxngx_quit (Client Quit)
07:44:37  * toothrotjoined
07:49:02  * AlexisMochaquit (Ping timeout: 245 seconds)
07:51:48  * avalanche123joined
07:52:57  * Raynosquit (Ping timeout: 240 seconds)
07:54:33  * Ldxngx_joined
07:55:49  * Raynos_joined
07:56:17  * avalanche123quit (Ping timeout: 255 seconds)
08:17:17  * rvaggquit (Ping timeout: 240 seconds)
08:17:23  * cjbquit (Ping timeout: 264 seconds)
08:18:01  * rendarjoined
08:18:18  * rvaggjoined
08:26:12  * ijrothjoined
08:36:28  * iarnajoined
08:41:22  * thlorenzquit (Remote host closed the connection)
08:41:59  * thlorenzjoined
08:46:20  * thlorenzquit (Ping timeout: 250 seconds)
08:57:55  * roxlujoined
09:03:59  * iarnaquit (Remote host closed the connection)
09:06:34  * iarnajoined
09:08:24  * iarnaquit (Remote host closed the connection)
09:10:58  * iarnajoined
09:14:57  * ijrothquit (Quit: Leaving.)
09:15:36  * ijrothjoined
09:40:24  * iarnaquit (Read error: Connection reset by peer)
09:40:53  * iarnajoined
10:04:01  * iarna_joined
10:04:25  * iarnaquit (Read error: Connection reset by peer)
10:10:11  * iarna_quit (Read error: Connection reset by peer)
10:10:24  * iarnajoined
10:20:22  * iarnaquit (Remote host closed the connection)
10:57:57  * SergeiRNDquit (Quit: Leaving.)
11:08:47  * kazuponquit (Remote host closed the connection)
11:09:28  * kazuponjoined
11:13:23  * kazuponquit (Ping timeout: 240 seconds)
11:24:03  * abraxas__quit (Remote host closed the connection)
11:24:43  * abraxas__joined
11:29:09  * abraxas__quit (Ping timeout: 255 seconds)
11:32:38  * kvanbjoined
11:32:47  * kvanbpart
12:01:06  * SergeiRNDjoined
12:04:26  * chris_99joined
12:09:52  * Left_Turnjoined
12:12:10  * piscisaureusjoined
12:16:45  * iarnajoined
12:27:50  * AlexisMochajoined
12:32:00  * avalanche123joined
12:37:05  * avalanche123quit (Ping timeout: 264 seconds)
12:41:15  * SergeiRNDquit (Quit: Leaving.)
12:46:45  * iarna_joined
12:47:22  * iarnaquit (Read error: Connection reset by peer)
13:13:09  * abraxas__joined
13:18:00  * abraxas__quit (Ping timeout: 256 seconds)
13:21:17  * stagasjoined
13:24:51  * iarnajoined
13:25:09  * iarna_quit (Read error: Connection reset by peer)
13:48:15  * roxluquit (Read error: Connection reset by peer)
13:50:27  * roxlujoined
13:50:35  * roxluquit (Read error: Connection reset by peer)
13:51:37  * roxlujoined
13:51:38  * roxluquit (Read error: Connection reset by peer)
13:52:47  * roxlujoined
13:52:47  * roxluquit (Read error: Connection reset by peer)
13:52:55  * bradleymeckjoined
13:53:42  * iarnaquit (Read error: Connection reset by peer)
13:54:15  * iarnajoined
13:55:22  * roxlujoined
13:55:22  * roxluquit (Read error: Connection reset by peer)
13:57:56  * roxlujoined
13:59:02  * tjkrusinskiquit (Quit: Lost terminal)
14:06:22  * Dijoined
14:10:10  * iarna_joined
14:10:31  * iarnaquit (Read error: Connection reset by peer)
14:13:12  * AvianFlujoined
14:14:48  * kazuponjoined
14:23:36  * SergeiRNDjoined
14:35:18  * kazuponquit (Remote host closed the connection)
14:42:43  * Fishrock123joined
14:43:19  * Diquit (Quit: Leaving.)
14:48:37  * kazuponjoined
15:02:01  * abraxas__joined
15:06:57  * abraxas__quit (Ping timeout: 245 seconds)
15:10:17  * lance|afkchanged nick to lanceball
15:18:05  * SergeiRNDquit (Quit: Leaving.)
15:22:17  * avalanche123joined
15:26:45  * avalanche123quit (Ping timeout: 255 seconds)
15:57:57  * brsonjoined
16:03:39  * txdv_joined
16:17:33  * FROGGS[mobile]joined
16:33:40  * chris_99quit (Remote host closed the connection)
16:38:20  * CoverSlidequit (Remote host closed the connection)
16:45:34  * stagasquit (Ping timeout: 244 seconds)
16:46:24  * cjbjoined
16:49:28  * piscisaureusquit (Ping timeout: 255 seconds)
16:50:52  * abraxas__joined
16:55:42  * abraxas__quit (Ping timeout: 245 seconds)
16:57:53  * rmgjoined
17:02:31  * kazuponquit (Remote host closed the connection)
17:04:07  * kazuponjoined
17:04:24  * iarna_quit (Remote host closed the connection)
17:04:50  * octetcloudjoined
17:05:26  * iarnajoined
17:08:00  * kriskowalquit (Quit: kriskowal)
17:08:02  * ijrothquit (Quit: Leaving.)
17:12:10  * seishunjoined
17:18:45  * dap_joined
17:18:50  * AvianFluquit (Ping timeout: 256 seconds)
17:28:19  * chris_99joined
17:35:47  * kazuponquit (Remote host closed the connection)
17:45:47  * jgijoined
17:49:40  * stagasjoined
17:49:46  * sblomquit (Read error: Connection reset by peer)
18:00:44  * AvianFlujoined
18:22:31  * a_lejoined
18:25:59  * kriskowaljoined
18:27:25  * thlorenzjoined
18:30:55  * a_lequit (Remote host closed the connection)
18:32:52  * ijrothjoined
18:33:23  * iarnaquit (Read error: Connection reset by peer)
18:33:29  * iarna_joined
18:37:06  * dshaw_joined
18:40:06  * abraxas__joined
18:40:27  <MI6>joyent/libuv: saghul created tag v1.0.0 - http://git.io/S-iTIQ
18:40:51  <MI6>joyent/libuv: Saúl Ibarra Corretgé v1.x * feb2a9e : 2014.11.21, Version 1.0.0 (Stable) (+2 more commits) - http://git.io/Ip1M6Q
18:41:21  <saghul>et voila!
18:42:57  * lanceballchanged nick to lance|afk
18:43:29  <rendar>saghul: great :)
18:44:58  * abraxas__quit (Ping timeout: 258 seconds)
18:44:58  * octetcloudquit (Ping timeout: 258 seconds)
18:46:39  <MI6>joyent/libuv: Elijah Andrews v1.x * 1560691 : readme: remove Rust from users - http://git.io/IxZVtQ
18:47:05  <MI6>joyent/libuv: Saúl Ibarra Corretgé master * 52ae456 : Merge branch 'v1.x' (+15 more commits) - http://git.io/QmkRaQ
18:50:27  * iarnajoined
18:51:17  * iarna_quit (Read error: Connection reset by peer)
18:52:27  * ijrothquit (Quit: Leaving.)
18:55:46  * iarnaquit (Read error: Connection reset by peer)
18:57:28  * avalanche123joined
18:57:37  * iarnajoined
18:58:14  <jgi>chrisdickinson, tjfontaine: just read http://logs.libuv.org/libuv/2014-11-19#21:37:33.982
18:58:43  <jgi>chrisdickinson, tjfontaine: indeed, it is in my opinion easier to create a DOS attack if we land https://github.com/joyent/node/pull/8751
19:00:22  * dshaw_quit (Quit: Leaving.)
19:00:53  * avalanche123quit (Remote host closed the connection)
19:01:07  * avalanche123joined
19:01:38  <jgi>chrisdickinson, tjfontaine: I don’t have a clear picture of how the poor performance of _unrefActive affects Node.js users today. The only user of Node.js I talked to who was affected by this issue is the author of this thread: https://groups.google.com/forum/#!searchin/nodejs/_unrefActive/nodejs/Uc-0BOCicyU/9UcFbcBsdK4J
19:02:35  * piscisaureusjoined
19:02:40  * AvianFluquit (Ping timeout: 255 seconds)
19:03:44  <jgi>chrisdickinson, tjfontaine: for him, it seemed that his tests showed that https://github.com/joyent/node/pull/8751 solved his problems with high CPU loads, but I don’t know if and how it affects other users
19:04:06  <jgi>chrisdickinson, tjfontaine: there’s also more information about his use case here: https://github.com/joyent/node/issues/6447
19:04:08  * dshaw_joined
19:05:14  * iarna_joined
19:05:14  * iarnaquit (Read error: Connection reset by peer)
19:05:16  <jgi>chrisdickinson, tjfontaine: having said that, it is also certainly possible to create a DOS attack with the current implementation of _unrefActive
19:14:01  * ijrothjoined
19:18:47  * iarna_changed nick to iarna
19:23:27  * octetcloudjoined
19:32:20  * iarnaquit (Read error: Connection reset by peer)
19:32:20  * iarna_joined
19:33:44  * lance|afkchanged nick to lanceball
19:35:24  * chris_99quit (Ping timeout: 264 seconds)
19:36:48  * chris_99joined
19:37:28  * Dirksonpart ("Cheers!")
19:44:09  * AlexisMochaquit (Ping timeout: 255 seconds)
19:56:34  * dap_1joined
19:58:00  * dap_quit (Ping timeout: 250 seconds)
19:58:20  * iarnajoined
19:58:53  * iarna_quit (Read error: Connection reset by peer)
20:05:31  * rendarquit (Ping timeout: 244 seconds)
20:09:08  * avalanche123quit (Remote host closed the connection)
20:11:56  * Raynos_changed nick to Raynos
20:11:57  * rendarjoined
20:12:43  * avalanche123joined
20:18:35  * dap_1quit (Quit: Leaving.)
20:19:53  * jgiquit (Quit: jgi)
20:21:06  * Ldxngx_quit (Quit: http://www.kiwiirc.com/ - A hand crafted IRC client)
20:23:45  * avalanche123quit (Remote host closed the connection)
20:27:03  * a_lejoined
20:28:54  * iarna_joined
20:29:03  * abraxas__joined
20:29:19  * iarnaquit (Read error: Connection reset by peer)
20:33:27  * abraxas__quit (Ping timeout: 258 seconds)
20:36:05  * avalanche123joined
20:39:55  * dap_joined
20:43:42  * avalanch_joined
20:46:29  * avalanche123quit (Ping timeout: 258 seconds)
21:04:58  * ijrothquit (Quit: Leaving.)
21:05:20  * avalanch_quit (Remote host closed the connection)
21:06:31  * dshaw_quit (Quit: Leaving.)
21:06:52  * avalanche123joined
21:07:02  * avalanche123quit (Remote host closed the connection)
21:07:07  * avalanch_joined
21:07:16  * ijrothjoined
21:08:15  * stagasquit (Ping timeout: 272 seconds)
21:09:07  * AvianFlujoined
21:15:36  * ijrothquit (Quit: Leaving.)
21:17:13  * Ralithquit (Ping timeout: 255 seconds)
21:19:06  * Left_Turnquit (Ping timeout: 255 seconds)
21:20:35  * iarna_quit (Read error: Connection reset by peer)
21:20:49  * iarnajoined
21:33:45  * ijrothjoined
21:34:52  * iarna_joined
21:35:20  * iarnaquit (Read error: Connection reset by peer)
21:35:49  * jgijoined
21:41:48  * iarna_quit (Read error: Connection reset by peer)
21:42:13  * ijrothquit (Quit: Leaving.)
21:43:34  * skebciojoined
21:44:51  * iarnajoined
21:46:47  * FROGGS[mobile]quit (Remote host closed the connection)
21:47:32  * ijrothjoined
21:48:42  * Ralithjoined
21:49:51  * ijrothquit (Client Quit)
21:50:55  * AvianFluquit (Ping timeout: 244 seconds)
21:54:03  * iarnaquit (Read error: Connection reset by peer)
21:54:07  * iarna_joined
21:56:28  * ijrothjoined
22:02:03  * ijrothquit (Quit: Leaving.)
22:02:38  * ijrothjoined
22:03:35  * Fishrock123quit (Remote host closed the connection)
22:03:55  * lanceballchanged nick to lance|afk
22:04:07  * Fishrock123joined
22:05:33  * ijrothquit (Client Quit)
22:05:48  * ijrothjoined
22:05:55  * roxlupart
22:08:36  * Fishrock123quit (Ping timeout: 255 seconds)
22:09:28  * iarnajoined
22:09:38  * iarna_quit (Read error: Connection reset by peer)
22:11:03  * stagasjoined
22:13:04  * Left_Turnjoined
22:15:09  * ijrothquit (Quit: Leaving.)
22:17:11  * iarnaquit (Remote host closed the connection)
22:17:31  * abraxas__joined
22:18:41  * iarnajoined
22:22:26  * abraxas__quit (Ping timeout: 244 seconds)
22:32:17  * Fishrock123joined
22:43:17  * octetcloudquit (Ping timeout: 240 seconds)
22:44:11  * avalanch_quit (Remote host closed the connection)
22:44:21  * iarnaquit (Read error: Connection reset by peer)
22:44:50  * iarnajoined
22:45:47  * ijrothjoined
22:50:44  * ijrothquit (Quit: Leaving.)
22:51:00  * octetcloudjoined
22:51:04  * ijrothjoined
22:54:11  * hueniversequit (Read error: Connection reset by peer)
22:55:39  * iarnaquit (Read error: Connection reset by peer)
22:56:07  * avalanche123joined
22:56:16  * iarnajoined
23:00:33  * ijrothquit (Quit: Leaving.)
23:03:45  * ijrothjoined
23:08:38  * stagas_joined
23:10:47  <chrisdickinson>jgi: hey! thanks for asking for more tests, it uncovered a bug. updated: https://github.com/joyent/node/pull/8750
23:11:31  * stagasquit (Ping timeout: 255 seconds)
23:11:33  * stagas_changed nick to stagas
23:11:33  <jgi>chrisdickinson: great, thank you very much for taking the time to go back to it
23:11:57  * seishunquit (Ping timeout: 240 seconds)
23:11:57  * importantshockquit (Remote host closed the connection)
23:12:23  <jgi>chrisdickinson: looking at it now
23:15:48  <jgi>chrisdickinson: added one comment, otherwise I like it better :)
23:17:53  <chrisdickinson>jgi: awesome, fixed that up.
23:18:14  <chrisdickinson>if there's no dir, the parsed output.dir will be '', whereas dirname would show '.'.
23:18:55  <chrisdickinson>(the reason to keep the empty string in path.parse dir output is so that we don't lose information necessary to rebuild the path into a string)
23:22:14  <jgi>chrisdickinson: I’m not sure I understand, why would dirname return ‘.’ for a path that has no directory?
23:22:25  <chrisdickinson>path.dirname('file') === '.'
23:22:35  * iarna_joined
23:22:53  <chrisdickinson>(it's implicitly in the current directory)
23:23:09  * iarnaquit (Read error: Connection reset by peer)
23:23:32  <chrisdickinson>but format/parse needs to retain data -- so path.format(path.parse('file')) === 'file', while path.format(path.parse('./file')) === './file'
23:25:10  * rendarquit
23:26:04  * kkaefer_changed nick to kkaefer
23:29:29  <jgi>chrisdickinson: ok, I thought path.parse was using path.dirname, but it’s not the case, hence the confusion
23:29:37  <jgi>chrisdickinson: sorry, lots of context switching
23:29:57  <chrisdickinson>no worries!
23:37:18  * bradleymeckquit (Quit: bradleymeck)
23:39:26  <MI6>joyent/node: Steve Sharp v0.12 * 4dc8b26 : doc: correct broken link in net.markdown - http://git.io/9RIEhQ
23:42:54  * iarna_quit (Read error: Connection reset by peer)
23:43:24  * iarnajoined
23:51:06  * chris_99quit (Quit: Ex-Chat)
23:57:01  * Fishrock123quit (Quit: Leaving...)
23:58:22  * ijrothquit (Quit: Leaving.)