00:00:00  * ircretaryquit (Remote host closed the connection)
00:00:08  * ircretaryjoined
00:00:20  * mikealquit (Quit: Leaving.)
00:04:46  * eugenewarejoined
00:06:14  * mcavagequit (Remote host closed the connection)
00:08:49  <trevnorris>tjfontaine: here you go. feel free to rip into it: https://github.com/joyent/node/pull/7145
00:09:47  * eugenewarequit (Remote host closed the connection)
00:10:21  * eugenewarejoined
00:11:49  * morganhelockerjoined
00:14:54  * eugenewarequit (Ping timeout: 252 seconds)
00:15:27  * euoiaquit (Ping timeout: 272 seconds)
00:16:16  * dap_joined
00:16:16  * dap_1quit (Read error: Connection reset by peer)
00:20:28  * mikealjoined
00:21:11  * mcavagejoined
00:22:11  * calvinfo1joined
00:24:14  * calvinfoquit (Ping timeout: 260 seconds)
00:26:37  <tjfontaine>trevnorris: a very quick pass, things look ok, I may suggest we change tracing.PROVIDERS to tracing.ASYNC_PROVIDERS because I worry about the confusion for the dynamic tracing stuff
00:26:52  <trevnorris>sure. that's easy enough.
00:27:53  * dshaw_quit (Ping timeout: 265 seconds)
00:27:55  * dshaw_1joined
00:31:51  <trevnorris>tjfontaine: one
00:31:56  <trevnorris>done
00:38:46  * mikealquit (Quit: Leaving.)
00:40:06  * paulfryz_joined
00:41:54  <tjfontaine>trevnorris: have you been able to investigate http://jenkins.nodejs.org/job/node-pullrequest/DESTCPU=ia32,label=osx/2017/tapTestReport/test.tap-20/
00:42:36  <tjfontaine>seems to only be failing on osx
00:43:12  * trevnorriswaiting for slow internet to load...
00:43:57  * \toothrotchanged nick to toothrot
00:44:37  * paulfryz_quit (Ping timeout: 265 seconds)
00:45:01  <trevnorris>tjfontaine: the only way that could happen is if the setImmediate(process.exit) is running before the callback from the running server is called.
00:45:59  <trevnorris>wait. wtf. one sec.
00:47:08  * paulfryzelquit (Remote host closed the connection)
00:47:57  * kenperkins_joined
00:48:20  <trevnorris>oy. damn it. the AL isn't being removed before the check is run.
00:48:46  * dap_quit (Quit: Leaving.)
00:48:48  * nrajlichjoined
00:49:15  * mikolalysenkojoined
00:49:26  * txdvquit (Ping timeout: 264 seconds)
00:49:27  <trevnorris>...........
00:49:49  * octetclo1joined
00:49:59  * txdvjoined
00:52:28  <tjfontaine>trevnorris: hm?
00:53:10  * benviequit (Ping timeout: 259 seconds)
00:53:11  <trevnorris>minute. think I was getting overzelous in my checks
00:55:12  * euoiajoined
00:55:54  * ircretaryquit (*.net *.split)
00:55:54  * TooTallNatequit (*.net *.split)
00:55:54  * janjongboomquit (*.net *.split)
00:55:54  * mikolaly1enkoquit (*.net *.split)
00:55:54  * toothrotquit (*.net *.split)
00:55:54  * kenperkinsquit (*.net *.split)
00:55:54  * octetcloudquit (*.net *.split)
00:58:00  * janjongboomjoined
01:00:36  * dap_joined
01:01:40  <trevnorris>tjfontaine: for some reason the AL isn't being removed completely. so the error checkers themselves are actually being caught.
01:01:56  <trevnorris>going to track down why this is happening.
01:02:01  * janjongboomquit (*.net *.split)
01:02:29  * janjongboomjoined
01:04:19  <tjfontaine>trevnorris: I may land it, just so I can get it in and then we can land a fix later
01:04:38  <tjfontaine>trevnorris: still doing the real review atm
01:04:43  <trevnorris>ok
01:05:48  * kazuponjoined
01:09:48  * toothrjoined
01:12:37  * octetclo1quit (Ping timeout: 248 seconds)
01:12:48  * toothrchanged nick to toothrot
01:14:20  * AWintermanquit (Remote host closed the connection)
01:15:06  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
01:17:25  <trevnorris>tjfontaine: the issue is that every new instantiation receives a pointer to the AL object. when you remove it, it's removed from the active queue, but not removed from all the object for which it's been attached.
01:17:43  <trevnorris>and there's a timer in the call stack that has it attached and is intercepting the errors
01:18:03  <trevnorris>still don't have a full grasp on it, but this makes removing AL's pretty useless right now
01:19:46  * Kakera_quit (Read error: Operation timed out)
01:19:57  <trevnorris>tjfontaine: hey, um. was the debugger removed recently or something?
01:20:05  <tjfontaine>no?
01:21:59  <trevnorris>tjfontaine: this is what i'm seeing when typing > repl when debugging from the AL error handler: https://gist.github.com/trevnorris/9127030
01:22:25  <tjfontaine>fair enough, broken merge ;)
01:23:00  * kazuponquit (Remote host closed the connection)
01:23:17  <trevnorris>ok. dinner time. bbiab
01:23:19  * trevnorris&
01:23:19  <LOUDBOT_>AND THERE WERE SEVEN!
01:23:28  * kazuponjoined
01:24:06  * kazupon_joined
01:24:24  * kazuponquit (Read error: Connection reset by peer)
01:25:29  <tjfontaine>trevnorris: I'm not reproducing this atm
01:25:50  <tjfontaine>oh there it is
01:27:42  * Ralithquit (Ping timeout: 260 seconds)
01:31:39  * dap_quit (Quit: Leaving.)
01:32:56  * abraxasjoined
01:33:29  * mcavagequit
01:34:30  * jmar777quit (Remote host closed the connection)
01:35:01  <tjfontaine>this is absurd
01:36:08  <tjfontaine>trevnorris: https://github.com/joyent/node/blob/master/lib/_debugger.js#L788-L828
01:36:42  * nrajlichquit (Quit: Computer has gone to sleep.)
01:37:35  * austoquit (Quit: austo)
01:37:35  * abraxasquit (Ping timeout: 252 seconds)
01:37:52  * kevinsimperquit (Remote host closed the connection)
01:40:48  * paulfryzeljoined
01:42:21  * piscisaureusquit (Quit: ~ Trillian Astra - www.trillian.im ~)
01:44:44  * AWintermanjoined
01:48:17  * c4milojoined
01:48:59  * AWintermanquit (Ping timeout: 252 seconds)
01:50:36  * abraxasjoined
01:51:10  * c4miloquit (Read error: No route to host)
01:51:26  * c4milojoined
01:53:39  <tjfontaine>trevnorris: ok got it, it's silly
01:54:24  * burlakquit (Ping timeout: 265 seconds)
01:55:34  * dap_joined
01:55:35  * c4milo_joined
01:56:00  * burlakjoined
01:56:43  * lgierthjoined
01:56:59  * Ralithjoined
01:57:39  * c4miloquit (Ping timeout: 252 seconds)
01:59:03  * rosskquit
02:03:37  * paulfryzelquit (Remote host closed the connection)
02:10:44  * dap_quit (Quit: Leaving.)
02:15:04  * AWintermanjoined
02:16:49  * dsantiagojoined
02:18:42  * paulfryzeljoined
02:22:57  * paulfryzelquit (Ping timeout: 251 seconds)
02:24:39  * AWintermanquit (Ping timeout: 272 seconds)
02:25:42  * brunklejoined
02:28:03  * rmgquit (Remote host closed the connection)
02:29:38  * asdasdasdasdasd_joined
02:33:08  * lgierthquit (Ping timeout: 252 seconds)
02:39:51  * brunklequit (Ping timeout: 260 seconds)
02:45:25  * brunklejoined
02:48:40  * dshaw_1quit (Read error: Connection reset by peer)
02:51:30  * AWintermanjoined
02:51:55  * c4milo_quit (Remote host closed the connection)
02:55:14  * dshaw_joined
02:58:39  * rmgjoined
02:59:32  * euoiaquit (Ping timeout: 252 seconds)
03:01:53  * AWintermanquit (Ping timeout: 265 seconds)
03:03:29  * calvinfo1quit (Quit: Leaving.)
03:03:43  * calvinfojoined
03:04:34  * paulfryzeljoined
03:09:18  * paulfryzelquit (Ping timeout: 252 seconds)
03:19:28  * paulfryzeljoined
03:24:00  * paulfryzelquit (Ping timeout: 252 seconds)
03:24:25  * kazupon_quit (Remote host closed the connection)
03:26:36  * dap_joined
03:27:10  * dap_quit (Client Quit)
03:28:08  * AWintermanjoined
03:28:44  * morganhelockerquit (Quit: morganhelocker)
03:29:45  * eugenewarejoined
03:33:34  * eugenewarequit (Remote host closed the connection)
03:34:08  * eugenewarejoined
03:34:16  * eugenewarequit (Read error: Connection reset by peer)
03:34:49  * eugenewarejoined
03:34:53  * eugenewarequit (Remote host closed the connection)
03:35:20  * eugenewarejoined
03:36:01  * eugenewarequit (Remote host closed the connection)
03:36:37  * eugenewarejoined
03:38:35  * kevinsimperjoined
03:38:35  * AWintermanquit (Ping timeout: 252 seconds)
03:41:24  * kevinsimperquit (Read error: Operation timed out)
03:53:07  * c4milojoined
03:57:33  * c4miloquit (Ping timeout: 252 seconds)
04:05:16  * AWintermanjoined
04:05:21  * paulfryzeljoined
04:06:26  * kazuponjoined
04:08:54  * asdasdasdasdasd_quit (Read error: Connection reset by peer)
04:10:02  * paulfryzelquit (Ping timeout: 265 seconds)
04:15:11  * rmgquit (Remote host closed the connection)
04:15:26  * rmgjoined
04:15:33  * AWintermanquit (Ping timeout: 248 seconds)
04:20:09  * paulfryzeljoined
04:22:17  * brunklequit (Quit: brunkle)
04:24:03  * sh1mmerquit (Quit: sh1mmer)
04:24:30  * paulfryzelquit (Ping timeout: 252 seconds)
04:25:49  * rmgquit (Remote host closed the connection)
04:26:53  * abraxasquit (Remote host closed the connection)
04:28:07  * kazuponquit (Remote host closed the connection)
04:28:16  * kazuponjoined
04:40:50  * paulfryzeljoined
04:42:27  * AWintermanjoined
04:42:33  * brson_joined
04:42:48  * brson_quit (Client Quit)
04:43:04  * brson_joined
04:45:51  * brsonquit (Ping timeout: 260 seconds)
04:45:53  * paulfryzelquit (Ping timeout: 272 seconds)
04:47:11  * c4milojoined
04:50:46  * lgierthjoined
04:50:48  * dshaw_quit (Quit: Leaving.)
04:51:00  * calvinfoquit (Quit: Leaving.)
04:52:00  * c4miloquit (Ping timeout: 252 seconds)
04:53:02  * AWintermanquit (Ping timeout: 260 seconds)
05:04:00  * defunctzombie_zzchanged nick to defunctzombie
05:07:39  * rmgjoined
05:08:45  * rmgquit (Remote host closed the connection)
05:12:16  * kpdeckerquit (Quit: Leaving.)
05:14:08  * AvianFluquit (Remote host closed the connection)
05:17:17  * dsantiagoquit (Quit: Computer has gone to sleep.)
05:19:55  * AWintermanjoined
05:21:08  * paulfryzeljoined
05:22:24  * dsantiagojoined
05:23:46  * TooTallNatejoined
05:24:20  * thlorenzjoined
05:25:33  * paulfryzelquit (Ping timeout: 252 seconds)
05:31:20  * AWintermanquit (Ping timeout: 252 seconds)
05:31:34  * thlorenzquit (Remote host closed the connection)
05:32:13  * defunctzombiechanged nick to defunctzombie_zz
05:34:41  * abraxasjoined
05:37:01  * kpdeckerjoined
05:45:35  * abraxasquit (Remote host closed the connection)
05:46:03  * dshaw_joined
05:48:10  * c4milojoined
05:50:45  * dshaw_quit (Ping timeout: 265 seconds)
05:51:07  * abraxasjoined
05:51:31  * calvinfojoined
05:52:11  * calvinfo1joined
05:52:11  * calvinfoquit (Read error: Connection reset by peer)
05:53:03  * c4miloquit (Ping timeout: 252 seconds)
05:53:03  * calvinfo1quit (Read error: Connection reset by peer)
05:53:06  * calvinfojoined
05:53:58  * calvinfo1joined
05:53:59  * calvinfoquit (Read error: Connection reset by peer)
05:54:56  * calvinfojoined
05:54:56  * calvinfo1quit (Read error: Connection reset by peer)
05:57:28  * AWintermanjoined
05:58:48  * m76joined
05:59:45  * calvinfoquit (Ping timeout: 265 seconds)
06:08:06  * AWintermanquit (Ping timeout: 252 seconds)
06:11:11  * calvinfojoined
06:11:46  * TooTallNatequit (Quit: ["Textual IRC Client: www.textualapp.com"])
06:21:46  * paulfryzeljoined
06:25:14  * mikolalysenkoquit (Ping timeout: 252 seconds)
06:26:03  * paulfryzelquit (Ping timeout: 252 seconds)
06:34:59  * AWintermanjoined
06:37:12  * mikealjoined
06:42:30  * paulfryzeljoined
06:46:51  * AWintermanquit (Ping timeout: 272 seconds)
06:47:07  * paulfryzelquit (Ping timeout: 265 seconds)
06:47:15  * sinclair|workjoined
06:49:23  * c4milojoined
06:50:08  * mikolalysenkojoined
06:51:52  * kpdeckerquit (Quit: Leaving.)
06:52:40  * brson_quit (Ping timeout: 252 seconds)
06:53:41  * calvinfoquit (Quit: Leaving.)
06:54:22  * c4miloquit (Ping timeout: 265 seconds)
07:12:34  * AWintermanjoined
07:14:34  * AWintermanquit (Remote host closed the connection)
07:22:26  * paulfryzeljoined
07:27:06  * paulfryzelquit (Ping timeout: 251 seconds)
07:29:19  * kazuponquit (Remote host closed the connection)
07:30:48  * lgierthquit (Quit: Ex-Chat)
07:33:35  * kazupon_joined
07:40:15  * kevinsimperjoined
07:41:28  * hoelzroquit (Ping timeout: 245 seconds)
07:41:53  * kevinsimperquit (Read error: Connection reset by peer)
07:42:02  * kpdeckerjoined
07:42:15  * hoelzrojoined
07:43:16  * paulfryzeljoined
07:44:29  * kazupon_quit (Remote host closed the connection)
07:45:40  * kpdeckerquit (Client Quit)
07:47:30  * dshaw_joined
07:48:01  * paulfryzelquit (Ping timeout: 260 seconds)
07:50:26  * c4milojoined
07:51:13  * kazuponjoined
07:52:00  * janjongboomjoined
07:52:05  * dshaw_quit (Ping timeout: 265 seconds)
07:55:30  * c4miloquit (Ping timeout: 260 seconds)
07:59:33  * mikolalysenkoquit (Ping timeout: 252 seconds)
07:59:59  * kevinsimperjoined
08:01:35  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
08:15:15  * hzjoined
08:21:21  * `3E|BRBchanged nick to `3rdEden
08:23:20  * paulfryzeljoined
08:24:30  * rendarjoined
08:27:36  * paulfryzelquit (Ping timeout: 252 seconds)
08:41:14  * kpdeckerjoined
08:43:52  * paulfryzeljoined
08:47:37  <indutny>morning
08:48:14  * paulfryzelquit (Ping timeout: 252 seconds)
08:48:19  * dshaw_joined
08:49:14  * hzquit
08:51:32  * c4milojoined
08:52:59  * dshaw_quit (Ping timeout: 265 seconds)
08:53:45  <MI6>joyent/libuv: William Light master * bfba45d : linux: include grp.h for setgroups() - http://git.io/LfBNZg
08:56:11  * mikolalysenkojoined
08:56:27  * c4miloquit (Ping timeout: 252 seconds)
08:57:41  * toothrotquit (Ping timeout: 248 seconds)
09:00:35  <MI6>joyent/libuv: Saúl Ibarra Corretgé master * 787f5ff : unix, windows: add uv_loop_init and uv_loop_close - http://git.io/h92azQ
09:01:21  * mikolalysenkoquit (Read error: Operation timed out)
09:01:37  <indutny>saghul: yay!
09:01:38  <indutny>on a rave
09:01:39  <indutny>:P
09:01:55  <saghul>CLOSE ALL THE PRS!
09:01:55  <LOUDBOT_>OH FUCK OFF FROZEN OBJECT ERROR!
09:02:02  <saghul>good morning btw!
09:02:08  <indutny>yeah
09:02:09  <indutny>to you too
09:02:26  * mikolalysenkojoined
09:03:00  * daviddiasjoined
09:04:23  * janjongboomjoined
09:08:18  * mikolalysenkoquit (Ping timeout: 252 seconds)
09:09:55  <saghul>indutny: do you know why this was introduced? https://github.com/joyent/libuv/commit/92040eb7123e892261c8da71c3eedb97c00e4b88
09:10:44  * bajtosjoined
09:14:04  * abraxasquit (Remote host closed the connection)
09:16:17  * toothrjoined
09:20:40  * janjongboomquit (Ping timeout: 252 seconds)
09:21:25  * janjongboomjoined
09:24:01  * paulfryzeljoined
09:24:41  * eugenewarequit (Remote host closed the connection)
09:28:39  * paulfryzelquit (Ping timeout: 252 seconds)
09:44:43  * paulfryzeljoined
09:48:56  * dshaw_joined
09:49:53  * paulfryzelquit (Ping timeout: 272 seconds)
09:50:26  * m76quit (Read error: Connection reset by peer)
09:52:30  * c4milojoined
09:53:53  * dshaw_quit (Ping timeout: 265 seconds)
09:57:35  * c4miloquit (Ping timeout: 260 seconds)
10:03:37  * eugenewarejoined
10:04:53  * mikolalysenkojoined
10:08:40  * eugenewarequit (Ping timeout: 265 seconds)
10:09:54  * mikolalysenkoquit (Ping timeout: 260 seconds)
10:24:55  * paulfryzeljoined
10:27:48  * abraxasjoined
10:29:09  * paulfryzelquit (Ping timeout: 252 seconds)
10:36:14  * kpdeckerquit (Quit: Leaving.)
10:37:02  * abraxasquit (Remote host closed the connection)
10:41:01  * abraxasjoined
10:42:46  * abraxasquit (Remote host closed the connection)
10:45:25  * paulfryzeljoined
10:47:40  * bajtosquit (Quit: bajtos)
10:49:46  * dshaw_joined
10:50:20  * paulfryzelquit (Ping timeout: 252 seconds)
10:54:27  * dshaw_quit (Ping timeout: 252 seconds)
11:00:50  * Kakera_joined
11:05:32  * mikolalysenkojoined
11:08:47  * eugenewarejoined
11:09:18  * kenperkins_quit (Remote host closed the connection)
11:09:41  <indutny>saghul: one sec
11:09:58  * kenperkinsjoined
11:10:51  * mikolalysenkoquit (Ping timeout: 260 seconds)
11:10:57  <indutny>saghul: I have no idea
11:11:21  <indutny>I guess that's bert gaving up the slack
11:15:11  * c4milojoined
11:20:12  * c4miloquit (Ping timeout: 265 seconds)
11:24:42  <saghul>indutny: I guess I'm missing something, because the patch doesn't really do what the comment says
11:25:04  <saghul>also, it's not used in node, I have no idea where it came from
11:25:25  * bajtosjoined
11:25:30  <indutny>could you open a PR that will remove it?
11:25:32  * paulfryzeljoined
11:25:36  <indutny>and cc me and bert
11:27:34  <rendar>does libuv uses a many atomic operations?
11:30:12  * paulfryzelquit (Ping timeout: 252 seconds)
11:35:39  * bajtosquit (Quit: bajtos)
11:40:57  * bajtosjoined
11:41:39  <saghul>indutny: will do
11:41:43  <indutny>thank you
11:41:46  <saghul>rendar: some
11:41:47  <indutny>rendar: it doesn't
11:41:54  <indutny>rendar: some :)
11:42:49  <rendar>indutny: where? there are any atomic ref counters?
11:42:55  <indutny>nope
11:43:00  <indutny>I think we are using it for uv_async_t
11:45:47  * bajtosquit (Ping timeout: 272 seconds)
11:46:17  * paulfryzeljoined
11:47:07  <rendar>indutny: i see
11:49:07  * kazuponquit (Remote host closed the connection)
11:50:28  * dshaw_joined
11:50:41  * paulfryzelquit (Ping timeout: 260 seconds)
11:51:01  * m76joined
11:55:12  * dshaw_quit (Ping timeout: 265 seconds)
12:06:23  * mikolalysenkojoined
12:07:55  * eugenewarequit (Ping timeout: 252 seconds)
12:10:12  <saghul>indutny: https://github.com/joyent/libuv/pull/1135
12:10:18  <indutny>thanks
12:11:13  * mikolalysenkoquit (Ping timeout: 252 seconds)
12:11:39  <saghul>indutny: can you please take a peek at https://github.com/joyent/libuv/pull/1119
12:11:55  <saghul>IMHO it's ready to land
12:16:18  * c4milojoined
12:17:55  <indutny>hm...
12:17:59  <indutny>does it work/compile everywhere?
12:18:06  <indutny>I am not really aware of this function
12:18:31  <indutny>looks good, generally
12:21:02  * c4miloquit (Ping timeout: 260 seconds)
12:22:10  <saghul>AFAIK, yes. On windows it just fills the CPU times
12:22:34  <saghul>thanks for looking over it
12:26:32  * mikolalysenkojoined
12:27:30  * AvianFlujoined
12:28:41  * daviddiasquit (Read error: Connection reset by peer)
12:42:11  * zz_karupanerurachanged nick to karupanerura
12:43:19  * euoiajoined
12:43:32  * toothrchanged nick to toothrot
12:43:35  * abraxasjoined
12:46:59  * paulfryzeljoined
12:47:09  * karupanerurachanged nick to zz_karupanerura
12:48:23  * abraxasquit (Ping timeout: 260 seconds)
12:50:23  * m76quit (Ping timeout: 272 seconds)
12:51:10  * dshaw_joined
12:51:23  * paulfryzelquit (Ping timeout: 253 seconds)
12:55:37  * dshaw_quit (Ping timeout: 265 seconds)
12:59:44  * kazuponjoined
13:11:17  * mikolalysenkoquit (Ping timeout: 272 seconds)
13:14:17  * kazuponquit (Remote host closed the connection)
13:16:27  * m76joined
13:27:14  * paulfryzeljoined
13:31:45  * paulfryzelquit (Ping timeout: 252 seconds)
13:35:03  * Kakera_quit (Ping timeout: 252 seconds)
13:47:46  * paulfryzeljoined
13:48:28  * kazuponjoined
13:51:31  * kazuponquit (Remote host closed the connection)
13:51:58  * dshaw_joined
13:52:23  * paulfryzelquit (Ping timeout: 252 seconds)
13:52:27  * euoiaquit (Ping timeout: 252 seconds)
13:52:44  <mmalecki>hmm... is there even a slight possibility of `unref` (e.g. on a timer) being a performance problem?
13:56:10  <saghul>mmalecki: it's just a flag (at the libuv level) so I don't think so, not use how node uses them though
13:56:31  * dshaw_quit (Ping timeout: 265 seconds)
13:57:54  <mmalecki>saghul: yeah, that's what I got from the brief look at the uv code, node code seems to just call it too
13:59:26  * thlorenzjoined
14:03:02  * thlorenzquit (Remote host closed the connection)
14:07:39  * janjongboomquit (Ping timeout: 272 seconds)
14:08:48  * janjongboomjoined
14:10:28  * Kakera_joined
14:13:02  * euoiajoined
14:17:06  * mikolalysenkojoined
14:21:53  * mikolalysenkoquit (Ping timeout: 260 seconds)
14:28:03  * paulfryzeljoined
14:28:36  * daviddiasjoined
14:28:59  * daviddiasquit (Remote host closed the connection)
14:29:31  * daviddiasjoined
14:29:53  <AlexisMocha>howdy
14:32:15  * paulfryzelquit (Ping timeout: 252 seconds)
14:37:55  * jmar777joined
14:44:20  * abraxasjoined
14:46:44  * hzjoined
14:48:31  * paulfryzeljoined
14:49:02  * abraxasquit (Ping timeout: 252 seconds)
14:52:46  * dshaw_joined
14:53:09  * paulfryzelquit (Ping timeout: 252 seconds)
14:57:25  * dshaw_quit (Ping timeout: 265 seconds)
15:02:24  * kazuponjoined
15:07:11  * kazuponquit (Ping timeout: 272 seconds)
15:13:42  * calvinfojoined
15:17:10  * paulfryzeljoined
15:27:39  * calvinfoquit (Quit: Leaving.)
15:27:43  * paulfryzelquit (Read error: Connection reset by peer)
15:36:46  * paulfryzeljoined
15:38:50  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
15:39:46  * thlorenzjoined
15:43:04  * kevinsimperquit (Remote host closed the connection)
15:49:27  * thlorenzquit (Ping timeout: 260 seconds)
15:55:45  * paulfryzelquit (Read error: Connection reset by peer)
15:56:02  * paulfryzeljoined
15:58:52  * thlorenzjoined
16:00:59  * janjongboomjoined
16:12:57  * dap_joined
16:14:10  * dap_quit (Client Quit)
16:20:45  * mcavagejoined
16:22:18  * paulfryzelquit (Remote host closed the connection)
16:45:21  * abraxasjoined
16:45:32  * mikolalysenkojoined
16:46:08  * andrewrkquit (Quit: Leaving)
16:48:25  * calvinfojoined
16:50:09  * abraxasquit (Ping timeout: 252 seconds)
16:55:48  * m76quit (Ping timeout: 252 seconds)
16:57:11  * dshaw_joined
17:00:15  * kpdeckerjoined
17:00:29  <tjfontaine>yawn
17:01:09  * trevn0rrisjoined
17:01:45  <trevn0rris>tjfontaine: real quick, think I know the issue, but won't have time to test it out until lunch. i'll get back to you as soon as i'm able to try it out.
17:01:47  * trevn0rris&
17:01:48  <LOUDBOT_>VAGINA JUNCTION WHAT'S YOUR FUNCTION
17:01:58  * trevn0rrisquit (Client Quit)
17:02:05  * m76joined
17:03:17  * bajtosjoined
17:06:15  * kevinsimperjoined
17:09:49  * benviejoined
17:10:01  * calvinfoquit (Quit: Leaving.)
17:10:09  * calvinfojoined
17:13:54  * dap_joined
17:14:53  * kenperkinsquit (Remote host closed the connection)
17:15:33  * kenperkinsjoined
17:19:21  * Qardjoined
17:20:30  * m76quit (Ping timeout: 265 seconds)
17:22:57  <tjfontaine>saghul: ping
17:23:11  <saghul>pang!
17:23:29  <saghul>tjfontaine: sup?
17:23:39  <tjfontaine>saghul: you can trigger the windows builds in jenkins by pushing to a feature branch
17:23:54  <tjfontaine>saghul: if you hang out in #node-ci you will see the bot spew
17:24:17  <saghul>oh!
17:24:27  <saghul>tjfontaine: thanks, I didn't know that!
17:25:13  <tjfontaine>saghul: no problemo
17:26:20  * euoiaquit (Ping timeout: 252 seconds)
17:28:55  * m76joined
17:30:54  * octetclo1joined
17:30:59  * AWintermanjoined
17:31:49  <indutny>heya
17:31:55  <indutny>tjfontaine: almost finished node_isolate removal
17:31:59  <indutny>going to submit intermediate PR
17:32:03  <tjfontaine>indutny: ok
17:32:10  <indutny>oh god
17:32:12  <indutny>it crashes :P
17:32:15  <tjfontaine>:P
17:32:36  <tjfontaine>still more work to be done, I have a half abandoned branch of 3.24 from yesterday
17:32:51  <indutny>you better wait with it
17:32:58  * dubban_joined
17:32:59  <indutny>3.24 will be much easier with node_isolate removed
17:33:00  <tjfontaine>which was a world between making node work, and also doing the node_isolate removal
17:33:07  <indutny>yeah
17:33:17  <tjfontaine>and then I realized I had more important things to do at the time :)
17:33:39  <indutny>I started from 3.24 too
17:33:40  <indutny>:P
17:33:51  <tjfontaine>:)
17:33:59  <indutny>hahaha
17:34:14  <tjfontaine>are you movign Throw*'s to accept an isolate, or putting it into Environment?
17:34:17  * paulfryzeljoined
17:35:20  * austojoined
17:38:18  * mikealquit (Quit: Leaving.)
17:39:20  <indutny>tjfontaine: as an another commit and into Env
17:39:26  <indutny>same with Encode()/Decode()
17:39:40  <indutny>but first I need to find the commit where I broke stuff...
17:41:22  <tjfontaine>nod
17:41:49  * thlorenzquit (Remote host closed the connection)
17:42:51  * brunklejoined
17:43:33  * TooTallNatejoined
17:43:56  <indutny>tjfontaine: https://github.com/joyent/node/pull/7166
17:44:07  <indutny>tjfontaine: could you please help be with https://github.com/indutny/node/commit/5816bc0fa09220888bdba57a4075c658d97b603b ?
17:44:15  <indutny>bisect points to it
17:44:16  * mcavagequit (Remote host closed the connection)
17:44:29  <tjfontaine>TooTallNate: go ahead and land the debugger fix, I was waiting to talk to you about if .prompt should be a getter of sorts
17:44:35  <tjfontaine>indutny: looking
17:44:43  * mcavagejoined
17:44:45  * mikealjoined
17:45:00  * mcavagequit (Read error: Connection reset by peer)
17:45:16  * mcavagejoined
17:45:49  <tjfontaine>indutny: what's the bt for context?
17:45:56  <indutny>one sec
17:46:49  <tjfontaine>Things I'm always scared of is PersistentToLocal
17:46:55  <indutny>finishing https://gist.github.com/indutny/5ed6b553d9853b0c283b
17:47:31  <indutny>I guess it is something about AppendExceptionLine
17:48:03  * mikolalysenkoquit (Ping timeout: 252 seconds)
17:48:03  <tjfontaine>wow ya, that's frustrating
17:48:03  <indutny>anyway
17:48:07  <indutny>battery is low on charge again
17:48:13  <indutny>I'll try doing debug build once I'll return
17:48:18  <indutny>perhaps, it'll fail earlier
17:48:59  <tjfontaine>indutny: I'll try on smartos so I can see it in mdb
17:49:08  <tjfontaine>I'm interested to see what those JS frames are
17:49:12  <indutny>thanks
17:49:13  <MI6>joyent/node: Alexis Campailla orangemocha-testing * e4df942 : testing: testing - http://git.io/7LUQrQ
17:49:52  * mikolalysenkojoined
17:50:47  <MI6>joyent/node: Nathan Rajlich master * e746bbd : debugger: don't set the `repl.prompt` string - http://git.io/4vrZRA
17:50:49  * paulfryz_joined
17:51:26  <MI6>joyent/libuv: Oleg Efimov master * da9a2b1 : unix, windows: add uv_getrusage() function - http://git.io/4lodYQ
17:51:38  <tjfontaine>indutny: hey, what test were you running when that failed?
17:51:43  <indutny>just ./node 1
17:51:46  <tjfontaine>ok
17:51:50  <indutny>where 1 doesn't exist
17:52:00  <tjfontaine>ok, so it's probably any fatal error
17:55:18  * paulfryz_quit (Ping timeout: 265 seconds)
17:55:39  * andrewrkjoined
17:57:32  <MI6>joyent/libuv: Lars Gierth master * cd67e10 : build: update android toolchain (+1 more commits) - http://git.io/xPG-5w
17:57:45  * brunklequit (Quit: brunkle)
17:58:24  <tjfontaine>saghul: sigh, that failure is because of tests hanging
17:58:29  <tjfontaine>saghul: I haven't figured out why just yet
17:58:56  <saghul>tjfontaine: yeah, it's weird
17:59:08  <saghul>some tests do fail on windows and we know it, though
17:59:35  <saghul>I have a bastardized MacBook Pro with Windows 7 to run tests just in case ;-)
17:59:44  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
18:01:34  * brunklejoined
18:01:55  <tjfontaine>saghul: this is different though
18:02:13  <tjfontaine>saghul: I've yet to reproduce this outside the CI https://cloudup.com/igdfQyP4saH
18:03:35  * mcavagequit (Remote host closed the connection)
18:05:29  * bajtosquit (Quit: bajtos)
18:06:11  <tjfontaine>indutny:
18:06:12  <tjfontaine>frame #30: 0x000000010001c399 node_g`node::Start(argc=2, argv=0x00000001020000e0) + 185 at node.cc:3498
18:06:15  <tjfontaine> 3495 {
18:06:17  <tjfontaine> 3496 Locker locker(node_isolate);
18:06:19  <tjfontaine>seems like the culprit?
18:06:21  <tjfontaine> 3497 Environment* env =
18:06:24  <tjfontaine>-> 3498 CreateEnvironment(node_isolate, argc, argv, exec_argc, exec_argv);
18:07:26  <MI6>joyent/node: Alexis Campailla orangemocha-testing * 8c53167 : testing: testing - https://github.com/joyent/node/compare/e4df942a5d6b...8c53167d0e59
18:10:39  <saghul>tjfontaine: may some zombie process was holding onto the port?
18:10:41  * thlorenzjoined
18:10:42  <MI6>joyent/node: Alexis Campailla orangemocha-testing * 890aa55 : testing: testing2 - http://git.io/y8jk7A
18:11:09  <tjfontaine>saghul: it's possible
18:13:55  <MI6>joyent/node: Alexis Campailla orangemocha-testing * d49b2c6 : test: testingg - http://git.io/vPaY2g
18:17:08  <indutny>tjfontaine: oooh
18:17:11  <indutny>I have an idea
18:17:14  <indutny>tjfontaine: thank you
18:17:34  * janjongboomjoined
18:17:40  <indutny>oh
18:17:44  <indutny>actually no, I have not
18:18:00  <indutny>anyway
18:18:06  <indutny>I'll try stepping through it
18:20:07  <tjfontaine>indutny: ya, I got pulled into a meeting atm
18:20:11  <indutny>np
18:20:14  <indutny>thank you
18:20:17  <tjfontaine>np
18:20:17  <MI6>joyent/node: Alexis Campailla orangemocha-testing * d8f51e5 : testing: testing - http://git.io/YIdb1w
18:22:40  * euoiajoined
18:22:58  * sh1mmerjoined
18:23:02  * mikolalysenkoquit (Ping timeout: 264 seconds)
18:26:28  <AlexisMocha>tjfontaine: what do I need to do to have node-review-windows pick up my changes? Sometimes it does automatically but now it's not doing it anymore
18:26:58  <tjfontaine>http://jenkins.nodejs.org/job/node-review-windows/ looks like it's still building atm
18:28:35  <AlexisMocha>yeah, i see. thanks
18:36:12  <tjfontaine>AlexisMocha: looks like just net-fd0
18:37:12  * daviddiasquit (Remote host closed the connection)
18:37:42  * daviddiasjoined
18:38:21  <AlexisMocha>I deleted the other tests from my branch to speed things up. Because again, I cannot repro this one outside of Jenkins
18:38:27  <tjfontaine>nod
18:39:52  * mikolalysenkojoined
18:41:42  * daviddia_joined
18:41:45  * daviddia_quit (Remote host closed the connection)
18:41:53  * daviddiasquit (Ping timeout: 245 seconds)
18:42:15  * daviddiasjoined
18:44:02  * rmgjoined
18:49:02  * calvinfoquit (Quit: Leaving.)
18:51:32  * paulfryz_joined
18:56:38  * paulfryz_quit (Ping timeout: 264 seconds)
18:56:48  * mcavagejoined
19:00:43  <tjfontaine>indutny: it's trying to call ToString on a fixed array, of some global object
19:18:26  * calvinfojoined
19:23:59  * mikealquit (Quit: Leaving.)
19:30:12  * mikealjoined
19:32:52  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
19:38:38  * kpdeckerquit (Read error: Connection reset by peer)
19:39:00  * c4milojoined
19:39:01  * kpdeckerjoined
19:39:51  * brsonjoined
19:45:49  * dshaw_quit (Quit: Leaving.)
19:52:15  * paulfryz_joined
19:57:14  * paulfryz_quit (Ping timeout: 264 seconds)
19:57:21  * AWintermanquit (Remote host closed the connection)
19:57:53  * sh1mmerquit (Quit: sh1mmer)
20:03:16  <indutny>tjfontaine: thanks
20:06:46  <indutny>String::Utf8Value filename(message->GetScriptResourceName());
20:06:50  <indutny>that's where it happens
20:06:52  <tjfontaine>ya
20:06:52  * skypjackjoined
20:06:56  <tjfontaine>sorry I got further along
20:07:07  <tjfontaine>I think it's ExecuteString that's failing
20:07:30  <indutny>yeah
20:07:31  <indutny>most likely
20:07:33  <indutny>generating junk
20:07:51  <tjfontaine>why ->IsFunction() passes is beyond me, recompiling enabling the gdb jit atm
20:10:19  <indutny>I'll try reverting patch line by line
20:13:41  * dshaw_joined
20:17:31  * kpdeckerquit (Ping timeout: 272 seconds)
20:19:03  <indutny>it is definitely because of GetDisplayErrors
20:19:10  <indutny>GetDisplayErrorsArg
20:19:12  <indutny>and some other function
20:20:41  <indutny>yeah, the problem is that it should not create HandleScope
20:21:02  <indutny>yeah, that is fixing the problem
20:21:34  <tjfontaine>ugh, is it an order of operations thing? we're not all the way initialized to be able to create a new scope?
20:21:36  <indutny>and I have no idea why this is bad
20:21:41  <tjfontaine>heh ok
20:21:59  <indutny>tjfontaine: could you please look at the rest of PR while I'm finishing this thing?
20:22:06  <indutny>wanna land it ASAP
20:22:11  <indutny>until merge conflicts will arise
20:22:19  <tjfontaine>nod
20:23:01  <indutny>thank you
20:23:17  <tjfontaine>so when I see stuff like, the only change to a function is:
20:23:17  <tjfontaine>+ Environment* env = Environment::GetCurrent(args.GetIsolate());
20:23:18  <tjfontaine>+ HandleScope scope(env->isolate());
20:23:46  <tjfontaine>is it worth the env lookup? or should we just use args.GetIsolate() there?
20:23:54  <tjfontaine>I'll comment on the PR
20:24:01  <indutny>tjfontaine: man
20:24:05  <indutny>it is just copy paste :P
20:24:17  <indutny>this thing is across all the file
20:24:21  <indutny>all the files*
20:24:24  <tjfontaine>hehe I know, but it's a reasonable question, because ::GetCurrent does extra lookups
20:24:34  <indutny>hm...
20:24:35  <indutny>right
20:24:38  <tjfontaine>it's not like the compiler is going to optimize them away
20:25:17  <tjfontaine>if we can see that in 3.24 we're going to need the env here for ->Throw* it is a reasonable argument, I'm just trying to think through it
20:25:44  <indutny>oh
20:25:46  <indutny>yeah
20:25:53  <indutny>this is correct
20:26:28  <tjfontaine>it's also not unreasonable to just do this as a pass, and then later as perf indicates remove as many of the env lookups
20:27:06  <indutny>perhaps
20:27:09  <indutny>tjfontaine: interesting thing
20:27:20  <indutny>contextify doesn't seem to like using env
20:27:31  <indutny>perhaps, it actually wants to use parent env
20:27:35  * piscisaureusjoined
20:29:31  * calvinfoquit (Quit: Leaving.)
20:31:18  * calvinfojoined
20:31:27  <indutny>tjfontaine: yeah, all tests seems to be passing without contextify changes
20:31:36  * dshaw_quit (Quit: Leaving.)
20:33:28  <tjfontaine>indutny: ok I'm going to hit up lunch, I'm about 1/2 the way through, mostly some of these things will need to support their old signatures for addons
20:33:36  <indutny>ok, grat
20:33:37  <indutny>thank you
20:33:46  <indutny>tjfontaine: oh.... which ones?
20:33:55  <tjfontaine>Buffer:: and StringBytes::
20:33:56  * brunklequit (Quit: brunkle)
20:34:14  <tjfontaine>they can just have slow paths, that are method overloads that do Isolate::GetCurrent
20:40:09  <indutny>is StringBytes public?
20:40:33  <tjfontaine>we've never really had a concept of public and private, people just do whatever they want
20:40:36  <tjfontaine>(frankly)
20:40:44  <indutny>well
20:40:49  <indutny>I don't care that much
20:40:55  <indutny>we are doing it in unstable branch
20:41:02  <tjfontaine>but what I don't want is a change this late in the game to cause more churn for people who have already updated code to work with 0.11
20:41:03  <indutny>and this header is not installed anywhere in system
20:41:05  <tjfontaine>in good faith
20:41:16  <indutny>ok
20:41:25  <indutny>I'll add stubs with Isolate::GetCurrent()
20:41:29  <tjfontaine>thanks
20:41:45  <tjfontaine>and while `make install` may not include it, I'm sure node-gyp probably does
20:42:19  <tjfontaine>there's not an obvious change to the semantics in contextify that indicate why this is a problem
20:43:40  <indutny>ok
20:43:51  <indutny>I'm going to remove Environment::GetCurrent
20:43:54  <indutny>from the places
20:43:57  <indutny>where it is not needed
20:44:06  <indutny>I didn't think about overhead at the time of writing it
20:44:09  * dshaw_joined
20:44:25  <tjfontaine>nod
20:45:03  <indutny>though
20:45:10  <tjfontaine>so hmm
20:45:10  <indutny>there is improvement regarding symbols
20:45:20  <indutny>i.e.
20:45:26  <indutny>I moved many of symbols to the env.h
20:45:34  <indutny>and lookup from it is static
20:46:09  <tjfontaine>in the pr?
20:47:16  <indutny>yes, this is in pr
20:47:18  * abraxasjoined
20:47:28  <tjfontaine>I didn't see it
20:47:37  <indutny>look at env.h
20:47:40  <indutny>it changed a lot
20:47:49  <indutny>and by symbols I meant v8 symbols
20:47:51  <indutny>i.e. strings
20:48:06  <tjfontaine>oh the fixed one bytes
20:48:28  <tjfontaine>ok really getting lunch this time
20:49:18  <indutny>yeah
20:49:20  <indutny>:)
20:49:24  <indutny>see ya soon
20:51:51  * abraxasquit (Ping timeout: 260 seconds)
20:52:39  * calvinfoquit (Quit: Leaving.)
20:52:47  * euoiaquit (Ping timeout: 252 seconds)
20:53:01  * paulfryz_joined
20:55:12  * AWinterm_joined
20:56:18  * brunklejoined
20:57:31  * paulfryz_quit (Ping timeout: 265 seconds)
21:01:58  * calvinfojoined
21:02:07  * dshaw_quit (Quit: Leaving.)
21:05:20  * sh1mmerjoined
21:15:50  * jmar777quit (Remote host closed the connection)
21:17:42  * Ralithquit (Ping timeout: 260 seconds)
21:29:52  * mikealquit (Quit: Leaving.)
21:38:48  * TooTallNatequit (Quit: Computer has gone to sleep.)
21:39:43  * daviddia_joined
21:42:18  * daviddiasquit (Ping timeout: 245 seconds)
21:43:41  * octetclo1quit (Quit: WeeChat 0.4.3)
21:44:01  * octetcloudjoined
21:44:22  * dshaw_joined
21:44:33  * daviddia_quit (Ping timeout: 252 seconds)
21:49:43  * c4miloquit (Remote host closed the connection)
21:53:03  <tjfontaine>indutny: how goes the war?
21:53:11  <indutny>finished ThrowError thing
21:53:18  <indutny>running tests
21:53:34  <tjfontaine>still minus contextify?
21:53:48  <indutny>no, I made it :P
21:53:51  * paulfryz_joined
21:54:00  <indutny>it was just uninitialized env at that point
21:54:14  * rendarquit
21:54:14  <tjfontaine>heh, that's what I was going to ask, because we're in CreateEnvironment
21:54:14  <indutny>so, I just used Isolate and everything worked fine
21:54:19  <indutny>yeah
21:57:48  <indutny>ok, pushed
21:58:00  <tjfontaine>ok reloading
21:58:09  <indutny>going to add stubs for StringBytes
21:58:54  * paulfryz_quit (Ping timeout: 265 seconds)
21:58:54  * mikolalysenkoquit (Ping timeout: 265 seconds)
22:00:17  * AWinterm_quit (Remote host closed the connection)
22:00:26  * mcavagequit (Remote host closed the connection)
22:01:19  * dshaw_quit (Ping timeout: 265 seconds)
22:02:26  <indutny>pushed legacy stubs for string_bytes
22:02:31  <indutny>now going to look at Encode()/Decode()
22:03:15  * AWintermanjoined
22:07:46  <indutny>and done
22:07:52  <indutny>now to remove rest of node_isolate usages
22:09:57  <tjfontaine>indutny: so, I wonder if Buffer and StringBytes should take env's vs Isolate?
22:10:10  <indutny>good question
22:10:38  <tjfontaine>as a binary addon author, how much should they care about knowing how to get an Environment, vs getting the Isolate
22:10:44  * hzquit
22:11:06  <indutny>tjfontaine: well, that's quite good
22:11:10  <indutny>I like it
22:15:36  * mikolalysenkojoined
22:17:54  * sblomquit (Read error: Connection reset by peer)
22:21:04  * daviddiasjoined
22:24:11  * skypjackquit (Quit: Sto andando via)
22:27:09  * drsjoined
22:27:36  * daviddiasquit (Read error: Connection reset by peer)
22:28:19  <indutny>whoa
22:28:21  <drs>with uv_read_start is there anyway to pass an offset into a uv_buf so that read callbacks will populate from that offset going forward?
22:28:22  <indutny>this is tons of work :P
22:28:41  <indutny>drs: you could just give a slice of buffer in alloc_cb
22:28:48  <indutny>uv_buf_init(data + off, len - off)
22:29:57  <drs>ah yes.. let me see
22:30:11  * sblomjoined
22:30:24  * Ralithjoined
22:33:40  * AWintermanquit (Remote host closed the connection)
22:41:50  * AWintermanjoined
22:43:53  <indutny>tjfontaine: whoa
22:43:56  <indutny>tjfontaine: I think it is done
22:45:22  * brunklequit (Quit: brunkle)
22:46:12  * AWinterm_joined
22:46:30  <indutny>ah wait
22:46:33  <indutny>node_buffer.cc left
22:48:02  * abraxasjoined
22:48:05  * AWintermanquit (Ping timeout: 252 seconds)
22:49:22  * brunklejoined
22:51:36  <indutny>ok, done
22:52:41  * abraxasquit (Ping timeout: 272 seconds)
22:53:50  <tjfontaine>indutny: ok I'll look at it
22:53:53  <indutny>thank you
22:54:36  * paulfryz_joined
22:54:47  * TooTallNatejoined
22:56:21  <indutny>addons seems to be building fine
22:56:25  <indutny>yay! :)
22:56:42  <tjfontaine>well, I think we will need some Throw* stubs potentially
22:56:54  <tjfontaine>but ya
22:56:56  <indutny>oh gosh
22:57:17  <tjfontaine>;)
22:58:13  <tjfontaine>deprecated is a nice touch there
22:58:19  * dshaw_joined
22:59:19  * paulfryz_quit (Ping timeout: 252 seconds)
22:59:26  <indutny>tjfontaine: I'll add it
22:59:29  <indutny>one sec
22:59:49  <indutny>tjfontaine: not sure what to do about left `node_isolate` usages in node.cc
23:00:06  <indutny>basically, in future we will need to iterate over environments
23:00:11  <indutny>or something like this
23:00:17  <indutny>because debug events are happening per-process
23:00:19  <indutny>not per-context
23:00:36  <tjfontaine>yup
23:00:39  * octetcloudquit (Ping timeout: 260 seconds)
23:01:08  <indutny>tjfontaine: but that's something to consider
23:01:11  <indutny>not today :)
23:01:23  <tjfontaine>indeed, we still dont' even have a js api for multi context
23:02:54  <indutny>yeah
23:03:08  <indutny> 42 files changed, 1841 insertions(+), 1232 deletions(-)
23:03:09  <indutny>haha
23:03:11  <indutny>pretty massive
23:03:11  * dshaw_quit (Ping timeout: 265 seconds)
23:03:11  <tjfontaine>:)
23:03:23  <tjfontaine>should make the 3.24 upgrade less so though
23:03:28  <indutny>yeah
23:03:37  <tjfontaine>I'm happy they standardized on order of (isolate, value)
23:03:43  <indutny>yep
23:03:45  <indutny>this looks good
23:03:53  <indutny>so
23:03:57  <tjfontaine>ya, did you run some of the other tests?
23:04:03  <indutny>what do you mean?
23:04:05  <indutny>pummel?
23:04:05  <tjfontaine>gc and internet
23:04:10  <tjfontaine>pummel I haven't verified yet
23:04:22  <indutny>one sec
23:04:23  <indutny>running
23:04:51  <indutny>gc is failing
23:04:55  <indutny>but it seems to be unrelated
23:05:01  <indutny>Error: connect ECONNRESET
23:05:20  <tjfontaine>which test?
23:06:07  <indutny>test/gc/test-http-client.js
23:06:08  * wolfeidauquit (Remote host closed the connection)
23:06:13  <indutny>test/gc/test-http-client-onerror.js
23:06:21  <indutny>test/gc/test-net-timeout.js
23:06:23  <indutny>basically
23:06:26  <indutny>almost all of them
23:07:42  <tjfontaine>currently rebuilding master proper
23:09:04  <tjfontaine>ya 4 failures
23:09:27  <MI6>joyent/libuv: rcp master * 0943d3c : win: minor error handle fix to uv_pipe_write_impl - http://git.io/1CW8lA
23:09:38  * brunklequit (Quit: brunkle)
23:09:49  <indutny>tjfontaine: without my patch, right?
23:10:20  <tjfontaine>yes
23:10:24  <tjfontaine>rcp?!
23:10:36  <indutny>rcp?
23:10:48  <indutny>is test using rcp?
23:10:56  <indutny>nope
23:11:03  <tjfontaine>no no, the commit for libuv
23:11:07  <tjfontaine>missing realname
23:11:11  <indutny>oh fuck
23:11:17  * mcavagejoined
23:11:25  <tjfontaine>sok
23:11:33  <indutny>he's in CLA though
23:11:37  <indutny>I have checked it
23:11:43  <tjfontaine>after I get through the 0.12 release imma make a tool :P
23:11:57  <indutny>haha
23:11:59  <indutny>yes, please
23:12:30  <indutny>so
23:12:31  <indutny>LGTY?
23:13:01  <tjfontaine>ya, I think we may end up dropping some Environment's at some point, but for now it's looking pretty damn good, thanks for your work on this
23:14:01  <indutny>np
23:14:02  <indutny>you are welcome
23:14:14  <indutny>tjfontaine: do you mind if I'll squash it into one commit?
23:14:34  <indutny>I'm too lame to split them properly :)
23:16:00  * mcavagequit (Ping timeout: 265 seconds)
23:16:23  <indutny>tjfontaine: let me know, my finger is on "enter" key
23:20:15  <trevnorris>tjfontaine: hey, this async filter by type is just a massive rabbit hole. i'm going to pull the ability to filter, but still add the additional argument in create() that tells the user what provider type it is.
23:20:27  <tjfontaine>indutny: land it
23:20:32  <indutny>yay! :)
23:20:37  <indutny>tjfontaine: thanks
23:20:40  <indutny>oh no
23:20:42  <indutny>who pushed to master
23:20:43  <indutny>:P
23:20:46  <tjfontaine>me
23:20:49  <tjfontaine>it's js only
23:21:00  <indutny>ah, I see
23:21:03  <MI6>joyent/node: Fedor Indutny master * 75adde0 : src: remove `node_isolate` from source - http://git.io/0my_Gw
23:21:06  <indutny>great! :)
23:21:44  <indutny>one less thing before v0.12
23:21:48  <tjfontaine>trevnorris: hmm ok
23:22:14  * kevinsimperquit (Remote host closed the connection)
23:22:21  * brunklejoined
23:23:24  <trevnorris>tjfontaine: still going to try something out, but it's been hard to think lately.
23:23:49  * brunklequit (Client Quit)
23:25:00  <trevnorris>tjfontaine: short explanation, if a listener is removed then I need to run through the context stack and make a duplicate copy of all _asyncQueue, because removing it from the context will remove it from all future usage as well.
23:26:19  <trevnorris>so i'm still giving it a go, but since it's taking longer than I anticipated, figured getting v0.12 out the door was priority.
23:27:28  * thlorenzquit (Remote host closed the connection)
23:28:10  <trevnorris>indutny: hey dude: ../src/env.h:397:15: warning: inline function 'node::Environment::ThrowErrnoException' is not defined
23:28:19  <indutny>oh gosh
23:28:36  <trevnorris>../src/env.h:396:15: warning: inline function 'node::Environment::ThrowRangeError' is not defined
23:28:45  <indutny>wait
23:28:47  <trevnorris>../src/env.h:395:15: warning: inline function 'node::Environment::ThrowTypeError' is not defined
23:28:51  <indutny>where it comes from?
23:28:56  <trevnorris>the build
23:28:58  <indutny>no
23:29:00  <indutny>I mean
23:29:03  <indutny>what files includes env.h ?
23:29:06  <indutny>and fails
23:29:15  <indutny>the compiler should print it
23:29:16  <trevnorris>think In file included from ../src/node_crypto_clienthello.cc:22
23:29:22  <indutny>oooh
23:29:33  <tjfontaine>one day we'll go back to Wall Werror
23:29:34  <trevnorris>yeah. all of them come from that location
23:29:40  <indutny>gosh
23:29:49  <indutny>if you'll add #include "env-inl.h" to it
23:29:53  <indutny>will it solve the problem?
23:30:23  <trevnorris>one sec
23:31:16  <trevnorris>running clean build
23:32:06  <trevnorris>tjfontaine: any more thoughts on the v8 upgrade?
23:32:15  <tjfontaine>trevnorris: that's what fedor and I are working on
23:32:22  <trevnorris>:)
23:32:59  <indutny>tjfontaine: I'm working on sleeping right now :)
23:33:11  <tjfontaine>heh ya
23:33:23  <tjfontaine>I will need my tracing stuff reviewed, I have a couple more js portions to do
23:33:26  <indutny>trevnorris: going to shower, will return in 10-15 minutes
23:33:28  <trevnorris>indutny: included that, here's the build: https://gist.github.com/trevnorris/9145927
23:33:30  <indutny>tjfontaine: oh, right
23:33:45  * brunklejoined
23:34:02  <indutny>oooh
23:34:09  * dshaw_joined
23:34:12  <indutny>tjfontaine: could you please try adding env-inl.h to node_internals.h ?
23:35:00  <trevnorris>indutny: just did. that cleared it up
23:35:05  <indutny>yay!
23:35:05  <indutny>ok
23:35:16  <trevnorris>that was the only place it was needed
23:35:21  <indutny>cool
23:35:22  <indutny>thank you!
23:35:25  <indutny>tjfontaine: I'll push commit
23:35:51  <MI6>joyent/node: Fedor Indutny master * dbae8b5 : node_internals: add missing env-inl.h include - http://git.io/8GxJBQ
23:36:00  <indutny>ok, ttyl guys
23:36:07  <indutny>tjfontaine: I'll try to reviewing your tracing thing tomorrow
23:36:14  <indutny>but if you and trevnorris feel confident to land it
23:36:15  * mikealjoined
23:36:17  <indutny>then it is fine
23:36:28  <indutny>I'll still be able to revert it in case of any trouble :P
23:38:00  <Kakera_>just wondering, is there any particular reason why node doesn't provide bindings for some functions in openssl and zlib?
23:38:17  <Kakera_>for example, RSA_public_encrypt from openssl, crc32 from zlib
23:38:38  * Kakera_changed nick to Kakera
23:39:29  <trevnorris>tjfontaine: shit, removing AL's have been broken for a while. the reason the tests haven't picked them up is because, well, they've been capturing the errors for the errors....
23:39:41  <trevnorris>so i'll get this figured out regardless.
23:50:29  <trevnorris>tjfontaine: well, the quick fix was easier than I thought. i just pushed the changes up, and want to see what jenkins says
23:53:31  * AvianFluquit (Remote host closed the connection)
23:55:15  * benviequit (Ping timeout: 260 seconds)
23:55:25  * paulfryz_joined