00:04:00  * paddybyersquit (Quit: paddybyers)
00:05:45  * bnoordhuisquit (Ping timeout: 252 seconds)
00:05:53  * loladiro_quit (Read error: Connection reset by peer)
00:06:22  * loladirojoined
00:11:47  * loladiropart
01:04:15  * dapquit (Quit: Leaving.)
01:20:11  * arlolrajoined
01:28:44  * brsonquit (Quit: leaving)
01:47:28  * arlolraquit (Quit: Linkinus - http://linkinus.com)
02:04:05  * piscisaureus_quit (Quit: ~ Trillian Astra - www.trillian.im ~)
02:35:58  <CIA-108>node: Jonas Westerlund v0.8 * r2297d63 / lib/readline.js : Forgotten commit: add arguments to handleGroup (+8 more commits...) - http://git.io/jQVQBQ
02:42:36  <CIA-108>node: Nathan Rajlich v0.8 * r8a9e8d6 / lib/readline.js : readline: don't use Function#call() - http://git.io/t2R5pA
02:47:20  * TooTallNatequit (Quit: ["Textual IRC Client: www.textualapp.com"])
02:58:55  * ericktquit (Quit: erickt)
03:04:07  * mjr_quit (Read error: Connection reset by peer)
03:04:50  * mjr_joined
03:06:23  <indutny>mjr_: hey man
03:06:32  <mjr_>hey
03:06:34  <indutny>mjr_: have you got a chance to try TLS performance patches?
03:06:45  <mjr_>I have not, probably won't get to it until next week.
03:07:01  <mjr_>But wait, you mentioned that it can work in 0.6 also?
03:07:03  <indutny>yeah, that's clear now
03:07:07  <indutny>mjr_: it should
03:07:20  <indutny>mjr_: nothing has changed in those places between 0.6 => 0.8
03:07:59  <mjr_>I think there was some thing that got in our way with recompiling openssl on smartos.
03:08:07  <mjr_>I can't remember what that was though.
03:08:43  <indutny>well, I think with, some straightforward nudging, it should work anyway
03:11:49  <mjr_>Let me grab a baseline right now at least so we can see how much of a difference it made.
03:12:02  <indutny>mjr_: cool, thanks
03:16:56  <mjr_>indutny: I'm dtrace sampling all of the CPU time of 8 processes on this one machine.
03:17:12  <indutny>mjr_: so at least it compiles, I suppose :)
03:17:21  <mjr_>This is just for the baseline
03:17:28  <indutny>yeah, got it
03:23:35  <mjr_>indutny: http://ranney.com/NR1.svg
03:23:45  <mjr_>Even more time spent in openssl than I thought.
03:25:08  <mjr_>libcrypto.so.0.9.8`bn_mul_add_words (2180 samples, 17.74%)
03:25:41  <indutny>oh, you are using shared version of openssl?
03:26:19  <indutny>one of my patches applies only for static version of openssl that is bundled in node.js
03:26:59  <indutny>mjr_: ^
03:28:08  <mjr_>Yeah, that's why I was thinking it would only work on 0.8
03:28:34  <indutny>well, there're slabbuffer patch
03:28:39  <indutny>which should work fine with 0.6 too
03:29:30  <indutny>mjr_: ^
03:29:54  <mjr_>Sure, that's less risky
03:30:12  <mjr_>I think we still have one outstanding issue that's holding us back from doing 0.8, but I can't remember what that is anymore
03:30:20  <mjr_>Have a link to the slab patch?
03:30:42  <indutny>sure, one moment
03:30:56  <indutny>mjr_: https://github.com/joyent/node/commit/f210530f46e8ddbd9e7cc0d0c37778888c27f526
03:30:58  * ericktjoined
03:32:23  <indutny>and btw, I think you should try using bundled version
03:32:41  <indutny>I suppose shared library doesn't have inlined assembly in it
03:32:55  <mjr_>Shared version is almost certainly older and slower.
03:33:01  <indutny>indeed
03:33:15  <indutny>this may greatly improve performance of your servers
03:35:17  <mjr_>Hmm, that patch doesn't apply cleanly to my 0.6 repo
03:35:27  <mjr_>f210530f46e8ddbd9e7cc0d0c37778888c27f526 I mean
03:35:52  <indutny>interesting
03:36:48  <indutny>I wonder what have changed since then
03:36:48  <mjr_>https://gist.github.com/3064364
03:37:02  <indutny>oooh
03:37:04  <mjr_>Looks like maybe just some style thing
03:37:05  <mjr_>s
03:37:26  <indutny>well, not really
03:37:37  <indutny>but it should apply
03:37:40  <indutny>lets see
03:38:35  <indutny>mjr_: looks like 'theirs' should work for this conflict
03:41:23  <mjr_>I should just try 0.8 and see what happens
03:41:29  <indutny>hahaha
03:41:40  <mjr_>I can run it on one process in the pool and see how it goes.
03:41:44  <mjr_>It might end up totally winning
03:43:25  <mjr_>Hmm, I wonder if this is some smartos breakage
03:43:26  <mjr_>https://gist.github.com/3064387
03:43:55  <indutny>oh, may be python too old?
03:44:09  <indutny>s/too/is too/
03:44:10  <AvianFlu>yeah, that's python 2.4
03:44:14  <AvianFlu>can't be a good thing
03:44:22  <indutny>2.4.6 is not really the latest thing
03:45:33  <mjr_>Yeah, I figured maybe it was some oldness thing, which is why I included the version.
03:46:07  <indutny>if I'll stop replying that means that I've passed out :)
03:47:41  * chobi_e_changed nick to chobi_e
03:49:14  <mjr_>Just shaving some yaks over here.
03:55:00  <indutny>ok, time to sleep for me now
03:55:01  <indutny>ttyl
03:57:45  <mjr_>indutny: OK, I'll let you know how it turned out.
03:59:50  * charliesomejoined
04:14:11  * mjr_quit (Quit: mjr_)
04:36:23  * chobi_echanged nick to chobi_e_
04:47:04  * davispjoined
04:47:45  <davisp>Reading uv.h I'm not seeing a way to configure the thread pool size. Am I missing something or is that automagical?
04:55:39  * brsonjoined
04:56:19  * Raynosquit (Ping timeout: 265 seconds)
04:56:48  * voodootikigodquit (Ping timeout: 265 seconds)
04:57:05  <charliesome>when i use libuv, it gobbles up SIGINT - is there a way to 'catch' sigint and handle it?
04:57:10  * indutnyquit (Ping timeout: 244 seconds)
05:08:25  * indutnyjoined
05:12:34  * perezdquit (Quit: perezd)
05:14:11  * Raynosjoined
05:31:15  * voodootikigodjoined
05:46:58  * ryahjoined
05:47:13  <ryah>hello
06:19:09  * mmaleckijoined
06:19:50  * ericktquit (Quit: erickt)
06:53:01  * EhevuTovjoined
07:17:01  * rendarjoined
07:30:49  <davisp>ryah: Are there any docs on the thread pools in libuv? I'm wondering how much control I have over things like the number of threads and what not.
07:36:23  * paddybyersjoined
07:45:33  * hzjoined
07:54:00  * paddybyersquit (Quit: paddybyers)
07:56:22  * mmaleckiquit (Ping timeout: 250 seconds)
07:56:38  * chobi_e_changed nick to chobi_e
08:09:33  * chobi_echanged nick to chobi_e_
08:10:20  * chobi_e_changed nick to chobi_e
08:38:42  * chobi_echanged nick to chobi_e_
08:41:01  * paddybyersjoined
08:58:27  * EhevuTovquit (Quit: Leaving)
08:59:36  * chobi_e_changed nick to chobi_e
09:20:19  * loladirojoined
09:23:08  * loladiroquit (Read error: Connection reset by peer)
09:23:48  * loladirojoined
09:37:17  * brsonquit (Remote host closed the connection)
09:41:58  * loladiroquit (Read error: Connection reset by peer)
09:42:03  * loladiro_joined
10:00:44  * theColequit (Quit: theCole)
10:06:02  * paddybyersquit (Quit: paddybyers)
10:28:41  * hzquit
10:53:39  * chobi_echanged nick to chobi_e_
11:07:26  * loladiro_quit (Read error: Connection reset by peer)
11:07:31  * loladirojoined
11:33:53  * loladiroquit (Ping timeout: 245 seconds)
11:34:39  * loladirojoined
11:37:48  * mmaleckijoined
11:39:26  * hzjoined
12:22:43  * chobi_e_changed nick to chobi_e
12:47:34  * loladiropart
12:47:57  * loladirojoined
13:27:09  * paddybyersjoined
13:51:52  * paddybyersquit (Quit: paddybyers)
14:29:59  <charliesome>Assertion failed: (!uv__io_active(&stream->read_watcher)), function uv__read, file src/unix/stream.c, line 634.
14:30:20  <charliesome>this was caused by opening a connection with netcat and then hitting ^C
14:30:28  <charliesome>i'm guessing i'm not handling something i should be?
14:38:57  * juliabotjoined
14:39:10  * juliabotpart
15:19:25  * chobi_echanged nick to chobi_e_
15:19:37  * arlolrajoined
15:55:54  * arlolraquit (Quit: Linkinus - http://linkinus.com)
16:00:13  * paddybyersjoined
16:03:46  * piscisaureus_joined
16:10:04  * mmaleckiquit (Quit: leaving)
16:26:22  * AlbireoX_quit (Ping timeout: 244 seconds)
16:27:08  * AlbireoX_joined
16:27:26  * mjr_joined
16:31:56  * mjr_quit (Client Quit)
16:33:00  * paddybyersquit (Quit: paddybyers)
16:54:21  * charliesomequit (Quit: Textual IRC Client: www.textualapp.com)
16:54:31  <CIA-108>node: Dominic Tarr v0.8 * r7accaeb / doc/api/stream.markdown : correct documentation of Stream#destroy - http://git.io/xeH56A
16:54:31  <CIA-108>node: isaacs v0.8 * r559a98f / doc/api/stream.markdown : doc: Formatting and grammar on stream api doc - http://git.io/iQTjfA
16:55:05  <isaacs>ryah: hola
16:57:28  <isaacs>oh, that was like 11 hours ago, ha
16:58:08  <piscisaureus_>hello
17:06:29  <piscisaureus_>isaacs: btw, what is the timeline for the new npm website?
17:06:46  <isaacs>piscisaureus_: it'll keep growing.
17:06:57  <isaacs>piscisaureus_: i want to get search somewhat working in the next few weeks
17:07:14  <isaacs>and starring
17:07:25  <piscisaureus_>isaacs: so, I mean, when does the current website get replaced by the new one :-)
17:07:26  <isaacs>and then it'll switch to being the main npmjs.org, and get linked from the nodejs.org homepage.
17:07:53  <isaacs>probably about a month or so
17:08:12  <piscisaureus_>right, ok
17:08:21  <piscisaureus_>the new one looks so much better than the old one :-)
17:08:46  <piscisaureus_>It really hurts every time I visit npmjs.org now
17:10:43  <piscisaureus_>Sign all the way up
17:10:43  <piscisaureus_>There was a problem! The server said: not_found
17:10:53  <isaacs>d'oh
17:10:58  <isaacs>wtf.
17:11:01  <isaacs>one sec
17:11:46  <isaacs>wtf, it's loading the page again for me, but without styles..
17:11:51  <isaacs>that's super strange
17:12:38  <isaacs>oh... it's /profile-edit that's not found
17:12:52  <piscisaureus_>isaacs: I tried to create a new account actually
17:12:59  <isaacs>right
17:13:06  <isaacs>but after creating, it directs you to https://new.npmjs.org/profile-edit
17:13:11  <isaacs>and then that's not found for some reason
17:13:15  <isaacs>but if you go directly there, it works.
17:13:27  <isaacs>maybe one of the cluster workers is in a bad state
17:16:26  <isaacs>hm, looks like a race condition with couchdb maybe.
17:16:51  <isaacs>so, you PUT the new user acct, and it says, "Ok, created", and then we immediately try to GET it, and it says "not_found"
17:17:12  <isaacs>piscisaureus_: but don't you already have an npm account anyway?
17:17:18  <piscisaureus_>isaacs: no, I didn't
17:17:23  <isaacs>piscisaureus_: it's the same username/password you use for npm publish
17:17:24  <isaacs>srsly??
17:17:26  <isaacs>dude.
17:17:31  <piscisaureus_>no
17:17:33  <isaacs>i'm hurt.
17:17:39  <isaacs>;P
17:18:02  <isaacs>piscisaureus_: anyway, if you just go direct to https://new.npmjs.org/profile-edit now, it should work
17:18:08  <isaacs>maybe refresh or something
17:18:13  <piscisaureus_>isaacs: it worked now.
17:18:18  <piscisaureus_>isaacs: I just created an account.
17:18:35  <piscisaureus_>isaacs: but before, I tried and I got that "not_found" problem, and no account was created at all
17:18:46  <piscisaureus_>isaacs: so I think the problem was not what you think it was
17:21:13  <piscisaureus_>isaacs: btw, does npm no longer leak password hashes?
17:21:16  <piscisaureus_>:-)
17:21:31  <isaacs>piscisaureus_: yes, that's been fixed for a while
17:21:37  <piscisaureus_>ok, cool :-)
17:22:01  <isaacs>piscisaureus_: the _users db can only be accessed by admins, except if you try to GET the record for the currently signed-in user.
17:22:20  <isaacs>piscisaureus_: then a continuous replication job copies the public data over to public_users
17:22:21  * paddybyersjoined
17:22:49  <piscisaureus_>ok, so this _users thing also doesn't get cloned to mirrors
17:22:53  <piscisaureus_>that's good
17:22:55  <isaacs>right
17:23:10  <isaacs>unless the mirror is signed in as an admin (ie, me, mikeal, or jasonsmith)
17:23:17  <isaacs>but that's not very likely
17:23:45  <isaacs>so, if MY password is compromised, we're fucked.
17:23:59  <isaacs>if JasonSmith's password is compromised, then every IrisCouch customer is probably fucked.
17:26:47  <piscisaureus_>haha
17:27:36  <piscisaureus_>Yeah, I have no packages. Remember that until 6 months ago there was no way for me to run npm reliably :-)
17:27:46  <piscisaureus_>I just never got the hang of it
17:28:52  <isaacs>oh, heh, true that
17:29:10  * theColejoined
17:31:16  <isaacs>piscisaureus_: also, i need to figure out why clusterMaster isn't doing graceful restarts properly
17:32:16  * mmaleckijoined
17:45:10  * txdvjoined
17:49:01  <indutny>ryah: oh, you're online :)
17:49:30  <indutny>heya
17:49:33  <indutny>how are you?
17:55:04  <piscisaureus_>isaacs: hmm, that's weird indeed
17:55:25  <piscisaureus_>isaacs: well, atleast that means that we now find the bugs before mjr_ does :-)
17:55:33  <isaacs>piscisaureus_: yep :)
17:55:55  <isaacs>piscisaureus_: it'll be nice to have an actual service running on node.
17:56:00  <isaacs>it's been really interesting.
17:56:07  <piscisaureus_>haha
17:56:18  <piscisaureus_>I have slurp :-p
17:56:27  <piscisaureus_>but that is so simple that it doesn't really count
17:56:56  <isaacs>yeah
17:57:02  <isaacs>i dunno. it counts.
17:57:07  <isaacs>but it's not like many users are slamming that
17:57:14  <piscisaureus_>indeed
17:57:29  <piscisaureus_>and it still runs node 0.4.7
17:57:54  <isaacs>ugh, this signup flow is totally fucked.
17:58:28  <isaacs>it's the kind of thing where i wrote it one way, and then was like, "this is too hard" and abstracted it out, but didn't convert it to use the newly abstracted-out method everywhere consistently.
17:59:30  <mmalecki>isaacs: what is it running on btw?
17:59:36  <indutny>so noone from core contributors is really using node.js :D
17:59:52  <isaacs>indutny: well, i've been using node a LOT for command-line and http-client stuff
17:59:55  <isaacs>but not as an http server.
17:59:59  <indutny>haha
18:00:00  <indutny>ok
18:00:12  <isaacs>mmalecki: it's running on node.
18:00:15  <indutny>I really trust you, when you're saying that
18:00:16  <isaacs>mmalecki: on a joyent smart machine
18:00:51  <mmalecki>isaacs: I see. maybe give nodejitsu a try when you find some time?
18:00:59  <isaacs>mmalecki: hahah, no thanks.
18:01:07  <isaacs>mmalecki: i'm not a fan of PaaS
18:01:15  <isaacs>i have nothing against it, it's good for alot of use case.
18:01:17  <isaacs>*cases
18:01:33  <mmalecki>fair enough!
18:01:35  <isaacs>but i like my servers a bit less processed.
18:01:41  <isaacs>i'ts like the macrobiotic diet.
18:02:03  <isaacs>same reason i'm not using express or tako or any of them
18:02:07  <AvianFlu>if you like running your own servers, the likelihood of part of somebody else's setup annoying you is pretty high
18:02:18  <isaacs>AvianFlu: right.
18:02:22  <mmalecki>AvianFlu: ++
18:02:22  <kohai>AvianFlu has 125 internet points
18:02:33  <mmalecki>I get pissed of at nodejitsu constantly
18:02:39  <AvianFlu>I see our stuff as best for people who don't want to do that, or big teams who benefit from having things consistent
18:02:41  <isaacs>it's not so much that i LIKE running my own server, but that i strongly DISLIKE it being done in a way i don't expect.
18:02:48  <mmalecki>then I usually go and fix that
18:03:02  <AvianFlu>mmalecki, you aren't exactly a regular user
18:03:21  <isaacs>running on jitsu would mean signing up to work for jitsu. i already work for joyent and node, so i am not signing up for *new* work by using those things :)
18:03:23  <mmalecki>AvianFlu: yeah, I have like, ssh keys all over the place and stuff
18:03:46  <mmalecki>AvianFlu: I think nodejitsu even pays me to do it or something!
18:04:06  <AvianFlu>is *that* how you afford all that booze!?
18:04:19  <mmalecki>that *might* be the answer!
18:04:38  <mmalecki>second possibility is the tooth fairy.
18:05:34  <AvianFlu>vodka fairy, at that point
18:05:59  <mmalecki>yeah, I put empty bottles under my pillow
18:20:08  * loladiro_joined
18:22:32  * loladiroquit (Ping timeout: 264 seconds)
18:22:32  * loladiro_changed nick to loladiro
18:36:07  * mikealjoined
19:03:56  * arlolrajoined
19:14:42  * AndreasMadsenjoined
19:17:29  * mmaleckiquit (Quit: leaving)
19:27:53  * mjr_joined
19:39:56  * piscisaureus_quit (Ping timeout: 264 seconds)
19:40:46  * mikealquit (Quit: Leaving.)
19:41:11  <CIA-108>node: isaacs v0.8 * r59a40fc / (202 files in 9 dirs): npm: Upgrade to 1.1.36 - http://git.io/0tJ57A
19:43:23  * arlolraquit (Quit: Linkinus - http://linkinus.com)
19:47:10  * dshaw_joined
19:55:03  * indexzerojoined
20:01:51  * chrisdickinsonjoined
20:02:55  <chrisdickinson>are node 0.8 domains implemented at the libuv level, or at the node level?
20:03:12  <indutny>chrisdickinson: node level
20:03:17  <chrisdickinson>cool, thanks.
20:06:59  <indutny>oh my gosh
20:07:06  <indutny>async session storage is working :D
20:07:09  <indutny>I'm really suprised
20:09:44  <indutny>isaacs: ^^
20:22:01  <indutny>isaacs: example - https://gist.github.com/c673ba2eee983d4cd6a1
20:22:24  <indutny>isaacs: https://github.com/joyent/node/pull/3661
20:22:30  <indutny>ryah: just in case if you're interested ^
20:26:15  * piscisaureus_joined
20:26:58  <indutny>piscisaureus_: hey man
20:27:06  <piscisaureus_>hey fedor
20:27:07  <indutny>piscisaureus_: https://github.com/joyent/node/pull/3661
20:27:16  <indutny>piscisaureus_: and usage example https://gist.github.com/c673ba2eee983d4cd6a1
20:27:26  <indutny>piscisaureus_: review? ;)
20:27:41  <piscisaureus_>indutny: I will take a look. But now I am having dinner so it'll be a little later
20:27:46  * EhevuTovjoined
20:27:49  <indutny>oh, yeah, of course
20:29:26  <isaacs>indutny: nice!!
20:29:53  <isaacs>chrisdickinson: hey
20:30:00  <isaacs>(i saw indexzero sent you into here)
20:30:30  <isaacs>chrisdickinson: There aren't any docs yet, but you can check out how node things use the node::MakeCallback C++ method
20:31:09  * brsonjoined
20:32:45  <indutny>isaacs: basically, as I can see - looking up to the redis decreases performance a little
20:32:47  <indutny>like 5%
20:32:53  <indutny>when no sessions are reused
20:34:28  <chrisdickinson>isaacs: ah! cool. was just poking at that.
20:34:31  <chrisdickinson>(thanks!)
20:35:02  * EhevuTovquit (Quit: Leaving)
20:36:51  <indutny>ah, that's simply because apache benchmark is using SSL2
20:36:53  <indutny>ohhhhh
20:41:42  <isaacs>indutny: that's odd.
20:41:52  <isaacs>oh, does SSL2 not allow session reuse or something?
20:42:35  <indutny>isaacs: it allows, but it's using different record protocol
20:42:37  <indutny>fixing it atm
20:43:00  <isaacs>whoops, never bumped the version to 0.8.2-pre
20:43:22  <CIA-108>node: isaacs v0.8 * rc49888b / src/node_version.h : Now working on 0.8.2 - http://git.io/CCgc2g
20:57:47  <CIA-108>node: isaacs v0.8.2-release * r3bda892 / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/2cljXg
20:57:56  <isaacs>test, please^
20:58:01  <isaacs>looks pretty good to me, though
20:58:46  <isaacs>RC0 uploaded to the usual place
20:59:20  <piscisaureus_>+erik.corry@gmail.com <erik.corry@gmail.com>
20:59:20  <piscisaureus_>+verwaest@chromium.org <verwaest@chromium.org>
20:59:44  <piscisaureus_>I don't care much, but these guys didn't contribute to node
20:59:53  <piscisaureus_>I just landed their v8 patches straight into node
20:59:57  <isaacs>oh, right.
20:59:59  <piscisaureus_>isaacs: also, we should upgrade v8
21:00:05  <isaacs>kewl.
21:00:17  <piscisaureus_>isaacs: there are patches to make node memory hungry
21:00:24  <piscisaureus_>(which was a regression from 0.6)
21:01:03  <isaacs>does http://v8.googlecode.com/svn/tags/3.11.10.14/ fix them?
21:01:13  <isaacs>you mean, less memory hungry?
21:02:37  <piscisaureus_>yeah
21:02:48  * c4milojoined
21:02:50  <piscisaureus_>isaacs: difficult to see, the git mirror is broken :-/
21:02:55  <piscisaureus_>isaacs: let me figure out
21:03:22  <piscisaureus_>3.11.10.13 has the patch
21:03:24  <piscisaureus_>so yeah
21:03:47  * mikealjoined
21:03:51  * indexzeroquit (Quit: indexzero)
21:04:04  <piscisaureus_>god i hate svn
21:09:44  <CIA-108>node: isaacs v0.8.2-release * r592de74 / (8 files in 4 dirs): v8: Upgrade to 3.11.10.14 - http://git.io/NjrKGA
21:09:44  <isaacs>bumped on the -release branch
21:09:44  <CIA-108>node: Bert Belder v0.8.2-release * r4d2f6d6 / deps/v8/build/common.gypi : v8: reapply floating patches - http://git.io/A3ebQA
21:09:44  <CIA-108>node: isaacs v0.8.2-release * r8ffde7e / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/cFQ2Nw
21:10:33  <CIA-108>node: isaacs v0.8.2-release * rab6530c / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/WByWpQ
21:10:41  <isaacs>(author update)
21:13:03  * piscisaureus_quit (Quit: ~ Trillian Astra - www.trillian.im ~)
21:13:25  * piscisaureus_joined
21:14:51  <piscisaureus_>heh
21:15:06  <piscisaureus_>3.11.10.13 is a great fix
21:15:16  <piscisaureus_>3.11.10.14 removes a superfluous blank line
21:18:47  <piscisaureus_>Anyone here objected to adding .svn to .gitignore?
21:21:43  <CIA-108>node: Bert Belder v0.8 * rc6843f4 / .gitignore : gitignore: ignore .svn directories - http://git.io/bWfRbg
21:24:03  <isaacs>piscisaureus_: no objections at all
21:24:08  <isaacs>piscisaureus_: did i get a .svn in there?
21:24:21  <piscisaureus_>isaacs: no
21:24:38  <isaacs>ok, kewl
21:25:27  <piscisaureus_>isaacs: but I typically upgrade v8 by hard linking the v8 svn checkout dir into deps and then git add -A
21:26:01  <piscisaureus_>isaacs: do you want me to build that thing?
21:26:47  <isaacs>piscisaureus_: oh, that's clever
21:26:54  <isaacs>wait, you hard-link a directory?
21:27:17  <isaacs>piscisaureus_: sure, test it out, if you're not busy
21:27:18  <isaacs>not rush
21:27:19  <piscisaureus_>isaacs: well, I make a junction
21:27:27  <isaacs>ohh... ok.
21:27:35  <piscisaureus_>isaacs: ok, doesn't build on windows
21:27:48  <isaacs>fun
21:28:00  <piscisaureus_>isaacs: ben's cc detection patches broke the build
21:28:15  <isaacs>piscisaureus_: make sure to throw something at him :)
21:28:33  <piscisaureus_>I knew already but I wasn't aware that these patches were also in master
21:28:42  <piscisaureus_>isaacs: made him buy beer
21:29:08  <isaacs>piscisaureus_: very pragmatic of you
21:29:18  <tjfontaine>it really fucking frustrates me when some developers think they're devops or even better sysadmins
21:29:56  <tjfontaine>dear google employees, please step away from the mysql, thanks.
21:35:10  <piscisaureus_>simple fix
21:35:15  <piscisaureus_>testing now
21:37:59  * perezdjoined
21:38:27  <isaacs>piscisaureus_: you fixing on 0.8, or 0.8.2-releas?
21:38:59  <piscisaureus_>isaacs: well, it doesn't really matter.... the fix was really simple but I have to build the thing first before I am sure :-)
21:39:07  <isaacs>heh
21:39:15  <piscisaureus_>isaacs: I will land on 0.8
21:39:23  <piscisaureus_>isaacs: just rebase the release branch after that or something
21:39:30  <piscisaureus_>(or is that too painful?)
21:41:23  <CIA-108>node: Bert Belder v0.8 * r3e5139f / configure : Fix the Windows build - http://git.io/Rh2hYg
21:42:16  <piscisaureus_>^-- Isaacs: that
21:44:34  <piscisaureus_>isaacs: should I rebase 0.8.12-release ?
21:48:11  <CIA-108>node: isaacs v0.8 * r5b5c8b6 / (8 files in 4 dirs): v8: Upgrade to 3.11.10.14 - http://git.io/VF__Ow
21:48:11  <CIA-108>node: Bert Belder v0.8 * r1c1ad9b / deps/v8/build/common.gypi : v8: reapply floating patches - http://git.io/Kpy-bw
21:48:12  <CIA-108>node: isaacs v0.8.12-release * r2fdf065 / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/fqfbAw
21:48:21  <piscisaureus_>done...
21:48:47  <isaacs>0.8.12?
21:49:08  <isaacs>did you publish 10 versions when i wasn't looking?
21:49:09  <isaacs>;{
21:49:11  <isaacs>;P
21:49:24  <piscisaureus_>ghe
21:49:55  <isaacs>fixed
21:50:00  <piscisaureus_>kewl
21:50:29  <CIA-108>node: isaacs v0.8.2-release * r2fdf065 / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/fqfbAw
21:50:30  <piscisaureus_>^-- that one, then?
21:50:47  <piscisaureus_>playing with fire here
21:50:56  <CIA-108>node: isaacs v0.8.2-release * ra6a2edb / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/Y915Ow
21:51:06  <isaacs>hah
21:51:08  <isaacs>it's ok
21:51:14  <isaacs>release branches don't matter until they're merged in
21:51:31  <isaacs>it's more like playing with a warm stick than actual fire :)
21:51:54  <piscisaureus_>$ git diff 2fdf065..a6a2edb
21:51:54  <piscisaureus_>{ nothing shows }
21:51:54  <piscisaureus_>$
21:52:22  <isaacs>piscisaureus_: it's because they differ only in their parent
21:52:39  <piscisaureus_>isaacs: well, then diff would show something right?
21:52:42  <isaacs>nope
21:52:50  <isaacs>it's the same commit, just in a different place.
21:52:54  <isaacs>so it has a diferent sha
21:53:07  <piscisaureus_>isaacs: nonono
21:53:19  <piscisaureus_>isaacs: diff compares trees, not commits :-)
21:54:18  <isaacs>but 2fdf065 isn't attached to anything anyway
21:54:20  <isaacs>it's gc'able
21:54:55  <piscisaureus_>isaacs: that's correct... because you replaced the head that was pointing to it
21:55:27  <piscisaureus_>isaacs: btw - I don't blame you, I just find it curious that two commits exactly equal have different shas
21:56:41  * paddybyersquit (Quit: paddybyers)
21:56:49  <isaacs>oh, actually, yeah..
21:56:53  <isaacs>they have the same parent
21:57:08  <isaacs>that's weird :)
21:57:16  <piscisaureus_>aah wait 2fdf065 has me as the committer, and a6a2edb has you
21:57:27  * dshaw_quit (Quit: Leaving.)
21:57:42  <isaacs>ohh, ok
21:57:47  <piscisaureus_>ghe
21:57:49  <isaacs>right
21:57:50  <piscisaureus_>let's forget
21:57:56  <isaacs>i stole your commit :)
21:58:06  <piscisaureus_>independent invention
21:58:09  <piscisaureus_>but I was first
21:58:14  <isaacs>well, actually it was mine originally
21:58:16  <piscisaureus_>so you will pay me damages
21:58:45  <piscisaureus_>ok, on the serious stuff
21:58:49  <piscisaureus_>test-require-json is failing
21:59:40  <isaacs>piscisaureus_: orly? windows pathiness?
21:59:42  <piscisaureus_>which emphasizes the need for CI once more
21:59:45  <isaacs>yes.
21:59:46  <piscisaureus_>I supose
21:59:55  <piscisaureus_>*suppose
21:59:55  <isaacs>yep.
22:00:01  <isaacs> var i = err.message.indexOf('test/fixtures/invalid.json: Unexpected string')
22:00:08  <isaacs>missing semi, too.
22:00:10  <isaacs>jeez.
22:00:20  * isaacsissues a demerit to TJ
22:00:25  <piscisaureus_>haha
22:01:45  <piscisaureus_>test-fs-largefile timed out on the drone, possibly because it takes too long to create a 4gb file
22:01:54  <isaacs>any other test failures?
22:02:32  <piscisaureus_>not yet
22:02:34  <piscisaureus_>98%
22:03:07  <CIA-108>node: isaacs reviewme * r5e44f5f / test/simple/test-require-json.js : Fix test-require-json on Windows (+47 more commits...) - http://git.io/FJLCdA
22:03:12  <isaacs>should fix the issue^
22:04:32  <piscisaureus_>isaacs: no
22:04:58  <piscisaureus_>isaacs: I think on windows the error will contain the full path
22:05:20  <piscisaureus_>right, that's ok
22:07:08  <isaacs>piscisaureus_: yeah, but checking for the full path is a pita
22:07:29  <piscisaureus_>isaacs: I know.. so here's what I get:
22:07:32  <isaacs>i guess it'd be fine to just use require.resolve to look it up, but i dunno. tests should use literal values, not just check the SUT against itself
22:07:55  <piscisaureus_>isaacs:
22:07:56  <piscisaureus_>C:\Users\Administrator\Desktop\node>node -e "require('./test/fixtures/invalid.json');"
22:07:56  <piscisaureus_>undefined:4
22:07:56  <piscisaureus_> "description": "im broken"
22:07:56  <piscisaureus_> ^
22:07:56  <piscisaureus_>SyntaxError: Unexpected string
22:09:26  <isaacs>oh, yeah. seems like the test is a bonafide failure.
22:09:30  <piscisaureus_>isaacs: so it seems that the test actually catches an error, since the filename is not included
22:09:31  <piscisaureus_>haha
22:09:39  <isaacs>poh, no, haha
22:09:45  <isaacs>match vs indexOf
22:09:53  <isaacs>JavaScript is hard.
22:09:58  <piscisaureus_>2x haha
22:10:13  <piscisaureus_>isaacs: but I still think that there is also a genuine failure in there
22:10:14  <isaacs>try that
22:10:16  <CIA-108>node: isaacs reviewme * r5abce2b / test/simple/test-require-json.js : Fix test-require-json on Windows - http://git.io/j0N31Q
22:10:17  <isaacs>yes.
22:10:54  <isaacs>> try {require('./test/fixtures/invalid.json') } catch (e) { e.message }
22:10:55  <isaacs>'/Users/isaacs/dev/js/node-v0.8/test/fixtures/invalid.json: Unexpected string'
22:11:12  <piscisaureus_>isaacs: passes
22:11:23  <isaacs>but from -pe it's different
22:11:24  <isaacs>$ node -pe "try {require('./test/fixtures/invalid.json') } catch (e) { e.message }"
22:11:27  <isaacs>Unexpected string
22:11:31  <isaacs>not sure why
22:11:39  <piscisaureus_>D:\node4>Release\node
22:11:39  <piscisaureus_>> try {require('./test/fixtures/invalid.json') } catch (e) { e.message }
22:11:39  <piscisaureus_>'D:\\node4\\test\\fixtures\\invalid.json: Unexpected string'
22:11:54  * paddybyersjoined
22:12:16  <piscisaureus_>isaacs: this is also funny:
22:12:16  <piscisaureus_>D:\node4>Release\node
22:12:16  <piscisaureus_>> require('./test/fixtures/invalid.json')
22:12:16  <piscisaureus_>... ^C
22:12:29  <isaacs>right, becasue we ... for SyntaxErrors
22:13:26  <piscisaureus_>isaacs: I think the "node -pe" is because you are running the wrong node version
22:13:33  <piscisaureus_>isaacs: try ./node :-)
22:13:50  <isaacs>oh, hahah
22:13:51  <isaacs>right
22:13:54  <isaacs>k, that works
22:14:03  <isaacs>also, the test should compare against null, not -1
22:14:07  <isaacs>match/indexOf
22:14:10  <isaacs>JavaScript = hard
22:14:49  <CIA-108>node: isaacs reviewme * r197b47c / test/simple/test-require-json.js : Fix test-require-json on Windows - http://git.io/Bbd8ag
22:15:12  * isaacsshould just configure vim to push to +reviewme on every save
22:16:05  <piscisaureus_>isaacs: lgtm. Fails on 0.8.1, and passes on 0.8.2 for me
22:16:12  <isaacs>sweet
22:16:28  <CIA-108>node: isaacs v0.8.2-release * rc4e9226 / test/simple/test-require-json.js : Fix test-require-json on Windows - http://git.io/So16yQ
22:16:29  <CIA-108>node: isaacs v0.8.2-release * rcc6084b / (AUTHORS ChangeLog src/node_version.h): 2012.07.09, Version 0.8.2 (Stable) - http://git.io/Aa7hlA
22:17:17  <isaacs>ok, i'm gonna go get some lunch and sunshine.
22:17:27  <isaacs>have fun :)
22:18:52  <tjfontaine>piscisaureus_: have any thoughts on https://github.com/joyent/node/pull/3655
22:19:21  <tjfontaine>most specicifically https://github.com/joyent/node/pull/3655#issuecomment-6813775
22:20:47  <piscisaureus_>tjfontaine: well, not on beforehand
22:21:00  * mikealquit (Quit: Leaving.)
22:22:24  * paddybyersquit (Quit: paddybyers)
22:24:59  * rendarquit
22:26:31  * mikealjoined
22:26:32  * mikealquit (Remote host closed the connection)
22:44:10  * hzquit
22:54:15  * AndreasMadsenquit (Remote host closed the connection)
23:00:45  * paddybyersjoined
23:09:48  * theColequit (Quit: theCole)
23:29:36  * paddybyersquit (Quit: paddybyers)
23:44:23  <indutny>whoa
23:44:25  <indutny>it works
23:47:15  <piscisaureus_>writing my own control flow library
23:47:18  <piscisaureus_>because everybody has
23:49:13  <indutny>hahaha
23:49:25  <indutny>well, can't say that I'm doing something cool like this
23:49:30  <indutny>but have you reviewed my code anyway? :)
23:50:31  <indutny>piscisaureus_: https://github.com/joyent/node/pull/3661
23:50:32  <indutny>?
23:51:02  <indutny>is ben chilling out today?
23:51:10  <indutny>glad that someone is visiting realworld :)
23:51:14  <piscisaureus_>indutny: it's saturday 2am
23:51:21  <piscisaureus_>or sunday, technically
23:51:27  <piscisaureus_>indutny: I hope so for ben
23:52:05  <indutny>ooy
23:52:14  <indutny>TZ sucks, you know
23:53:13  <piscisaureus_>indutny: yeah.
23:53:30  <piscisaureus_>indutny: I will really review your code some time
23:54:00  <piscisaureus_>indutny: although I don't know this part of node too well
23:54:28  <indutny>well, would be cool if you'll just build it
23:54:31  <indutny>and test on windows ;)
23:55:16  <indutny>piscisaureus_: ^
23:57:31  <piscisaureus_>indutny: so is there a test?
23:57:35  <piscisaureus_>indutny: also,
23:57:35  <piscisaureus_>src\node_crypto.cc(36): fatal error C1083: Cannot open include file: 'arpa/inet
23:57:35  <piscisaureus_>.h': No such file or directory [C:\Users\Administrator\Desktop\node\node.vcxpro
23:57:35  <piscisaureus_>j]
23:57:35  <piscisaureus_> node_javascript.cc
23:57:42  <indutny>ooooooooooh
23:57:45  <indutny>my zosh
23:57:45  <piscisaureus_>indutny: I suppose that include is not needed
23:57:49  <indutny>ntohl
23:57:52  <indutny>ntohs
23:57:58  <indutny>what are they on windows?
23:58:36  <indutny>piscisaureus_: http://msdn.microsoft.com/en-us/library/windows/desktop/ms740069(v=vs.85).aspx ?
23:59:20  <piscisaureus_>indutny: just include uv.h
23:59:37  <indutny>piscisaureus_: ah, ok
23:59:47  <piscisaureus_>indutny: so, what should I test
23:59:50  <piscisaureus_>indutny: it builds, sure