00:03:00  <CIA-112>node: Bert Belder master * r8a52a16 / (tools/msvs/res/node.rc tools/msvs/res/node.ico): windows: add icon to node.exe - http://git.io/rc5ofQ
00:05:20  * toothrjoined
00:07:13  <isaacs>piscisaureus_: neato
00:07:32  <piscisaureus_>isaacs: well the icon could be made to look better :-)
00:08:08  <piscisaureus_>isaacs: maybe I can have our designer do it
00:08:35  <piscisaureus_>conceptually it should of course be the same but it needs some borders and tweaking to look good at all sizes
00:29:37  * AvianFluquit (Ping timeout: 244 seconds)
00:40:13  <CIA-112>node: Matt Gollob master * r9fe39ed / (4 files in 2 dirs): windows: don't install x64 version into the 'program files (x86)' folder - http://git.io/hyDsqQ
00:40:42  * TooTallNatejoined
00:47:24  * TooTallNatequit (Quit: Linkinus - http://linkinus.com)
00:54:07  * AvianFlujoined
00:55:46  * dapquit (Quit: Leaving.)
01:01:21  <DrPizza>man this process.nextTick stuff...
01:01:32  <DrPizza>motherfuckers need to learn to love some fucking threads/processes, yo
01:02:07  <AvianFlu>yeah, everybody needs to chill
01:02:23  <AvianFlu>I've got a lib that that could potentially break, but I'm gonna wait and see and fix it later
01:02:37  <AvianFlu>cause like, wtf, I have a job, I can't just bikeshed around in a circle about it
01:10:30  <CIA-112>node: Simon Sturmer master * r9a998d5 / lib/http.js : http: don't lowercase http req header until later - http://git.io/4ihmzQ
01:11:59  <CIA-112>libuv: Bert Belder master * r961e0cf / src/win/tty.c : windows/tty: never report error after forcibly aborting line-buffered read - http://git.io/jSrW8A
01:12:01  <CIA-112>libuv: Bert Belder v0.6 * rdbe681e / src/win/tty.c : windows/tty: never report error after forcibly aborting line-buffered read - http://git.io/qD_nSA
01:13:50  * travis-cijoined
01:13:50  <travis-ci>[travis-ci] joyent/libuv#357 (v0.6 - dbe681e : Bert Belder): The build is still failing.
01:13:50  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/cd69ea9...dbe681e
01:13:50  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1504588
01:13:50  * travis-cipart
01:14:10  * travis-cijoined
01:14:10  <travis-ci>[travis-ci] joyent/libuv#356 (master - 961e0cf : Bert Belder): The build was fixed.
01:14:10  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/38a6f9f...961e0cf
01:14:10  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1504585
01:14:10  * travis-cipart
01:23:45  * avalanche123quit (Quit: Computer has gone to sleep.)
01:30:58  * c4milojoined
01:56:02  * isaacsquit (Remote host closed the connection)
01:58:16  * pieternquit (Quit: pietern)
02:05:57  * piscisaureus_quit (Quit: ~ Trillian Astra - www.trillian.im ~)
02:07:03  * vtjnashjoined
02:10:24  * perezdjoined
02:13:16  * sj26quit (Quit: Rainbows!)
02:14:38  * piscisaureus_joined
02:14:39  * piscisaureus_quit (Client Quit)
02:20:29  * perezdquit (Quit: perezd)
02:21:34  * avalanche123joined
02:23:51  * bnoordhuisquit (Ping timeout: 240 seconds)
02:25:52  * brsonquit (Quit: leaving)
02:29:58  * iraquit (Quit: Computer has gone to sleep.)
02:33:57  * irajoined
02:39:31  * loladirojoined
03:02:29  * c4miloquit (Remote host closed the connection)
03:03:30  * iraquit (Quit: Computer has gone to sleep.)
04:24:11  * indexzerojoined
05:14:05  <CIA-112>node: Fedor Indutny master * r0262b6d / doc/api/child_process.markdown : child_process: new stdio API for .spawn() method - http://git.io/yKI7DA
05:21:37  * isaacsjoined
05:32:11  <CIA-112>node: isaacs master * rcbdf339 / (167 files in 13 dirs): Upgrade v8 to 3.11.7 - http://git.io/B4lirA
05:32:11  <CIA-112>node: isaacs master * r7946ad2 / deps/v8/build/common.gypi : v8: Floating patches - http://git.io/kkpNnw
05:32:12  <CIA-112>node: Ben Noordhuis master * reabf3c8 / deps/v8/src/debug-agent.cc : v8: debug: fix error handling in SendConnectMessage() - http://git.io/tdCdVw
05:32:12  <CIA-112>node: isaacs master * re0f5d8e / test/message/undefined_reference_in_new_context.out : test: v8 stack trace messages changed slightly - http://git.io/1sgGkA
05:32:19  * isaacsquit (Remote host closed the connection)
05:42:09  * ericktquit (Quit: erickt)
05:54:49  * AvianFluquit (Quit: leaving)
05:57:10  * vtjnashquit (Remote host closed the connection)
06:30:22  * isaacsjoined
06:30:35  * isaacsquit (Remote host closed the connection)
06:34:09  * loladiroquit (Quit: loladiro)
06:38:40  * AvianFlujoined
06:44:52  * indexzeroquit (Read error: Connection reset by peer)
06:45:16  * indexzerojoined
06:45:23  * indexzeroquit (Client Quit)
07:13:23  * paddybyersjoined
07:46:54  * mikealjoined
07:50:38  * AvianFluquit (Quit: leaving)
07:54:52  * rendarjoined
07:56:25  * mikealquit (Quit: Leaving.)
07:58:53  * paddybyersquit (Quit: paddybyers)
08:22:13  * japjjoined
08:28:31  * paddybyersjoined
10:53:19  * japjquit (Ping timeout: 265 seconds)
10:54:32  * japjjoined
10:56:29  * paddybyersquit (Quit: paddybyers)
11:00:14  * japjquit (Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/)
11:00:39  * japjjoined
11:17:15  * `3rdEdenjoined
11:26:44  * `3rdEdenquit (Quit: Leaving...)
11:28:11  * TheJHjoined
11:29:45  * paddybyersjoined
11:39:19  * paddybyersquit (Quit: paddybyers)
12:32:05  * `3rdEdenjoined
12:36:37  * piscisaureus_joined
12:46:25  * TheJHquit (Ping timeout: 265 seconds)
12:53:40  * irajoined
12:57:40  * `3rdEdenquit (Quit: Leaving...)
13:00:25  * AndreasMadsenjoined
13:09:23  * AndreasMadsenquit (Remote host closed the connection)
13:12:06  * AndreasMadsenjoined
13:19:17  * TheJHjoined
13:54:41  * theColejoined
14:03:41  <CIA-112>node: Bert Belder master * r4704d62 / deps/uv/src/win/tty.c : windows/tty: never report error after forcibly aborting line-buffered read - http://git.io/xDVaNQ
14:03:41  <CIA-112>node: Bert Belder master * rddb215d / (170 files in 16 dirs): Merge branch 'master' of github.com:joyent/node - http://git.io/E3HRVA
14:03:41  <CIA-112>node: Bert Belder master * r167fd5c / deps/v8/build/common.gypi : Unbreak the Windows build - http://git.io/CGmFWw
14:07:27  <CIA-112>node: Bert Belder master * r3b6a00b / deps/v8/build/common.gypi : Unbreak the Windows build - http://git.io/0LeSMQ
14:42:24  * iraquit (Quit: Leaving...)
15:07:24  * vtjnash_joined
15:11:29  <piscisaureus_>http://www.cracked.com/article/153_nuke-moon-5-certifiably-insane-cold-war-projects/
15:32:28  * loladirojoined
15:37:40  <CIA-112>libuv: Bert Belder master * r3ab2bc6 / (2 files in 2 dirs): windows: fix NTSTATUS redefined when compiling with MinGW - http://git.io/3cGYYw
15:38:17  <indutny>piscisaureus_: haha
15:38:17  <indutny>nice
15:38:20  * irajoined
15:39:32  * travis-cijoined
15:39:33  <travis-ci>[travis-ci] joyent/libuv#358 (master - 3ab2bc6 : Bert Belder): The build was broken.
15:39:33  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/961e0cf...3ab2bc6
15:39:33  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1509157
15:39:33  * travis-cipart
15:40:24  <CIA-112>libuv: Bert Belder master * r120d997 / src/win/winapi.h : windows: fix NTSTATUS redefined when compiling with MinGW - http://git.io/yC01XA
15:40:42  * perezdjoined
15:42:21  * travis-cijoined
15:42:21  <travis-ci>[travis-ci] joyent/libuv#359 (master - 120d997 : Bert Belder): The build is still failing.
15:42:21  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/3ab2bc6...120d997
15:42:21  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1509266
15:42:21  * travis-cipart
15:42:51  <piscisaureus_>indutny: I bet you could write the same article about the USSR tho :-)
15:42:57  <indutny>hahahah
15:43:00  <indutny>I do not know much
15:43:12  <indutny>there're a lot of abandoned bases around
16:00:07  * iraquit (Quit: Computer has gone to sleep.)
16:00:26  * paddybyersjoined
16:18:29  <indutny>s/look/discuss
16:18:40  <indutny>piscisaureus_: wanna discuss stdio /dev/null stuff?
16:18:56  <piscisaureus_>indutny: alright
16:19:11  <indutny>piscisaureus_: so I'm going to create socketpairs() for stdio < 3
16:19:20  <indutny>if flag == UV_IGNORE
16:19:27  <piscisaureus_>indutny: hmm
16:19:30  <indutny>I think that's actually the only thing that's needed
16:19:31  <indutny>no?
16:19:37  <indutny>should I open tty?
16:19:42  <piscisaureus_>indutny: if the user specifies 'ignore' then it doesn't care, right
16:20:02  <piscisaureus_>indutny: it's just that the absence of fd 2 might fuck up the program
16:20:05  <indutny>piscisaureus_: well, I'll create socketpairs in child
16:20:14  <piscisaureus_>indutny: so i'd say, open '/dev/null' and dup that to the fd
16:20:26  <indutny>ah, ok
16:20:43  <piscisaureus_>indutny: that's also more inline with what your doc specifies
16:21:21  <piscisaureus_>indutny: "Open the fd in the child, but do not expose it to the parent"
16:21:26  <piscisaureus_>indutny: we should actually open it :-)
16:21:47  <piscisaureus_>indutny: so maybe we can just always open /dev/null if the user says "ignore"
16:22:06  <indutny>yeah
16:22:30  <piscisaureus_>indutny: and if the users says that the number of fds < 3 then we *also* open /dev/null for the fds up to 3
16:22:38  <piscisaureus_>that sounds reasonable
16:22:47  <piscisaureus_>er, up to 2 :-)
16:22:49  <indutny>piscisaureus_: hm... Is it correct thing to do?
16:22:58  <indutny>open('/dev/null', ...)
16:23:26  <piscisaureus_>open('/dev/null', O_RDWR) ?
16:23:33  <indutny>fd = open("/dev/tty", O_WRONLY);
16:23:37  <indutny>may be that?
16:23:56  <piscisaureus_>well, that's not guaranteed to work, right?
16:24:08  <indutny>why not?
16:24:13  <indutny>tty is truly unix stuff
16:24:16  <indutny>AFAIK
16:24:23  <piscisaureus_>yeah that's true, too
16:24:45  <piscisaureus_>indutny: if the user setsid()s then it don't work afaik
16:24:50  <indutny>yes
16:24:51  <piscisaureus_>unless he also opens a pty
16:24:55  <indutny>ok, /dev/null sounds good to me
16:25:05  <indutny> /dev/tty will be propagated to currently opened tty
16:25:11  <indutny>so it isn't really UV_IGNORE
16:25:13  <piscisaureus_>indutny: yes I know
16:25:20  <piscisaureus_>indutny: we could also add an option for that :-p
16:25:24  <indutny>what about commit access to libuv?
16:25:26  <indutny>haha
16:25:29  <indutny>no
16:25:42  <indutny>it's already complex
16:25:43  <piscisaureus_>indutny: but let's not bikeshed and make sure what we have works correctly first
16:25:45  <piscisaureus_>:-)
16:25:47  <piscisaureus_>yep
16:26:05  <indutny>:)
16:26:10  <piscisaureus_>indutny: I am down with giving you commit access for libuv but I have no admin rights at @joyent
16:26:30  <piscisaureus_>indutny: yesterday I pinged isaacs but he was absent, and later i forgot
16:26:53  <indutny>ah
16:26:56  <indutny>np
16:27:03  <indutny>you have commit rights, so that doesn't really matter
16:27:07  <piscisaureus_>indutny: yeah
16:27:13  <piscisaureus_>indutny: I will ping him again
16:27:59  <japj>isn't that's what ircretary is here for? ;)
16:28:29  <indutny>indeed
16:28:33  <indutny>but who cares :P
16:29:28  <japj>piscisaureus_: btw, I noticed the node.exe now has an icon ;)
16:29:45  <piscisaureus_>japj: you are good with photoshop? make it nicer :-)
16:30:02  <piscisaureus_>japj: otherwise I will ask our designer
16:30:28  <indutny>piscisaureus_: lets put kitten into it
16:30:29  <japj>piscisaureus_: photoshop? no.. I'm not a designer.
16:30:40  <piscisaureus_>ghe
16:30:43  <indutny>piscisaureus_: or cheburashka
16:30:48  <indutny>with hexagonal ears
16:30:53  <piscisaureus_>what's that?
16:31:00  <indutny>piscisaureus_: https://www.google.com/search?q=cheburashka&hl=ru&prmd=imvns&source=lnms&tbm=isch&ei=kT_KT7_TFKbV4QSvoqH4Dw&sa=X&oi=mode_link&ct=mode&cd=2&ved=0CD0Q_AUoAQ&biw=1440&bih=752
16:31:54  <japj>does substack draw icons too?
16:33:00  <indutny>please no
16:33:10  <japj>piscisaureus_: btw, was the wix cleanup patch ok now?
16:33:32  <piscisaureus_>ghe
16:33:44  <piscisaureus_>japj, I didn't see it yet
16:34:04  <piscisaureus_>I am finally pulling in mscdex' cpu times patch
16:35:25  <piscisaureus_>japj: I suppose you tested it and it worked correctly for both x86 and x64 ?
16:35:31  <piscisaureus_>japj: it looks good to me
16:38:07  * c4milojoined
16:39:43  <indutny>piscisaureus_: ready to pull some awesomeness into libuv? :)
16:39:52  * c4miloquit (Remote host closed the connection)
16:40:23  <japj>piscisaureus_: yeah, I haven't tested the digital signing, but I updated the filename references, so that should be ok I think. The only thing that could be 'improved' here is to add "-pre" in the msi name if it's not released yet, but that needs a bit of extra work if we want it
16:40:35  * theColequit (Quit: theCole)
16:40:43  <piscisaureus_>japj: let's do it in steps
16:40:59  <japj>piscisaureus_: yes, I like (small) steps instead of a big bang <oops>
16:41:07  <piscisaureus_>japj: we don't really build prerelease msi's anyway, so that's merely a nice ot have
16:41:22  <piscisaureus_>but released installers should include the platform imho, especially if there are multiple
16:41:34  <CIA-112>node: Jeroen Janssen master * re2126e0 / (3 files in 2 dirs): windows/msi: cleanup WiX project files - http://git.io/4Brkaw
16:41:37  <piscisaureus_>jap: ^
16:41:41  <japj>piscisaureus_: yes, but it would be nice if someone is building their own msi files it doesn't get mislabeled as 'official'
16:41:54  <piscisaureus_>yeah, exactly
16:41:59  <japj>piscisaureus_: the node.exe version does contain -pre though, so atleast that is easy to spot
16:42:01  <indutny>piscisaureus_: your turn https://github.com/joyent/libuv/pull/441
16:42:02  <indutny>;)
16:42:18  <piscisaureus_>japj: yeah, so if you wanna send a patch, be my guest :-)
16:42:30  * TheJHquit (Ping timeout: 244 seconds)
16:43:52  <japj>piscisaureus_: I first want to look at the other stuff we want in the MSI, from all the issue discussions on github I guess the first thing would probably be a selectable destination install directory
16:43:52  <piscisaureus_>indutny: so what happens if I set 'ignore' for fd 4 ?
16:43:58  <indutny>piscisaureus_: btw, it'll reuse parent's stdio if they're UV_IGNOREd in uv_spawn
16:44:29  <indutny>piscisaureus_: [0,1,2, 'ignore'] === [0,1,2]
16:44:53  <piscisaureus_>indutny: that's okay but not in line with your docs :-)
16:45:02  <indutny>piscisaureus_: node docs/
16:45:03  <indutny>?
16:45:13  <indutny>aaah
16:45:14  <indutny>yeah
16:45:20  <indutny>I'll fix that
16:46:26  <piscisaureus_>indutny: you're also leaking fds now
16:47:47  <indutny>huh?
16:47:50  <indutny>where?
16:47:53  <indutny>"btw, I also starting to think that github's pull requests are generally bad idea
16:47:54  <indutny>23:46:26 <indutny> patches+emails seems to be much better to me"
16:48:02  <indutny>internet disconnected ^
16:48:43  <loladiro>piscisaureus_: Since It's now possible to give already created streams to uv_spawn, what's your opinion on creating a uv_create_pipe(uv_pipe_t* a, uv_pipe_t* b) method that explicitly initializes the pipe, rather than doing in implicitly in uv_spawn. That would be very helpful for integrating libuv with Julia. Thoughts?
16:49:15  <piscisaureus_>loladiro: a moment, i'll be back in 2 minutes.
16:49:41  <loladiro>sure
16:49:47  <indutny>piscisaureus_: "2. `'ignore'` - Open the fd in the child for 0,1,2 stdios, do not do anything
16:49:48  <indutny> for others." ?
16:49:53  <indutny>is it good enough?
16:49:58  * indutnydoes engrish
16:50:17  <indutny>or better "for others - do not do anything"
16:51:11  * perezd_joined
16:51:20  * perezd_quit (Client Quit)
16:51:28  * perezdquit (Ping timeout: 265 seconds)
16:53:18  * \toothrotjoined
16:55:15  <piscisaureus_>indutny: just say "don't do anything"
16:55:21  * toothrquit (Ping timeout: 240 seconds)
16:55:23  <indutny>haha
16:55:24  <indutny>ok
16:55:25  * \toothrotchanged nick to toothr
16:55:36  <indutny>so just "Open the fd in the child for 0,1,2 stdios
16:56:17  <indutny>piscisaureus_: right
16:56:18  <indutny>?
16:56:55  <piscisaureus_>indutny: "ignore: don't open the file descriptor in the child process"
16:57:07  <piscisaureus_>loladiro: we could do that but there are some caveats
16:57:16  <indutny>but it will for 0,1,2
16:57:25  <piscisaureus_>loladiro: the reason that we have this slightly awkward api is mainly windows
16:58:45  <piscisaureus_>loladiro: there are basically 3 modes for every pipe end, namely (1) the current process is going to use it, (2) the child process is going to use it, and the child process uses libuv, and (3) the child process is going to use it, and the child process could be anything
16:59:37  <piscisaureus_>loladiro: uv_spawn knows which end is going to be used locally etc, so it can pick the most optimal mode
17:00:05  <piscisaureus_>loladiro: but if you have uv_create_pipe then it knows nothing, so there's no way to decide which mode to use
17:00:23  <piscisaureus_>so we'd have to pick mode 3 (the "safe" mode) always
17:00:42  <piscisaureus_>loladiro: which is not optimal but if it serves your purpose, sure
17:01:59  <loladiro>The use case we have in mind is piping one command to (possibly multiple) others directly through the uv_spawn API. Do you have any other idea how to make this more libuv-friendly?
17:02:07  <vtjnash_>(I'm working with loladiro on this) that would be the goal, since in julia we want a pipe that can be used (and reused) for anything
17:02:52  <piscisaureus_>loladiro: hmm, not really.
17:03:13  <piscisaureus_>loladiro: I think using the "safe" mode always is the only option we would have, then
17:04:02  <piscisaureus_>loladiro: with the caveat that if you decide to use one end in julia, there would have been a more optimal way to use
17:04:04  <piscisaureus_>er
17:04:23  <vtjnash_>we could providing hinting to uv_create_pipe
17:04:26  <loladiro>Well, we know when we use one end in Julia and when we don't
17:04:29  <vtjnash_>on the usage of the ends of the pipe
17:04:49  <loladiro>so, we could use uv_create_pipe when it's only child process and otherwise let uv_spawn handle it
17:05:04  <piscisaureus_>yeah, that'd work
17:05:20  <piscisaureus_>I'd say, stub out an api for libuv
17:05:30  <piscisaureus_>most likely it's going to be easy
17:05:54  <loladiro>sure. vtjnash_ , do you want to do that or do you want me to?
17:06:13  <piscisaureus_>indutny: don't do that -> https://github.com/indutny/libuv/blob/250544e92604bc6b691504b67d3da67c12dcd01b/src/unix/process.c#L332
17:06:19  <vtjnash_>loladiro: I'll take a look
17:06:51  <loladiro>vtjnash_: Sounds good. piscisaureus_: Thank you for your insights
17:07:18  <piscisaureus_>indutny: the child shouldn't inherit the fd. Just ignore, or even close it.
17:07:32  <indutny>piscisaureus_: hm
17:07:42  <piscisaureus_>indutny: also, https://github.com/indutny/libuv/blob/250544e92604bc6b691504b67d3da67c12dcd01b/src/unix/process.c#L339
17:07:46  <piscisaureus_>indutny: use_fd is leaked here
17:07:50  <indutny>that came from original code
17:08:03  <piscisaureus_>indutny: yeah, so the original code was broken heh :0
17:08:09  <indutny>hahaha
17:08:11  <indutny>well, ok
17:08:15  <indutny>how is it leaking here?
17:08:22  <indutny>use_fd === -1 at that line
17:08:55  <indutny>should I close child's stdin/stdout/stderr ?
17:09:10  <piscisaureus_>indutny: well
17:09:10  <piscisaureus_>fd = open("/dev/null") // fd 25 -> /dev/null
17:09:10  <piscisaureus_>dup2(fd, 1); // fd 25 and fd 1 -> /dev/null
17:09:15  <indutny>ah, I can't
17:09:24  <indutny>aaaaah
17:09:26  <piscisaureus_>indutny: now the child process has fd 25 open as well :-)
17:09:26  <indutny>yes
17:09:41  <indutny>ok
17:09:59  <piscisaureus_>indutny: also, it would be good to check return values :-)
17:09:59  <indutny>so close or ignore for former issue?
17:10:05  <indutny>piscisaureus_: I'm checking
17:10:13  <indutny>there is an assertion below
17:10:30  <piscisaureus_>indutny: yes, but the assertion only works in debug mode
17:10:51  <indutny>well, that's in the child process anyway
17:10:57  <indutny>what can we do?
17:11:00  <indutny>_exit(127) ?
17:11:05  <piscisaureus_>indutny: yeah
17:11:22  <piscisaureus_>indutny: we can also do some trickery and make child_process.spawn() emit an error
17:11:31  <indutny>piscisaureus_: ok, that may be done later
17:11:35  <indutny>piscisaureus_: what about first issue?
17:11:37  <indutny>piscisaureus_: close or ignore?
17:12:03  <piscisaureus_>indutny: close. It doesn't matter much, close is the most defensive strategy
17:12:35  <piscisaureus_>indutny: (but if we didn't fuck up then the fd, if open, should have the CLOEXEC flag set anyway)
17:13:26  <indutny>hm...
17:13:33  <indutny>well, I think we should ignore it, actually
17:13:41  <indutny>it's for fd > 2
17:14:00  <indutny>stdio_count may be < 3 and we won't touch them anyway
17:14:04  <indutny>so lets be consistent
17:14:25  <indutny>piscisaureus_: ok?
17:14:36  <piscisaureus_>ok
17:18:51  * theColejoined
17:19:46  <indutny>piscisaureus_: force pushed
17:24:12  * loladiroquit (Quit: loladiro)
17:26:10  * loladirojoined
17:26:29  * vtjnash_changed nick to vtjnash
17:26:43  * vtjnashquit
17:35:53  <indutny>piscisaureus_: how is it going?
17:35:57  * TheJHjoined
17:36:23  <piscisaureus_>indutny: doing something else. didn't look yet. You need me to look at it now?
17:36:28  <indutny>piscisaureus_: no
17:36:31  <indutny>just reminding
17:36:32  <indutny>np
17:48:48  * TheJHquit (Ping timeout: 260 seconds)
17:51:23  * isaacsjoined
17:55:22  <indutny>isaacs: heya
17:55:30  <indutny>isaacs: can I get commit acces to libuv?
17:55:53  <indutny>:)
17:57:21  * paddybyersquit (Quit: paddybyers)
17:58:37  * ircretaryquit (Ping timeout: 250 seconds)
17:58:37  * ircretaryjoined
18:02:42  * paddybyersjoined
18:02:48  * paddybyersquit (Client Quit)
18:04:29  * xaqjoined
18:09:23  <CIA-112>libuv: Brian White master * r87f3530 / (src/win/winapi.c src/win/winapi.h): windows: retrieve NtQuerySystemInformation at startup - http://git.io/ujfQRQ
18:09:23  <CIA-112>libuv: Brian White master * r4252240 / (src/win/core.c src/win/internal.h): windows: add uv__once_init() that ensures that libuv has been initialized - http://git.io/Q2QcwA
18:09:23  <CIA-112>libuv: Bert Belder master * r1d64a36 / src/win/util.c : windows: add support for cpu times to uv_cpu_info() - http://git.io/Ev3dEA
18:11:22  * travis-cijoined
18:11:22  <travis-ci>[travis-ci] joyent/libuv#360 (master - 1d64a36 : Bert Belder): The build is still failing.
18:11:22  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/120d997...1d64a36
18:11:22  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1510407
18:11:22  * travis-cipart
18:18:55  * isaacsquit (Remote host closed the connection)
18:35:50  * arlolrajoined
18:36:00  <indutny>oook
18:38:01  <CIA-112>libuv: Bert Belder master * rcd1298c / src/win/core.c : windows: retrieve function pointers before doing anything else - http://git.io/mnhsdw
18:38:01  <CIA-112>libuv: Bert Belder master * rec95a07 / (src/win/core.c src/win/internal.h src/win/util.c): windows/util: move initialization code to uv__util_init - http://git.io/sVTb3A
18:38:01  <CIA-112>libuv: Bert Belder master * rd21fc6c / (src/win/timer.c src/win/util.c): windows: move uv_hrtime() to util.c - http://git.io/3a5wtA
18:38:04  * mikealjoined
18:39:53  * travis-cijoined
18:39:53  <travis-ci>[travis-ci] joyent/libuv#361 (master - d21fc6c : Bert Belder): The build is still failing.
18:39:53  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/1d64a36...d21fc6c
18:39:53  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1510654
18:39:53  * travis-cipart
18:42:49  * mikealquit (Client Quit)
18:49:57  * mikealjoined
18:52:23  * arlolraquit (Quit: Linkinus - http://linkinus.com)
18:54:46  * xaqquit (Ping timeout: 244 seconds)
19:06:00  <CIA-112>libuv: Bert Belder master * r619686e / src/win/process.c : windows: fix fall-through bug in init_child_stdio() - http://git.io/uDGEDA
19:07:56  * travis-cijoined
19:07:56  <travis-ci>[travis-ci] joyent/libuv#362 (master - 619686e : Bert Belder): The build is still failing.
19:07:56  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/d21fc6c...619686e
19:07:56  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1510942
19:07:56  * travis-cipart
19:13:04  <CIA-112>libuv: Bert Belder master * r4a07b8b / test/test-poll.c : test-poll: make spurious wakeup detection slightly less strict - http://git.io/FXGNVw
19:14:50  <CIA-112>libuv: Bert Belder reviewme * rff13817 / src/win/process.c : windows: always set FDs 0-2 in the spawned child processes - http://git.io/VVsuaA
19:14:54  * travis-cijoined
19:14:54  <travis-ci>[travis-ci] joyent/libuv#363 (master - 4a07b8b : Bert Belder): The build is still failing.
19:14:54  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/619686e...4a07b8b
19:14:54  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511036
19:14:54  * travis-cipart
19:15:07  <piscisaureus_>^-- indutny: the windows side of things
19:15:19  * TheJHjoined
19:16:25  <CIA-112>libuv: Bert Belder reviewme * rf0dc7bc / src/win/process.c : windows: always set FDs 0-2 in the spawned child processes - http://git.io/2SteEQ
19:16:43  * mikealquit (Quit: Leaving.)
19:16:44  * travis-cijoined
19:16:45  <travis-ci>[travis-ci] joyent/libuv#364 (reviewme - ff13817 : Bert Belder): The build is still failing.
19:16:45  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/8a42c43...ff13817
19:16:45  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511039
19:16:45  * travis-cipart
19:17:51  <CIA-112>libuv: Bert Belder reviewme * rbdb8b3a / src/win/process.c : windows: always set FDs 0-2 for spawned child processes - http://git.io/MxTmyw
19:17:54  <indutny>good
19:18:18  * travis-cijoined
19:18:18  <travis-ci>[travis-ci] joyent/libuv#365 (reviewme - f0dc7bc : Bert Belder): The build is still failing.
19:18:18  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/ff13817...f0dc7bc
19:18:18  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511042
19:18:18  * travis-cipart
19:19:40  * travis-cijoined
19:19:40  <travis-ci>[travis-ci] joyent/libuv#366 (reviewme - bdb8b3a : Bert Belder): The build is still failing.
19:19:40  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/f0dc7bc...bdb8b3a
19:19:40  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511049
19:19:40  * travis-cipart
19:22:00  <indutny>going to sleep
19:22:00  <indutny>ttyl
19:25:23  <piscisaureus_>ttyl
19:33:36  <japj>piscisaureus_: btw, should the installer spell Node.js or node.js?
19:33:51  <piscisaureus_>japj: *shrug* whatever you think is nicest :-)
19:34:08  <piscisaureus_>japj: I would do lowercase I think
19:35:09  <japj>piscisaureus_: I've been going back and forth on trying to wrap my head around wix, and I am now at a point where I restarted again and made a start menu folder with a link to node.js, website and uninstaller (yeah I needed the uninstaller lots of times)
19:35:22  <japj>piscisaureus_: but the folder name is then also lowercase
19:35:35  <piscisaureus_>japj: yeah the folder name should be lowercase for sure
19:36:29  <japj>piscisaureus_: well, it seems for all other programs atleast the startmenu folder name starts with an uppercase, so this looks very weird with node.js being lowercase there (but I don't mind it, just looks a bit weird)
19:36:32  <CIA-112>libuv: Bert Belder master * rbdb8b3a / src/win/process.c : windows: always set FDs 0-2 for spawned child processes - http://git.io/MxTmyw
19:36:32  <CIA-112>libuv: Fedor Indutny master * r512869b / (test/run-tests.c test/test-list.h test/test-spawn.c): test: stdin/out/err should be set to /dev/null when ignored - http://git.io/1_8uDw
19:36:58  <piscisaureus_>japj: oh, the start menu hmmm
19:37:10  <piscisaureus_>japj: I think the program files folder name should be lower case
19:37:28  <piscisaureus_>japj: but if you think the start menu folder looks better capitalized, do that
19:37:36  <japj>piscisaureus_: yeah, but the program files folder name is also nodejs and not node.js
19:37:41  <piscisaureus_>japj: nice work, btw
19:37:45  <piscisaureus_>japj: ok, right
19:38:24  * travis-cijoined
19:38:24  <travis-ci>[travis-ci] joyent/libuv#367 (master - 512869b : Fedor Indutny): The build is still failing.
19:38:24  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/4a07b8b...512869b
19:38:24  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511203
19:38:24  * travis-cipart
19:38:59  <japj>piscisaureus_: I've also been trying to use the advanced wix dialog where it is able to select destination dir and all users/just me, but that was a bit too much to try at once
19:39:35  <CIA-112>libuv: Fedor Indutny master * r1cd9642 / (test/run-tests.c test/test-list.h test/test-spawn.c): test: stdin/out/err should be set to /dev/null when ignored - http://git.io/LPcLEA
19:40:17  <piscisaureus_>japj: :-) hmm, yeah wix gives always gives me a headache.
19:40:25  <piscisaureus_>japj: gotta run now, bbl
19:40:39  <japj>bbl
19:41:30  * travis-cijoined
19:41:30  <travis-ci>[travis-ci] joyent/libuv#368 (master - 1cd9642 : Fedor Indutny): The build is still failing.
19:41:30  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/512869b...1cd9642
19:41:30  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511223
19:41:30  * travis-cipart
19:51:01  * paddybyersjoined
19:53:43  * TheJHquit (Quit: goodbye)
19:58:08  * TheJHjoined
19:58:44  * TheJHquit (Remote host closed the connection)
19:59:25  * TheJHjoined
19:59:26  * TheJHquit (Changing host)
19:59:26  * TheJHjoined
20:02:37  * TheJHquit (Remote host closed the connection)
20:03:03  * TheJHjoined
20:14:43  * paddybyersquit (Quit: paddybyers)
20:15:11  * mikealjoined
20:17:01  * c4milojoined
20:22:24  * brsonjoined
20:25:34  * AvianFlujoined
20:26:09  * ryahjoined
20:30:52  * japjquit (Ping timeout: 252 seconds)
20:36:13  * paddybyersjoined
20:37:06  <CIA-112>libuv: Bert Belder master * rc8a2452 / src/win/poll.c : windows: stop a poll watcher when watched socket is closed locally - http://git.io/WqBNkA
20:37:44  <CIA-112>libuv: Bert Belder master * rdd1355d / src/win/poll.c : windows: stop poll watcher when watched socket is closed locally - http://git.io/-wry0Q
20:38:59  * travis-cijoined
20:38:59  <travis-ci>[travis-ci] joyent/libuv#369 (master - c8a2452 : Bert Belder): The build is still failing.
20:38:59  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/1cd9642...c8a2452
20:38:59  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511577
20:38:59  * travis-cipart
20:39:36  * travis-cijoined
20:39:36  <travis-ci>[travis-ci] joyent/libuv#370 (master - dd1355d : Bert Belder): The build is still failing.
20:39:36  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/c8a2452...dd1355d
20:39:36  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1511580
20:39:36  * travis-cipart
20:43:12  * japjjoined
20:43:39  * AndreasMadsenquit (Remote host closed the connection)
20:43:44  <piscisaureus_>Every time I create a new file in src/win it feels kinda weird to put "Copyright Joyent" at the top
20:44:24  <piscisaureus_>because no joyent employee will ever change a even a single line of it
20:44:55  * AndreasMadsenjoined
20:55:25  * TheJHquit (Quit: goodbye)
21:04:20  * AvianFluquit (Quit: leaving)
21:09:20  * paddybyersquit (Quit: paddybyers)
21:15:20  * c4miloquit (Remote host closed the connection)
21:15:27  * c4milojoined
21:18:03  * TheJHjoined
21:18:24  * xaqjoined
21:19:53  * TheJHquit (Remote host closed the connection)
21:20:37  * AndreasMadsenquit (Remote host closed the connection)
21:22:05  <japj>piscisaureus_: https://github.com/joyent/node/pull/3363
21:22:33  * TheJHjoined
21:23:28  <japj>piscisaureus_: I also have a patch for the 64bit installers (in order to correctly support seperate upgrade paths in the future for 32/64bit MSI)
21:25:06  <piscisaureus_>japj: ah, that's nice :-)
21:25:57  <piscisaureus_>japj: will the difference between x86 and x64 also show up in the start menu, and in the add/remove programs list?
21:29:32  <japj>piscisaureus_: not yet, I'm not sure what the idea is with installing both x86 and x64 on the same machine
21:29:45  <piscisaureus_>me neither, actually
21:29:57  <piscisaureus_>although I can imagine that it could happen
21:30:02  <russfrank>a lot of programs will do that and have one shortcut be (x64) for disambiguation
21:30:31  <piscisaureus_>e.g you have a compiled addon that links to some 32-bit dll, then you need 32-bit node.exe
21:30:55  <piscisaureus_>japj: yeah I would not mind the start menu to be "Node.js (x64)"
21:31:04  <japj>russfrank: true, but we also add nodejs to the path, so that could mean that the last or first one installed 'wins' in the path
21:31:27  <piscisaureus_>japj: true, there's not much to do about that
21:31:29  <russfrank>maybe an 'activate for command line use' in the start menu folder?
21:31:35  <piscisaureus_>japj: although we could make that optional
21:31:58  <japj>piscisaureus_: the start menu folder or the link to node.exe (x64)?
21:32:08  <piscisaureus_>japj: either, I guess
21:32:22  <piscisaureus_>japj: I think the start menu folder
21:33:43  <japj>piscisaureus_: it might be nice to make a 'node.js command prompt' that has the correct paths set, that way you can have both 32 and 64 installed and not worry which one is first in PATH
21:34:08  <piscisaureus_>japj: yeah, that would be okay
21:34:21  <japj>piscisaureus_: and then we can remove the PATH registration part from the installer
21:34:36  <piscisaureus_>japj: well, I'd rather keep that part :-)
21:34:46  <piscisaureus_>japj: it's just so nice that you install the thing and it adds node to it
21:34:55  <piscisaureus_>japj: if possible we could make it optional
21:35:08  <japj>piscisaureus_: optional would be better
21:35:11  <piscisaureus_>like, have a checkbox or something that says "add node to your PATH"
21:35:28  <japj>piscisaureus_: if you install both 32 and 64 you probably don't want any of them added to the path by default
21:36:10  <piscisaureus_>japj: yeah, maybe
21:36:15  <piscisaureus_>optional +1
21:42:49  * loladiropart
21:52:54  * xaq_joined
21:56:31  * xaqquit (Ping timeout: 244 seconds)
21:59:57  * xaq__joined
22:01:23  * xaq_quit (Ping timeout: 260 seconds)
22:02:48  * xaq__quit (Remote host closed the connection)
22:03:14  * xaq_joined
22:03:35  * mikealquit (Quit: Leaving.)
22:06:16  * theColequit (Quit: theCole)
22:10:37  <CIA-112>libuv: Bert Belder master * red30365 / src/uv-common.h : uv-common: define INLINE macro - http://git.io/gQvBSA
22:10:37  <CIA-112>libuv: Bert Belder master * rd402604 / (17 files in 2 dirs): windows: inline a couple of inline request functions - http://git.io/YerX2Q
22:10:38  <CIA-112>libuv: Bert Belder master * rd8b95ea / (16 files in 2 dirs): windows: inline a couple of handle functions - http://git.io/W9CwQg
22:11:16  * piscisaureus_quit (Quit: ~ Trillian Astra - www.trillian.im ~)
22:12:35  * travis-cijoined
22:12:35  <travis-ci>[travis-ci] joyent/libuv#371 (master - d8b95ea : Bert Belder): The build is still failing.
22:12:35  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/dd1355d...d8b95ea
22:12:35  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1512030
22:12:35  * travis-cipart
22:12:42  * piscisaureus_joined
22:17:50  * xaqjoined
22:19:07  * rendarquit
22:20:21  <japj>piscisaureus_: do you want 2 links, one to nodejs.org and one to the docs?
22:20:30  * xaq_quit (Ping timeout: 252 seconds)
22:20:59  <japj>piscisaureus_: I was also thinking about maybe including the generated html files in the installer at some point
22:32:04  <piscisaureus_>japj: nodejs.org is not hard to find. If you include a link to the docs, that's probably fine
22:32:15  <piscisaureus_>japj: I am not sure about the dos
22:32:30  <piscisaureus_>er, I am not sure about including the docs. I will discuss that with other people next week.
22:32:52  <piscisaureus_>I'm checking out btw
22:33:06  <piscisaureus_>if you update PRs, I will see them tomorrow
22:35:55  <japj>piscisaureus_: I already added the url to the docs and updated the pull request
22:36:42  <piscisaureus_>ok, lemme try
22:36:46  <piscisaureus_>last thing I do today :-)
22:37:38  <japj>ditto ;)
22:39:18  * \toothrotjoined
22:40:08  <piscisaureus_>I should really do something about all those warnings when building node
22:40:19  <piscisaureus_>right now I have no clure which ones are serious and which ones aren't
22:40:36  <piscisaureus_>I have the feeling that there must be atleast some serious ones there (I know a few, even)
22:40:47  <piscisaureus_>NOT TODAY
22:40:57  * toothrquit (Ping timeout: 244 seconds)
22:41:01  <japj>nn
22:41:23  <piscisaureus_>nn?
22:41:46  <japj>nighty night ;)
22:41:57  <japj>oftewel... welterusten!
22:42:02  <piscisaureus_>dankje :-)
22:42:07  <piscisaureus_>ik land nog ff je pr denk ik
22:42:08  * AvianFlujoined
22:42:09  <piscisaureus_>alstie werkt
22:42:47  <japj>k
22:43:00  * japjquit (Remote host closed the connection)
22:43:42  * AvianFluquit (Client Quit)
22:44:16  <piscisaureus_>japj: lgtm, en werkt. Ik ben alleen bang dat er nu nog meer mensen komen die gaan van "hee, npm doet het niet"
22:44:27  <piscisaureus_>japj: dus een "node command prompt" link is welkom :-)
22:44:59  * AvianFlujoined
22:45:11  * AvianFluquit (Client Quit)
22:45:54  * bnoordhuisjoined
22:47:37  <CIA-112>node: Jeroen Janssen master * r9434487 / (tools/msvs/msi/nodemsi.wixproj tools/msvs/msi/product.wxs): windows/msi: add start menu links when installing - http://git.io/kb-Nuw
22:48:45  <piscisaureus_>That's it
22:48:51  <piscisaureus_>japj: thanks & ttyl
22:59:33  * Ariajoined
23:10:27  <piscisaureus_>ghe
23:10:32  <piscisaureus_>when I go, bnoordhuis comes
23:10:43  <bnoordhuis>i've been here for a bit
23:14:37  <piscisaureus_>bnoordhuis: anyway, good luck making yourself useful :-)
23:14:42  <piscisaureus_>later
23:14:45  <bnoordhuis>i'll try
23:14:47  <bnoordhuis>sleep tight
23:16:29  * mikealjoined
23:18:06  * theColejoined
23:19:12  <CIA-112>libuv: Ben Noordhuis master * r28ed730 / test/run-tests.c : test: fix implicit function declaration warnings - http://git.io/0xF5Dg
23:21:01  * travis-cijoined
23:21:01  <travis-ci>[travis-ci] joyent/libuv#372 (master - 28ed730 : Ben Noordhuis): The build was fixed.
23:21:01  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/d8b95ea...28ed730
23:21:01  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1512297
23:21:01  * travis-cipart
23:23:43  * irajoined
23:26:09  * isaacsjoined
23:32:39  * piscisaureus_quit (Quit: ~ Trillian Astra - www.trillian.im ~)
23:35:38  * xaqquit (Read error: Connection reset by peer)
23:35:52  * xaqjoined
23:40:56  * mikealquit (Quit: Leaving.)
23:41:10  * xaqquit (Ping timeout: 252 seconds)
23:41:29  * mikealjoined
23:42:00  * xaqjoined
23:43:14  * mikealquit (Client Quit)
23:55:38  * isaacsquit (Remote host closed the connection)
23:55:58  * brsonquit (Quit: leaving)