00:01:03  <txdv>it is in v0.6?
00:01:31  <bnoordhuis>txdv: yes
00:01:39  <txdv>but 7.8 is the newest
00:01:57  <txdv>if merges don't happen soon enough, shit gets really hard to do
00:02:18  <bnoordhuis>yeah... we're nearing 0.8.0 though
00:02:35  <bnoordhuis>which means 0.6 gets relegated to legacy with infrequent updates
00:03:50  <bnoordhuis>i'm probably going to hold off on upgrading c-ares a little longer, i think 1.8.0 is due this weekend
00:03:56  <bnoordhuis>piscisaureus: ^
00:04:10  <piscisaureus>bnoordhuis: It just got released, actually
00:04:28  <bnoordhuis>then i'll upgrade it tomorrow :)
00:04:29  <piscisaureus>bnoordhuis: announcement went out 4 hours ago
00:05:18  <txdv>nodejs or libuv?
00:05:50  <txdv>are the versions of nodejs and libuv synced now?
00:06:29  <bnoordhuis>txdv: libuv
00:06:41  <bnoordhuis>node uses what libuv in 0.6 uses
00:09:35  <txdv>bnoordhuis: are you developing on windows?
00:09:59  <bnoordhuis>txdv: only if i can't avoid it
00:10:21  <CIA-155>libuv: Bert Belder master * rc862acc / src/win/error.c : Windows: add mappings for UV_ENOENT - http://git.io/LvmGxA
00:10:22  <CIA-155>libuv: isaacs master * rb26fdde / src/unix/error.c : Map ENOMEM to UV_ENOMEM - http://git.io/Gapl_A
00:11:27  <piscisaureus>igorzi: 64 bit offset support has already ported to master, right?
00:11:33  <piscisaureus>igorzi: or is there still stuff missing?
00:14:35  * travis-cijoined
00:14:36  <travis-ci>[travis-ci] joyent/libuv#233 (master - c862acc : Bert Belder): The build is still failing.
00:14:36  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/109dcb2...c862acc
00:14:36  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1194519
00:14:36  * travis-cipart
00:15:51  <txdv>bnoordhuis: you told me once that testing a port is a syscall which is expensive, but isn't uv_bind + uv_listen as an blocking call just as expensive?
00:16:21  <txdv>(I was asking whether I can check if a port is free, you said yeah with that special unix func)
00:16:56  <bnoordhuis>txdv: bind and listen are not really blocking syscalls
00:16:56  <txdv>I mean I can bind to the specific port with and try to listen on it.
00:17:27  <txdv>but listen returns an exceptions immediately if I have a port that is not free
00:19:32  <txdv>you said that fcntl and ioctl are expensive system calls
00:19:37  <txdv>so i wonder if uv_listen is not
00:20:08  <bnoordhuis>iirc that was about checking how much pending data there is
00:20:19  <txdv>o yeah you are right
00:21:46  <txdv>this is another issue, I am using multipe loops in the same process, as you can imagine the cares code gets clashes with the default DNS port if I initialize multiple cares instances in the same process on different loops
00:22:31  <txdv>so I was wondering if I am able to somehow check the free udp ports
00:22:46  <txdv>uv_bind + uv_listen seems somehow tricky
00:22:49  <tjfontaine>I think there's a flag/opt to pass to c-ares that can fix what port it picks
00:23:16  <txdv>yeah it is possible, but the question is, what int number do I pick
00:23:28  <txdv>it would be easier if I could tell cares: pick whatever you want
00:23:59  <bnoordhuis>doesn't c-ares pick a random port?
00:24:00  <tjfontaine>you could call bind without any parameters and see what it sets, hold it open until just before you init c-ares
00:24:17  <txdv>no, it picks the default dns port
00:24:49  <bnoordhuis>i only see two places where it binds, and in both cases sin_port == 0
00:25:14  <txdv>let me try it again
00:26:20  <bnoordhuis>actually... i think it only binds if you specify an interface to bind to
00:26:37  <bnoordhuis>so yeah, you should be good
00:27:11  * rendarquit
00:28:10  * pfox___joined
00:29:35  <txdv>i might have misread the code
00:36:37  <txdv>is there a test trying to create a cares instance on a uv_loop_new()?
00:37:14  <txdv>only on loop default
00:37:42  <txdv>tomorrow ill investigate this further
00:39:42  * dapquit (Quit: Leaving.)
00:40:28  * loladirojoined
00:42:24  <CIA-155>libuv: Bert Belder master * r99a995a / (5 files in 4 dirs): uv_spawn: support setting the child process' user and group id - http://git.io/RlOLug
00:42:24  <CIA-155>libuv: Bert Belder master * rbfd6d46 / (test/test-list.h test/test-spawn.c): Test for the uv_spawn's setuid and setgid options - http://git.io/3w6L3g
00:42:44  <piscisaureus>bnoordhuis: can you forward-port "06ae804 linux: add IN_MOVE_SELF to inotify event mask" ?
00:43:17  <piscisaureus>bnoordhuis: I cherry-picked everything else
00:43:42  <piscisaureus>except for igorzi's fs stuff. I don't know what the status is but that is very conflicting, so it just needs to be ported manually
00:44:04  * brsonquit (Quit: leaving)
00:44:22  * travis-cijoined
00:44:22  <travis-ci>[travis-ci] joyent/libuv#234 (master - bfd6d46 : Bert Belder): The build is still failing.
00:44:22  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/c862acc...bfd6d46
00:44:22  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1194631
00:44:22  * travis-cipart
00:44:48  <bnoordhuis>piscisaureus: sure
00:47:59  <piscisaureus>k. I'm out again.
00:48:33  * piscisaureusquit (Quit: ~ Trillian Astra - www.trillian.im ~)
00:48:47  <CIA-155>libuv: Ben Noordhuis master * rfac3b68 / src/unix/linux/inotify.c :
00:48:47  <CIA-155>libuv: linux: add IN_MOVE_SELF to inotify event mask
00:48:47  <CIA-155>libuv: Partially fixes joyent/node#3172, behavior is now consistent with inotifywait. - http://git.io/LAzlGw
00:50:45  * travis-cijoined
00:50:45  <travis-ci>[travis-ci] joyent/libuv#235 (master - fac3b68 : Ben Noordhuis): The build is still failing.
00:50:45  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/bfd6d46...fac3b68
00:50:45  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1194667
00:50:45  * travis-cipart
00:55:54  * avalanche123quit (Quit: Computer has gone to sleep.)
01:01:14  <txdv>hm
01:13:48  * felixgejoined
01:13:49  * felixgequit (Changing host)
01:13:49  * felixgejoined
01:14:40  * felixgequit (Client Quit)
01:20:13  * TooTallNatequit (Ping timeout: 240 seconds)
01:22:01  * pfox___quit (Ping timeout: 256 seconds)
01:29:08  * isaacsquit (Remote host closed the connection)
01:40:10  * ericktquit (Quit: erickt)
01:46:13  * bnoordhuisquit (Ping timeout: 240 seconds)
01:57:30  * mikealquit (Quit: Leaving.)
01:59:54  * theColejoined
02:17:26  * mikealjoined
02:22:24  * theColequit (Quit: theCole)
02:53:08  * mikealquit (Quit: Leaving.)
03:12:26  * mikealjoined
03:19:51  * mikealquit (Quit: Leaving.)
03:29:20  * mikealjoined
03:33:28  * TooTallNatejoined
03:33:29  * TooTallNatequit (Remote host closed the connection)
03:47:53  * pfox___joined
03:48:08  * pfox___part
03:53:53  * iraquit (Quit: Leaving...)
04:02:46  * c4miloquit (Ping timeout: 252 seconds)
04:49:16  * ericktjoined
04:49:43  * ericktquit (Client Quit)
05:25:26  * avalanche123joined
05:48:40  * loladiroquit (Ping timeout: 246 seconds)
06:51:52  * theColejoined
06:52:35  * theColequit (Client Quit)
08:19:23  * orlandovftwquit (Ping timeout: 245 seconds)
08:23:34  * rendarjoined
08:24:22  * mmalecki[zzz]changed nick to mmalecki
08:34:26  * paddybyersquit (Quit: paddybyers)
08:35:05  * paddybyersjoined
08:53:20  * paddybyersquit (Quit: paddybyers)
09:08:10  * theColejoined
10:28:57  * irajoined
10:30:16  * theColequit (Quit: theCole)
11:13:06  * mralephjoined
11:21:53  * AndreasMadsenjoined
11:31:48  * AvianFluquit (Remote host closed the connection)
11:46:59  * AndreasMadsenquit (Remote host closed the connection)
11:54:02  * AndreasMadsenjoined
12:05:55  * AndreasMadsenquit (Remote host closed the connection)
12:06:03  * AndreasMadsenjoined
12:43:21  * theColejoined
13:43:19  * bnoordhuisjoined
13:50:17  * coderarityquit (Quit: leaving)
14:06:08  * AndreasMadsenquit (Remote host closed the connection)
14:10:14  * `3rdEdenjoined
14:16:13  * ericktjoined
14:31:19  * theColequit (Quit: theCole)
14:44:14  <CIA-155>node: Andreas Madsen master * rab072ee / doc/api/cluster.markdown : doc: document the address object in the cluster listening event - http://git.io/u8Vp4A
15:42:57  * `3rdEdenquit (Quit: Linkinus - http://linkinus.com)
16:02:49  * ericktquit (Quit: erickt)
17:01:53  * c4milojoined
17:32:57  * loladirojoined
17:33:37  * travis-cijoined
17:33:37  <travis-ci>[travis-ci] Skomski/node#11 (master - ab072ee : Andreas Madsen): The build is still failing.
17:33:37  <travis-ci>[travis-ci] Change view : https://github.com/Skomski/node/compare/e9ad453...ab072ee
17:33:37  <travis-ci>[travis-ci] Build details : http://travis-ci.org/Skomski/node/builds/1198279
17:33:37  * travis-cipart
17:37:05  * loladiroquit (Ping timeout: 246 seconds)
17:46:35  * paddybyersjoined
18:15:09  * `3rdEdenjoined
18:19:37  * mikealquit (Quit: Leaving.)
19:12:21  * loladirojoined
19:24:17  * theColejoined
19:32:43  * paddybyersquit (Ping timeout: 240 seconds)
19:33:28  * mikealjoined
20:01:09  * hij1nxjoined
20:01:45  <hij1nx>who is running nodejs on smarts?
20:01:47  <hij1nx>er
20:01:47  <hij1nx>smartOS
20:12:33  * loladiro_joined
20:14:34  * loladiroquit (Ping timeout: 246 seconds)
20:15:43  <bnoordhuis>hij1nx: i am
20:16:07  <hij1nx>bnoordhuis: w00t
20:16:27  <hij1nx>bnoordhuis: i was trying to figure out why the hell i was getting 'sunos' from the os module. i figured it out
20:16:43  <bnoordhuis>good :)
20:17:03  <hij1nx>still kind of wondering why. i mean, i know the lineage, but it seems like it should report 'smartassos' or something
20:17:38  <hij1nx>woah i think i just coined the new smartos codename.
20:18:45  <hij1nx>bnoordhuis: anyway, its obviously not a show stopper or anything, i was just curious about it.
20:19:26  <bnoordhuis>hij1nx: solaris and its ilk are all based on sun's operating system, hence sunos
20:19:44  <bnoordhuis>but i gather you figured that out :)
20:20:11  <hij1nx>bnoordhuis: yep yep, like i said, i know the lineage, but it would be nice to differentiate them when querying from node
20:22:17  * mikealquit (Quit: Leaving.)
20:27:03  * loladiro_quit (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
20:27:17  * loladirojoined
20:28:55  * theColequit (Quit: theCole)
20:46:13  * hij1nxquit (Quit: hij1nx)
20:52:18  * theColejoined
20:54:28  * loladiroquit (Ping timeout: 246 seconds)
20:56:54  * piscisaureus_joined
21:06:25  * igorzi_joined
21:06:35  <igorzi_>piscisaureus_: hey yt?
21:06:44  <piscisaureus_>igorzi_: yup
21:06:51  * piscisaureus_changed nick to piscisaureus
21:07:07  <igorzi_>piscisaureus_: what's going on with libuv in master?
21:07:15  <igorzi_>piscisaureus_: can we update?
21:07:31  <piscisaureus>igorzi: I think, mostly, yeah
21:07:49  <piscisaureus>igorzi_: but there is some uid/gid patch that has to be ported to node master
21:08:03  <piscisaureus>igorzi_: I can do that if you want
21:08:28  <piscisaureus>igorzi: I have a question btw - is the 64 bit offsets patch now complete in libuv master
21:08:46  <piscisaureus>igorzi_: if so, then I know how to resolve all the merge conflicts and I can merge 0.6 into master
21:08:48  <piscisaureus>which would be nice.
21:08:49  <igorzi_>piscisaureus: yep, that's why i'm asking.. it's in libuv master, but not in node
21:08:55  <piscisaureus>ah, ok
21:09:01  <piscisaureus>igorzi: yeah let's do that
21:09:11  <piscisaureus>igorzi_: if you don't mind I first merge libuv
21:09:18  <piscisaureus>won't take long
21:09:24  <igorzi_>piscisaureus: as you remember, in v0.6 we hacked it.. so v0.6 should just be left as it is
21:09:40  <igorzi_>(64bit offsets that is)
21:09:51  <piscisaureus>igorzi: yes. I'm making sure that all the patches in 0.6 are forward ported to master
21:10:14  <piscisaureus>en then I'll resolve all the conflicts as "ours"
21:10:27  <piscisaureus>this helps us keeping track of stuff that is in 0.6 but not in master
21:10:52  <igorzi_>k
21:11:28  <igorzi_>piscisaureus: are you going to do it? (and update libuv in master)
21:12:12  <piscisaureus>igorzi_: I am now going to do the merge. After that we can upgrade libuv in node. But I think we have some work to do.
21:12:27  <piscisaureus>as in, node won't compile any more after upgrading libuv
21:13:07  <igorzi_>yeah, probably
21:17:10  <CIA-155>libuv: Erik Dubbelboer master * r07cfe05 / test/test-spawn.c :
21:17:10  <CIA-155>libuv: test-spawn failed to build on linux
21:17:10  <CIA-155>libuv: - converted c++ style comment to c style comment - http://git.io/bmZQEw
21:17:11  <CIA-155>libuv: Erik Dubbelboer v0.6 * r3b019b4 / test/test-spawn.c :
21:17:11  <CIA-155>libuv: test-spawn failed to build on linux
21:17:11  <CIA-155>libuv: - converted c++ style comment to c style comment - http://git.io/KhIH8Q
21:19:10  * travis-cijoined
21:19:10  <travis-ci>[travis-ci] joyent/libuv#237 (v0.6 - 3b019b4 : Erik Dubbelboer): The build is still failing.
21:19:10  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/d41cc91...3b019b4
21:19:10  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1199560
21:19:10  * travis-cipart
21:19:21  <CIA-155>libuv: Bert Belder master * r44b7421 / : (log message trimmed)
21:19:21  <CIA-155>libuv: Merge branch 'v0.6'
21:19:21  <CIA-155>libuv: Conflicts:
21:19:21  <CIA-155>libuv: include/uv-private/uv-unix.h
21:19:21  <CIA-155>libuv: include/uv-private/uv-win.h
21:19:21  <CIA-155>libuv: include/uv.h
21:19:22  <CIA-155>libuv: src/unix/error.c
21:19:25  * travis-cijoined
21:19:25  <travis-ci>[travis-ci] joyent/libuv#236 (master - 07cfe05 : Erik Dubbelboer): The build is still failing.
21:19:25  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/fac3b68...07cfe05
21:19:25  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1199558
21:19:25  * travis-cipart
21:20:26  <piscisaureus>igorzi_: ok... now I am going to do the merge for node
21:21:16  * travis-cijoined
21:21:16  <travis-ci>[travis-ci] joyent/libuv#238 (master - 44b7421 : Bert Belder): The build is still failing.
21:21:16  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/07cfe05...44b7421
21:21:16  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1199567
21:21:16  * travis-cipart
21:23:59  <igorzi_>piscisaureus: i need to go offline for a while. this patch should be applied to node after libuv is updated: https://github.com/igorzi/node/commit/6956b0b8ae4506bdb6e15ca150788d4e560a51ff
21:24:12  <piscisaureus>igorzi_: ok, will do
21:24:17  <piscisaureus>igorzi: thanks:
21:24:26  <igorzi_>piscisaureus: thx.. ttyl
21:24:47  * igorzi_quit (Quit: Page closed)
21:25:15  * loladirojoined
21:27:18  <tjfontaine>why unset _LARGEFILE_SOURCE?
21:29:29  * c4miloquit (Ping timeout: 245 seconds)
21:30:48  <piscisaureus>igorzi: ^-- ?
21:31:48  <piscisaureus>tjfontaine: let's wait until he answers that.
21:32:39  * `3rdEdenquit (Quit: Linkinus - http://linkinus.com)
21:33:01  <piscisaureus>bnoordhuis: hey, yt?
21:35:52  <bnoordhuis>piscisaureus: yep
21:36:00  <piscisaureus>bnoordhuis: good
21:36:13  <bnoordhuis>comforting, isn't it?
21:37:17  <mmalecki>i just lol'd
21:37:36  <CIA-155>node: Bert Belder reviewme * r3546383 / src/process_wrap.cc : process_wrap: avoid leaking memory when throwing due to invalid arguments - http://git.io/Muz4NA
21:37:49  <piscisaureus>^-- bnoordhuis: I'd like you to review that
21:38:47  <bnoordhuis>piscisaureus: and i'd like a pony. we don't always get what we want
21:39:22  <bnoordhuis>okay, i'll review it
21:42:28  <bnoordhuis>piscisaureus: is that patch against master or v0.6?
21:42:37  <piscisaureus>bnoordhuis: v0.6
21:43:01  <bnoordhuis>right, because i remember that particular bug got fixed in master a while ago
21:43:26  <piscisaureus>bnoordhuis: well, a patch was landed that made us malloc less
21:43:41  <piscisaureus>bnoordhuis: but mallocs still happen on master for args and for env
21:43:52  <bnoordhuis>249c3c1 and 253ec6a
21:44:09  <bnoordhuis>maybe cherry-pick those
21:44:23  <piscisaureus>bnoordhuis: I would
21:44:34  <bnoordhuis>would or will?
21:44:55  <piscisaureus>bnoordhuis: but this patch is still needed I thin
21:45:17  <bnoordhuis>maybe not 249c3c1, that's more of a cosmetic change
21:45:47  <piscisaureus>bnoordhuis: there might be a small perf impact
21:45:58  <piscisaureus>bnoordhuis: so I can cherry pick 253ec
21:46:16  <piscisaureus>bnoordhuis: but my patch is still needed because otherwise memory allocated for the env and args still leaks
21:46:30  <bnoordhuis>right
21:46:37  <bnoordhuis>hmm, mixing strdup() and delete[]
21:46:52  <bnoordhuis>oh wait, no
21:46:59  <piscisaureus>bnoordhuis: well, it's a mess anyway
21:47:04  <bnoordhuis>yeah
21:47:05  <piscisaureus>bnoordhuis: so it's good that ssuda fixed it
21:47:35  <piscisaureus>he seems capable - so I would like him to discuss stuff with us before writing patches :-)
21:48:15  <tjfontaine>does he not lurk on irc?
21:48:30  <piscisaureus>not that I know of
21:49:06  <piscisaureus>I mean this unregister function patch
21:49:15  <piscisaureus>it would be nice if he had actually talked to us about it
21:49:19  <bnoordhuis>yeah
21:49:24  <bnoordhuis>especially because i already wrote it
21:49:43  <bnoordhuis>his patch looks remarkably similar to mine actually, he probably copied the spirit of it
21:49:49  <bnoordhuis>piscisaureus: patch lgtm
21:50:41  <bnoordhuis>it would be better if that function had a single exit point
21:51:00  <piscisaureus>bnoordhuis: yeah
21:51:03  <CIA-155>node: Bert Belder v0.6 * r3546383 / src/process_wrap.cc : process_wrap: avoid leaking memory when throwing due to invalid arguments - http://git.io/Muz4NA
21:51:08  <piscisaureus>bnoordhuis: but that also get messy
21:51:17  <bnoordhuis>why? forward gotos ftw
21:51:28  <piscisaureus>bnoordhuis: well that won't really work...
21:51:35  <bnoordhuis>sure it will
21:51:40  <piscisaureus>bnoordhuis: you have to check whether an exception was throws
21:51:52  <bnoordhuis>js exception or c++ exception?
21:51:52  <piscisaureus>bnoordhuis: and then return an appropriate value instead of Integer::New(r)
21:51:56  <piscisaureus>js exception
21:52:09  <piscisaureus>bnoordhuis: of course- it's doable
21:52:34  <CIA-155>node: ssuda v0.6 * rdb844b1 / src/process_wrap.cc :
21:52:34  <CIA-155>node: process: don't use strdup()
21:52:34  <CIA-155>node: file and cwd can be directly used from Utf8Value.
21:52:34  <CIA-155>node: Conflicts:
21:52:34  <CIA-155>node: src/process_wrap.cc - http://git.io/DjrhbA
21:52:45  <piscisaureus>^-- bnoordhuis: as you wish.
21:52:57  <bnoordhuis>very good
21:52:59  <piscisaureus>bnoordhuis: now emailing isaacs that there is a memleak in 0.6.16-release :-(
21:53:13  <bnoordhuis>at least it got caught in time
21:55:05  <piscisaureus>bnoordhuis: I think I'm going to force push that in
21:55:11  <piscisaureus>bnoordhuis: muhaha
21:56:53  <bnoordhuis>why is erik's patch in the commit history twice? merge artifact?
21:57:02  <piscisaureus>bnoordhuis: No I landed it on two branches
21:57:23  <bnoordhuis>i'm seeing it twice on master
21:57:25  <bnoordhuis>same commit too
21:57:32  * theColequit (Quit: theCole)
21:57:33  <bnoordhuis>oh, i see
21:57:56  <piscisaureus>bnoordhuis: do you mind if I do 2 force pushes ?
21:57:59  <piscisaureus>to libuv ?
21:58:04  <bnoordhuis>sure
21:58:46  <mmalecki>evil.
21:58:48  <bnoordhuis>piscisaureus: btw, his PR is correct - unix needs unistd.h
21:58:56  <piscisaureus>bnoordhuis: ok.
21:58:58  <piscisaureus>bnoordhuis: fixing it
22:02:45  <CIA-155>libuv: Erik Dubbelboer master * r6234416 / test/test-spawn.c :
22:02:45  <CIA-155>libuv: test-spawn failed to build on linux
22:02:45  <CIA-155>libuv: - added missing header file
22:02:45  <CIA-155>libuv: - converted c++ style comment to c style comment - http://git.io/gAg0aw
22:02:46  <CIA-155>libuv: Bert Belder master * re2cae34 / : (log message trimmed)
22:02:46  <CIA-155>libuv: Merge branch 'v0.6'
22:02:46  <CIA-155>libuv: Conflicts:
22:02:46  <CIA-155>libuv: include/uv-private/uv-unix.h
22:02:46  <CIA-155>libuv: include/uv-private/uv-win.h
22:02:46  <CIA-155>libuv: include/uv.h
22:02:47  <CIA-155>libuv: src/unix/error.c
22:04:40  * travis-cijoined
22:04:41  <travis-ci>[travis-ci] joyent/libuv#239 (master - e2cae34 : Bert Belder): The build is still failing.
22:04:41  <travis-ci>[travis-ci] Change view : https://github.com/joyent/libuv/compare/44b7421...e2cae34
22:04:41  <travis-ci>[travis-ci] Build details : http://travis-ci.org/joyent/libuv/builds/1199790
22:04:41  * travis-cipart
22:07:58  <CIA-155>node: Bert Belder v0.6 * r3546383 / src/process_wrap.cc : process_wrap: avoid leaking memory when throwing due to invalid arguments - http://git.io/Muz4NA
22:07:59  <CIA-155>node: ssuda v0.6 * rdb844b1 / src/process_wrap.cc :
22:07:59  <CIA-155>node: process: don't use strdup()
22:07:59  <CIA-155>node: file and cwd can be directly used from Utf8Value.
22:07:59  <CIA-155>node: Conflicts:
22:07:59  <CIA-155>node: src/process_wrap.cc - http://git.io/DjrhbA
22:08:50  * rendarquit
22:29:11  <CIA-155>node: Bert Belder master * r3bcbd14 / src/process_wrap.cc :
22:29:11  <CIA-155>node: process_wrap: don't use uv_spawn2
22:29:11  <CIA-155>node: It was a temporary thing for the 0.6 branch only. (+13 more commits...) - http://git.io/t6nSmg
22:30:40  <piscisaureus>igorzi: your patch can land on top
22:30:51  <piscisaureus>igorzi: but I wonder why _LARGEFILE_SOURCE has to be undef'ed
22:31:17  <tjfontaine>I don't think we want to, I think it was because it was set during the fix
22:35:30  * paddybyersjoined
22:40:35  <piscisaureus>bnoordhuis: can you judge this? https://github.com/vvo/node/commit/e138f76ab243ba3579ac859f08261a721edc20fe
22:40:56  <piscisaureus>bnoordhuis: I would be surprised ...
22:41:20  <bnoordhuis>piscisaureus: https://github.com/joyent/node/issues/3179#issuecomment-5382402
22:42:04  <bnoordhuis>tl;dr yes, looks like there's a leak and no, that patch doesn't fix the issue
22:42:46  <piscisaureus>bnoordhuis: ah, thanks for pointing it out.
22:43:02  <piscisaureus>bnoordhuis: can we not use the live object list or something to figure out what is being leaked?
22:43:31  <bnoordhuis>piscisaureus: yes. actually, you can review that patch :)
22:43:58  <bnoordhuis>https://github.com/bnoordhuis/node/compare/issue3180
22:44:46  <piscisaureus>bnoordhuis: review all of them?
22:45:00  <bnoordhuis>piscisaureus: yes. not necessarily now though
22:45:42  <piscisaureus>bnoordhuis: oh, right
22:45:55  <piscisaureus>bnoordhuis: with "live object list" I meant the v8 feature
22:46:09  <piscisaureus>bnoordhuis: but it's nice that we now also have a "live handles list" :-)
22:46:12  <bnoordhuis>on a side note, the test seems to catch a leak because i never see the connect req go
22:47:14  <bnoordhuis>piscisaureus: have you tried node-webkit-agent?
22:48:24  * ericktjoined
22:53:32  <piscisaureus>bnoordhuis: no. should I ?
22:53:51  * paddybyersquit (Quit: paddybyers)
22:56:05  <bnoordhuis>piscisaureus: yes. because then i won't have to :)
22:56:26  <bnoordhuis>it looks nice but i wonders what it does differently than node-inspector
22:56:35  <piscisaureus>bnoordhuis: is there an issue with it or someting?
22:57:17  <bnoordhuis>no. but since we were discussing memory leaks
22:57:30  <piscisaureus>ah, ok
22:57:40  <piscisaureus>let me install node again :-p
22:57:57  <tjfontaine>I've never had much luck with -inspector staying alive
22:58:13  <bnoordhuis>one thing node-webkit-agent has going for it is that it compiles with 0.7
22:58:50  <mmalecki>you actually got it to work?
22:59:37  <bnoordhuis>which one?
22:59:46  <mmalecki>node-webkit-agent
23:00:07  <piscisaureus>does not work for me
23:00:10  <piscisaureus>uses node-waf :-(
23:00:36  <bnoordhuis>mmalecki: it compiles
23:00:51  <mmalecki>bnoordhuis: does it work?
23:00:58  <mmalecki>like, actually work?
23:01:12  <mmalecki>I tried without much luck
23:01:15  <piscisaureus>v8-profiler@3.6.2beta preinstall
23:01:21  <piscisaureus>needs node-waf
23:01:22  <piscisaureus>BAH
23:02:14  <tjfontaine>actually should be trivial to do a binding.gyp because it just compiles *.cc
23:04:03  * indutnyjoined
23:13:16  <tjfontaine>oh man, what did I break
23:13:29  <tjfontaine>Non-function in MakeCallback. method = 1870078063
23:30:46  * ericktquit (Quit: erickt)
23:34:55  <bnoordhuis>tjfontaine: you're trying to invoke obj.fun() but obj.fun is not actually a function
23:35:39  <bnoordhuis>1870078063 is kind of an odd name for a method
23:37:00  <mmalecki>well, it's a good method name if you want job security
23:39:25  <bnoordhuis>btw, node-webkit-agent now compiles with node-gyp
23:40:27  <mmalecki>lol
23:40:34  <mmalecki>Poland! http://www.huffingtonpost.com/2012/04/28/dentist-pulls-all-exs-teeth-out_n_1461288.html?ncid=edlinkusaolp00000003
23:40:34  <piscisaureus>bnoordhuis: did you commit?
23:41:00  <piscisaureus>yay! poland made the news :-p
23:41:08  <bnoordhuis>piscisaureus: sent a PR, got merged
23:41:19  <piscisaureus>ah, that's pretty quick
23:41:35  <mmalecki>I probably shouldn't be deploying code after that many drinks
23:42:07  <piscisaureus>bnoordhuis: niks van te zien
23:42:10  <piscisaureus>trouwens
23:42:47  <piscisaureus>bnoordhuis: ah wait the PR was not for node-webkit-agent
23:42:54  <bnoordhuis>no, v8-profiler
23:43:31  <piscisaureus>I'm going to sit and wait to see if he updates node-webkit-agent
23:43:34  <piscisaureus>lazyness is lazy
23:53:27  <benvie>wow that article makes me cringe
23:53:43  <benvie>there was a horror movie about the same exact thing
23:53:55  <piscisaureus>you mean, old boy?
23:54:11  <piscisaureus>the marathon man?
23:54:26  <benvie>ripping teeth out
23:54:56  * mralephquit (Quit: Leaving.)
23:55:20  <benvie>although in this case I guess she used anasthetics, how kind
23:56:42  <piscisaureus>pulling out all teeth was common practice in holland 40 years ago
23:57:01  <benvie>the guy talks about saving up money?
23:57:12  <benvie>oh yeah this isn't the US
23:57:26  <benvie>in the US he'd automatically be a multimillionaire now from the lawsuit
23:57:50  <piscisaureus>well, he'd be entitled to millions
23:57:58  <piscisaureus>question is always whether you can get it
23:58:05  <benvie>well medical malpractice is usually an easy one
23:58:16  <benvie>since they all have mega insurance specifically to pay for it
23:58:58  <piscisaureus>I wonder if malpractice insurance covers thi
23:58:59  <piscisaureus>s
23:59:07  <benvie>that's a good question
23:59:59  <benvie>at first I thought obviously yes, but the purpose of it is to cover basically accidents or neglect