| 00:02:10
| * piscisaureus_ | joined |
| 00:21:34
| * mikeal | joined |
| 00:35:39
| <tjfontaine> | inline documentation is sorta like autohell, everyone hates it, except for all the other solutions [granted autohell doesn't particularly apply to the project] |
| 00:42:54
| * piscisaureus_ | quit (Quit: ~ Trillian Astra - www.trillian.im ~) |
| 01:03:14
| * isaacs | quit (Remote host closed the connection) |
| 01:04:26
| * isaacs | joined |
| 01:10:11
| * isaacs | quit (Ping timeout: 244 seconds) |
| 01:14:18
| * isaacs | joined |
| 01:23:13
| * dap | quit (Quit: Leaving.) |
| 01:25:47
| * stephank | quit (Quit: *Poof!*) |
| 01:40:16
| * isaacs | quit (Remote host closed the connection) |
| 01:41:00
| * isaacs | joined |
| 01:41:21
| * bnoordhuis | quit (Ping timeout: 245 seconds) |
| 01:44:07
| * stephank | joined |
| 01:46:19
| * isaacs | quit (Read error: Connection reset by peer) |
| 01:46:39
| * isaacs | joined |
| 01:47:24
| * isaacs | quit (Remote host closed the connection) |
| 01:48:13
| * isaacs | joined |
| 01:49:59
| * dshaw_ | quit (Ping timeout: 248 seconds) |
| 01:55:43
| * isaacs | quit (Ping timeout: 252 seconds) |
| 01:56:25
| * dannycoates | part |
| 02:00:23
| * orlandovftw | quit (Ping timeout: 252 seconds) |
| 02:02:08
| * mikeal | quit (Quit: Leaving.) |
| 02:41:50
| * TooTallNate | quit (Quit: Linkinus - http://linkinus.com) |
| 02:45:28
| * pietern | quit (Quit: pietern) |
| 02:45:58
| * piscisaureus_ | joined |
| 02:47:18
| * brson | quit (Quit: leaving) |
| 02:52:46
| * piscisaureus_ | quit (Quit: ~ Trillian Astra - www.trillian.im ~) |
| 03:42:33
| * mikeal | joined |
| 03:43:37
| * mikeal | quit (Client Quit) |
| 03:46:51
| * mikeal | joined |
| 04:01:01
| * mraleph1 | joined |
| 04:11:20
| * mikeal | quit (Quit: Leaving.) |
| 04:13:29
| * mikeal | joined |
| 04:37:48
| * mikeal | quit (Quit: Leaving.) |
| 05:12:46
| * mikeal | joined |
| 05:14:44
| * mikeal | quit (Client Quit) |
| 05:14:52
| * mikeal | joined |
| 05:34:10
| * mikeal | quit (Quit: Leaving.) |
| 05:36:06
| * mikeal | joined |
| 05:38:33
| * mikeal | quit (Client Quit) |
| 05:39:36
| * mjr_ | quit (Quit: mjr_) |
| 05:48:28
| * mikeal | joined |
| 05:55:05
| * mraleph1 | quit (Quit: Leaving.) |
| 06:51:10
| * mikeal | quit (Quit: Leaving.) |
| 06:57:06
| * mikeal | joined |
| 06:58:13
| * isaacs | joined |
| 07:17:41
| * isaacs | quit (Remote host closed the connection) |
| 07:21:28
| * mikeal | quit (Quit: Leaving.) |
| 07:25:58
| * orlandovftw | joined |
| 07:39:00
| * mikeal | joined |
| 07:44:51
| * orlandovftw | quit (Ping timeout: 255 seconds) |
| 07:54:01
| * mikeal | quit (Quit: Leaving.) |
| 08:05:54
| * mikeal | joined |
| 08:17:47
| * mikeal | quit (Quit: Leaving.) |
| 08:20:51
| * mikeal | joined |
| 08:25:32
| * paddybyers | joined |
| 08:32:24
| * mikeal | quit (Quit: Leaving.) |
| 08:34:01
| * mikeal | joined |
| 09:14:56
| * paddybyers | quit (Quit: paddybyers) |
| 09:39:05
| * AndreasMadsen | joined |
| 10:27:59
| * `3rdEden | joined |
| 11:01:43
| * mraleph1 | joined |
| 12:21:32
| * sj26 | quit (Excess Flood) |
| 12:22:29
| * sj26 | joined |
| 12:27:25
| * AvianFlu | quit (Quit: Leaving) |
| 13:31:34
| * igorzi | quit (Ping timeout: 245 seconds) |
| 13:37:00
| * paddybyers | joined |
| 13:54:32
| * paddybyers | quit (Quit: paddybyers) |
| 14:20:46
| * AndreasMadsen | quit (Remote host closed the connection) |
| 14:30:50
| * paddybyers | joined |
| 14:55:42
| * `3rdEden | quit (Quit: Leaving...) |
| 15:30:44
| * bnoordhuis | joined |
| 15:48:15
| * orlandovftw | joined |
| 16:01:18
| * paddybyers | quit (Quit: paddybyers) |
| 16:02:33
| * orlandovftw | quit (Ping timeout: 272 seconds) |
| 16:34:21
| * indutny | changed nick to iiii |
| 16:35:51
| * iiii | changed nick to indutny |
| 16:36:45
| * AndreasMadsen | joined |
| 16:38:45
| * piscisaureus_ | joined |
| 16:39:36
| * piscisaureus_ | quit (Client Quit) |
| 16:43:35
| * paddybyers | joined |
| 17:20:34
| <bnoordhuis> | https://github.com/bnoordhuis/node/commit/5c88ad2 <- isolates revert, last call for review |
| 17:21:12
| <bnoordhuis> | simple/test-script-new assert in node_object_wrap.h but that's not thanks to this commit |
| 17:21:12
| <mmalecki> | bnoordhuis: I think AndreasMadsen had some opinion on it |
| 17:21:26
| <AndreasMadsen> | hi |
| 17:21:30
| <bnoordhuis> | mmalecki: yeah, i fixed that |
| 17:21:43
| <mmalecki> | bnoordhuis: ++, for reverting it |
| 17:21:45
| <kohai> | bnoordhuis has 6 beers |
| 17:21:57
| <AndreasMadsen> | looking again |
| 17:23:24
| <mmalecki> | funny thing, I recall few of my pull requests being rejected because of isolates. |
| 17:23:35
| <mmalecki> | can we go through them again? |
| 17:23:53
| <AndreasMadsen> | :D |
| 17:24:48
| <AndreasMadsen> | the revert looks fine |
| 17:25:32
| <bnoordhuis> | i think i'll land it monday to give other people a chance to go over it |
| 17:25:52
| <bnoordhuis> | mmalecki: depends... were they features or bug fixes? |
| 17:27:37
| <mmalecki> | bnoordhuis: bug fixes. fork.{stdout,stderr}. |
| 17:28:32
| <AndreasMadsen> | ^ -- https://github.com/joyent/node/pull/2454 |
| 17:29:02
| <mmalecki> | that, thanks AndreasMadsen |
| 17:31:55
| <bnoordhuis> | i suppose it's reasonable, now that isolates are out |
| 17:32:01
| <bnoordhuis> | but i won't land it just yet :) |
| 17:32:26
| <mmalecki> | bnoordhuis: I'll allow it |
| 17:32:46
| <mmalecki> | bnoordhuis: can you reopen it, btw? |
| 17:32:52
| <bnoordhuis> | you're too kind, maciej |
| 17:32:54
| <bnoordhuis> | no, really |
| 17:32:56
| <bnoordhuis> | sure |
| 17:33:11
| <mmalecki> | thanks |
| 17:33:41
| * AndreasM_ | joined |
| 17:34:38
| * AndreasMadsen | quit (Read error: Connection reset by peer) |
| 17:35:08
| <AndreasM_> | wow my router just crashed in a very funny way |
| 17:35:08
| <AndreasM_> | mmalecki: did you see the independent patch I made to node.js (to replace process.exit(0) in forever) |
| 17:35:23
| <mmalecki> | AndreasM_: .disconnect()? |
| 17:35:37
| <mmalecki> | AndreasM_: yeah, it's awesome! I'll give it a go in forever soon ;) |
| 17:35:41
| <AndreasM_> | mmalecki: no to pull a process in the background |
| 17:35:53
| <mmalecki> | oh, not, not really, link? |
| 17:35:56
| <AndreasM_> | https://github.com/joyent/node/pull/2676 |
| 17:36:50
| <AndreasM_> | mmalecki: you can't use the .disconnect in forever - the parent will still be alive until the child die, but .independent pull the child away |
| 17:37:12
| <AndreasM_> | I'm open to other names :) |
| 17:37:42
| <mmalecki> | oh, I see. yeah, name can be misleading a bit. naming things is hard :/ |
| 17:39:24
| <mmalecki> | this is pretty much implementing unix fork(2). it's a good addition |
| 17:39:59
| <AndreasM_> | mmalecki: oh did not know, really! |
| 17:40:47
| <mmalecki> | :) |
| 17:41:51
| <AndreasM_> | mmalecki: I do not really use time with unix and C(++), just made my fist c++ (v8) patch yesterday to node.js |
| 17:42:06
| <AndreasM_> | And it has been two years since I touched C :) |
| 17:43:12
| <mmalecki> | I try to refresh my skills when I have time |
| 17:43:55
| <mmalecki> | me and AvianFlu recently wrote this https://github.com/AvianFlu/aeternum |
| 17:44:36
| <AndreasM_> | mmalecki: "that should daemonize" - hmm |
| 17:44:40
| <AndreasM_> | why should |
| 17:45:32
| <mmalecki> | oh well, dunno, I didn't write the README. it always worked when I tested it, tho |
| 17:46:49
| <AndreasM_> | mmalecki: hehe sure |
| 17:47:35
| <AndreasM_> | find my self thinking about how to write a daemonizer in pure javascript (have used that language too much) |
| 18:07:23
| <indutny> | b reviewing |
| 18:07:46
| <indutny> | [6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~[6~ |
| 18:07:49
| <indutny> | oops |
| 18:07:54
| <indutny> | bnoordhuis: reviewing |
| 18:16:29
| <indutny> | bnoordhuis: https://github.com/bnoordhuis/node/commit/5c88ad2#L8R1799 ? |
| 18:20:33
| * AndreasM_ | quit (Remote host closed the connection) |
| 18:21:58
| <indutny> | otherwise lgtm |
| 18:38:54
| * isaacs | joined |
| 18:49:04
| * AndreasMadsen | joined |
| 18:58:58
| * perezd | quit (Quit: perezd) |
| 19:06:38
| * paddybyers | quit (Quit: paddybyers) |
| 19:29:21
| * brson | joined |
| 19:30:59
| * mikeal | quit (Quit: Leaving.) |
| 19:40:05
| * perezd | joined |
| 19:40:32
| * perezd | quit (Read error: Connection reset by peer) |
| 19:40:49
| * perezd | joined |
| 19:53:35
| * paddybyers | joined |
| 20:10:02
| <bnoordhuis> | indutny: thanks. what did 44e7033 fix? the commit log says 'debugger segfaults' |
| 20:15:32
| <bnoordhuis> | perhaps i should rephrase my question as 'how did 44e7033 fix those segfaults'... |
| 20:18:00
| <indutny> | bnoordhuis: haha |
| 20:18:05
| <indutny> | bnoordhuis: ok, let me explain |
| 20:18:29
| * bnoordhuis | listens attentively |
| 20:18:50
| <indutny> | bnoordhuis: this thing is incorrect, debugger will segfault only if process multiple isolates, but anyway |
| 20:19:10
| <indutny> | bnoordhuis: it was added years ago, and in fact is completely useless |
| 20:19:47
| <bnoordhuis> | indutny: dead code, check |
| 20:19:48
| <indutny> | bnoordhuis: because it's purpose is to allow event-loop to process events |
| 20:20:05
| <indutny> | bnoordhuis: but it's able to do it anyway |
| 20:20:18
| <indutny> | bnoordhuis: you can try removing this code and debugging a web server |
| 20:20:35
| <bnoordhuis> | indutny: yeah, i did - works okay |
| 20:21:02
| <indutny> | ff |
| 20:22:08
| <indutny> | bnoordhuis: cool |
| 20:22:38
| <bnoordhuis> | https://github.com/bnoordhuis/node/commit/e0a8d82 is the updated commit |
| 20:22:41
| <indutny> | bnoordhuis: it was segfaulting, because v8 calls dipsatch handler in separate thread |
| 20:22:51
| <bnoordhuis> | right, makes sense |
| 20:23:56
| <indutny> | lgtm |
| 20:24:10
| <indutny> | haven't tried to compile though |
| 20:30:56
| <bnoordhuis> | indutny: compiles, passes all tests except simple/test-script-new |
| 20:31:46
| <bnoordhuis> | but that test was failing anyway, i think it's something in v8 that has changed |
| 20:33:01
| <indutny> | bnoordhuis: huh, lets see |
| 20:33:34
| <indutny> | what is a stack trace? |
| 20:34:04
| <bnoordhuis> | a stack trace is a list-like overview of the function call graph |
| 20:34:12
| <bnoordhuis> | but that's probably not what you meant :) |
| 20:34:56
| <bnoordhuis> | indutny: the failing test is equivalent to (new (require("vm").Script)("")).runInNewContext.call("") |
| 20:35:09
| <bnoordhuis> | triggers an assertion in node_object_wrap.h in master but works fine in v0.6 |
| 20:35:24
| <bnoordhuis> | and nothing in either objectwrap or node_script.cc has changed |
| 20:36:02
| <indutny> | bnoordhuis: etymology-man http://xkcd.com/1010/ |
| 20:37:24
| <bnoordhuis> | very appropriate :) |
| 20:55:00
| <bnoordhuis> | ircretary: tell piscisaureus to check out https://github.com/graydon/libuv/commit/1170ffb |
| 20:55:01
| <ircretary> | bnoordhuis: I'll be sure to tell piscisaureus |
| 20:55:43
| <indutny> | bnoordhuis: ircretary lies |
| 20:56:12
| <bnoordhuis> | indutny: i have faith |
| 20:56:55
| * paddybyers | quit (Quit: paddybyers) |
| 21:00:41
| * AndreasMadsen | quit (Remote host closed the connection) |
| 21:11:46
| * `3rdEden | joined |
| 21:15:43
| <CIA-114> | node: Christopher Jeffrey v0.6 * rf64989e / (lib/fs.js test/simple/test-fs-read-stream-fd.js): |
| 21:15:43
| <CIA-114> | node: fs: fix ReadStream fails to read from existing fd |
| 21:15:43
| <CIA-114> | node: A ReadStream constructed from an existing file descriptor failed to start |
| 21:15:43
| <CIA-114> | node: reading automatically. Avoids a userspace call to ReadStream.prototype._read(). - http://git.io/RMt60g |
| 21:21:32
| <CIA-114> | node: Marcel Laverdet v0.6 * r11d1eca / src/node.cc : |
| 21:21:32
| <CIA-114> | node: Add explicit v8 locker |
| 21:21:32
| <CIA-114> | node: v8 requires a lock of each thread using the vm, but if none is |
| 21:21:32
| <CIA-114> | node: explicitly is created it will implicitly create one for you. This |
| 21:21:32
| <CIA-114> | node: creates issues when trying to build modules which use v8's |
| 21:21:33
| <CIA-114> | node: multi-threading features because there's no lock to unlock. - http://git.io/gyl-Yg |
| 21:23:27
| * travis-ci | joined |
| 21:23:27
| <travis-ci> | [travis-ci] joyent/node#365 (v0.6 - f64989e : Christopher Jeffrey): The build is still failing. |
| 21:23:27
| <travis-ci> | [travis-ci] Change view : https://github.com/joyent/node/compare/07a983a...f64989e |
| 21:23:27
| <travis-ci> | [travis-ci] Build details : http://travis-ci.org/joyent/node/builds/626935 |
| 21:23:27
| * travis-ci | part |
| 21:29:19
| * travis-ci | joined |
| 21:29:19
| <travis-ci> | [travis-ci] joyent/node#366 (v0.6 - 11d1eca : Marcel Laverdet): The build was fixed. |
| 21:29:19
| <travis-ci> | [travis-ci] Change view : https://github.com/joyent/node/compare/f64989e...11d1eca |
| 21:29:19
| <travis-ci> | [travis-ci] Build details : http://travis-ci.org/joyent/node/builds/626959 |
| 21:29:19
| * travis-ci | part |
| 21:42:47
| * theCole | joined |
| 22:07:35
| * mraleph1 | quit (Quit: Leaving.) |
| 22:11:42
| <bnoordhuis> | mraleph: https://gist.github.com/893d44a6cbb55f531961 <- mind-numbingly trivial patch unworthy of opening an issue for. i won't feel offended if you don't take it :) |
| 22:22:24
| * theCole | part |
| 22:24:49
| * theCole | joined |
| 22:41:17
| * TooTallNate | joined |
| 22:43:18
| <TooTallNate> | isaacs: hey |
| 22:43:21
| <TooTallNate> | isaacs: did you compile the node.exe for windows for the last 0.6.x release? |
| 22:55:52
| * paddybyers | joined |
| 23:01:12
| <indutny> | bnoordhuis: I think opening CL would speed up commiting it into |
| 23:01:20
| <indutny> | bnoordhuis: less people will need to review it |
| 23:01:33
| <isaacs> | TooTallNate: yeah, what's up with it? |
| 23:01:45
| * orlandovftw | joined |
| 23:01:47
| <bnoordhuis> | indutny: oh, like i said - it's too trivial to waste much time on |
| 23:01:56
| <isaacs> | TooTallNate: http://nodejs.org/dist/latest/node.exe |
| 23:01:57
| <indutny> | bnoordhuis: heh, ok. |
| 23:01:57
| <TooTallNate> | isaacs: nothing's wrong, i just wanted your node.lib file :p |
| 23:02:02
| <isaacs> | ohoh, right |
| 23:02:05
| <TooTallNate> | but don't worry, i'm compiling on my own |
| 23:02:06
| <isaacs> | yeah, that's a good idea, one sec |
| 23:02:25
| <TooTallNate> | i'm gonna host them on s3 for the time being |
| 23:02:33
| <TooTallNate> | but ideally you guys put them in the release dir |
| 23:03:04
| <isaacs> | TooTallNate: done |
| 23:03:22
| <isaacs> | TooTallNate: is it worth uploading for all the old releases? |
| 23:03:30
| <isaacs> | TooTallNate: or just moving forward? |
| 23:03:52
| <TooTallNate> | well the old ones would be nice |
| 23:04:05
| <TooTallNate> | if someone has them lying around :p |
| 23:04:46
| <TooTallNate> | but the exported symbols between minor versions shouldn't change... ever.. so really only 1 per minor version is needed |
| 23:12:30
| * paddybyers | quit (Quit: paddybyers) |
| 23:14:42
| <TooTallNate> | isaacs: can you put up a 0.7.x one too? |
| 23:42:35
| * theCole | quit (Quit: theCole) |
| 23:45:16
| * ircretary1 | joined |
| 23:45:28
| * ircretary | quit (Ping timeout: 255 seconds) |